Title: [244356] trunk/Source/WebKit
- Revision
- 244356
- Author
- [email protected]
- Date
- 2019-04-16 13:39:34 -0700 (Tue, 16 Apr 2019)
Log Message
REGRESSION(r243557)[ContentChangeObserver] Need to double tap text formatting elements in MS Word web app
https://bugs.webkit.org/show_bug.cgi?id=196975
<rdar://problem/49489849>
Reviewed by Simon Fraser.
This patch ensures that we always proceed with synthetic click on form elements.
Covered by existing tests.
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::handleSyntheticClick):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (244355 => 244356)
--- trunk/Source/WebKit/ChangeLog 2019-04-16 20:32:49 UTC (rev 244355)
+++ trunk/Source/WebKit/ChangeLog 2019-04-16 20:39:34 UTC (rev 244356)
@@ -1,3 +1,18 @@
+2019-04-16 Zalan Bujtas <[email protected]>
+
+ REGRESSION(r243557)[ContentChangeObserver] Need to double tap text formatting elements in MS Word web app
+ https://bugs.webkit.org/show_bug.cgi?id=196975
+ <rdar://problem/49489849>
+
+ Reviewed by Simon Fraser.
+
+ This patch ensures that we always proceed with synthetic click on form elements.
+
+ Covered by existing tests.
+
+ * WebProcess/WebPage/ios/WebPageIOS.mm:
+ (WebKit::WebPage::handleSyntheticClick):
+
2019-04-16 Timothy Hatcher <[email protected]>
FrameView base background color always starts white.
Modified: trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm (244355 => 244356)
--- trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2019-04-16 20:32:49 UTC (rev 244355)
+++ trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2019-04-16 20:39:34 UTC (rev 244356)
@@ -604,7 +604,8 @@
if (protectedThis->m_isClosed || !protectedThis->corePage())
return;
- if (observedContentChange == WKContentVisibilityChange) {
+ auto shouldStayAtHoverState = observedContentChange == WKContentVisibilityChange && !is<HTMLFormControlElement>(targetNode);
+ if (shouldStayAtHoverState) {
// The move event caused new contents to appear. Don't send synthetic click event, but just ensure that the mouse is on the most recent content.
dispatchSyntheticMouseMove(protectedThis->corePage()->mainFrame(), location, modifiers);
LOG(ContentObservation, "handleSyntheticClick: Observed meaningful visible change -> hover.");
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
