Title: [244365] trunk/Source/WebKit
- Revision
- 244365
- Author
- [email protected]
- Date
- 2019-04-16 17:33:16 -0700 (Tue, 16 Apr 2019)
Log Message
-[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
https://bugs.webkit.org/show_bug.cgi?id=196991
<rdar://problem/45507423>
Reviewed by Brent Fulgham.
The credentials are stored in the Network process. To enable fetching credentials from the Network process,
a proper process access type needs to be set for the credential Website data type.
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::computeNetworkProcessAccessTypeForDataFetch):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (244364 => 244365)
--- trunk/Source/WebKit/ChangeLog 2019-04-17 00:18:11 UTC (rev 244364)
+++ trunk/Source/WebKit/ChangeLog 2019-04-17 00:33:16 UTC (rev 244365)
@@ -1,3 +1,17 @@
+2019-04-16 Per Arne Vollan <[email protected]>
+
+ -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
+ https://bugs.webkit.org/show_bug.cgi?id=196991
+ <rdar://problem/45507423>
+
+ Reviewed by Brent Fulgham.
+
+ The credentials are stored in the Network process. To enable fetching credentials from the Network process,
+ a proper process access type needs to be set for the credential Website data type.
+
+ * UIProcess/WebsiteData/WebsiteDataStore.cpp:
+ (WebKit::computeNetworkProcessAccessTypeForDataFetch):
+
2019-04-16 Alex Christensen <[email protected]>
REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
Modified: trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp (244364 => 244365)
--- trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp 2019-04-17 00:18:11 UTC (rev 244364)
+++ trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp 2019-04-17 00:33:16 UTC (rev 244365)
@@ -238,6 +238,9 @@
processAccessType = std::max(processAccessType, ProcessAccessType::Launch);
}
+ if (dataTypes.contains(WebsiteDataType::Credentials) && !isNonPersistentStore)
+ processAccessType = std::max(processAccessType, ProcessAccessType::Launch);
+
if (dataTypes.contains(WebsiteDataType::DiskCache) && !isNonPersistentStore)
processAccessType = std::max(processAccessType, ProcessAccessType::Launch);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
