Title: [244398] trunk/Source/WebInspectorUI
- Revision
- 244398
- Author
- pecor...@apple.com
- Date
- 2019-04-17 12:59:24 -0700 (Wed, 17 Apr 2019)
Log Message
Web Inspector: Extension scripts with parse errors do not show up in Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=196996
<rdar://problem/47054804>
Reviewed by Devin Rousso.
* UserInterface/Controllers/DebuggerManager.js:
(WI.DebuggerManager.prototype.scriptDidFail):
Create a LocalScript that can be linked to but ignore it
if we already have a Resource for the URL.
* UserInterface/Protocol/DebuggerObserver.js:
(WI.DebuggerObserver.prototype.scriptFailedToParse):
Let DebuggerManager potentially create a script for this.
* UserInterface/Models/Script.js:
(WI.Script):
Local scripts provide a null id and id is not required below.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (244397 => 244398)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-04-17 19:54:26 UTC (rev 244397)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-04-17 19:59:24 UTC (rev 244398)
@@ -1,3 +1,24 @@
+2019-04-17 Joseph Pecoraro <pecor...@apple.com>
+
+ Web Inspector: Extension scripts with parse errors do not show up in Web Inspector
+ https://bugs.webkit.org/show_bug.cgi?id=196996
+ <rdar://problem/47054804>
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Controllers/DebuggerManager.js:
+ (WI.DebuggerManager.prototype.scriptDidFail):
+ Create a LocalScript that can be linked to but ignore it
+ if we already have a Resource for the URL.
+
+ * UserInterface/Protocol/DebuggerObserver.js:
+ (WI.DebuggerObserver.prototype.scriptFailedToParse):
+ Let DebuggerManager potentially create a script for this.
+
+ * UserInterface/Models/Script.js:
+ (WI.Script):
+ Local scripts provide a null id and id is not required below.
+
2019-04-16 Joseph Pecoraro <pecor...@apple.com>
Web Inspector: Worker imported scripts not showing up in Open Quickly dialog if inspector open after workers exist
Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js (244397 => 244398)
--- trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js 2019-04-17 19:54:26 UTC (rev 244397)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js 2019-04-17 19:59:24 UTC (rev 244398)
@@ -759,6 +759,23 @@
target.addScript(script);
}
+ scriptDidFail(target, url, scriptSource)
+ {
+ const sourceType = WI.Script.SourceType.Program;
+ let script = new WI.LocalScript(target, url, sourceType, scriptSource);
+
+ // If there is already a resource we don't need to have the script anymore,
+ // we only need a script to use for parser error location links.
+ if (script.resource)
+ return;
+
+ let targetData = this.dataForTarget(target);
+ targetData.addScript(script);
+ target.addScript(script);
+
+ this.dispatchEventToListeners(WI.DebuggerManager.Event.ScriptAdded, {script});
+ }
+
didSampleProbe(target, sample)
{
console.assert(this._probesByIdentifier.has(sample.probeId), "Unknown probe identifier specified for sample: ", sample);
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/Script.js (244397 => 244398)
--- trunk/Source/WebInspectorUI/UserInterface/Models/Script.js 2019-04-17 19:54:26 UTC (rev 244397)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/Script.js 2019-04-17 19:59:24 UTC (rev 244398)
@@ -29,7 +29,6 @@
{
super();
- console.assert(id);
console.assert(target instanceof WI.Target);
console.assert(range instanceof WI.TextRange);
Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/DebuggerObserver.js (244397 => 244398)
--- trunk/Source/WebInspectorUI/UserInterface/Protocol/DebuggerObserver.js 2019-04-17 19:54:26 UTC (rev 244397)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/DebuggerObserver.js 2019-04-17 19:59:24 UTC (rev 244398)
@@ -55,7 +55,8 @@
scriptFailedToParse(url, scriptSource, startLine, errorLine, errorMessage)
{
- // FIXME: Not implemented.
+ // NOTE: A Console.messageAdded event will handle the error message.
+ WI.debuggerManager.scriptDidFail(this.target, url, scriptSource);
}
breakpointResolved(breakpointId, location)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
