Title: [244462] trunk/LayoutTests
- Revision
- 244462
- Author
- rn...@webkit.org
- Date
- 2019-04-19 12:55:58 -0700 (Fri, 19 Apr 2019)
Log Message
[Mac WK2] REGRESSION (r244182) editing/execCommand/change-list-type.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=197065
<rdar://problem/50021964>
Reviewed by Wenson Hsieh.
Like r244461, this test was errornosuly assuming that rAF would be enough to close the undo group
in the UI process. Fixed the test by explicitly waiting for the runloop in the ui process to run
by executing a UI script.
* editing/execCommand/change-list-type.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (244461 => 244462)
--- trunk/LayoutTests/ChangeLog 2019-04-19 19:33:23 UTC (rev 244461)
+++ trunk/LayoutTests/ChangeLog 2019-04-19 19:55:58 UTC (rev 244462)
@@ -1,5 +1,19 @@
2019-04-19 Ryosuke Niwa <rn...@webkit.org>
+ [Mac WK2] REGRESSION (r244182) editing/execCommand/change-list-type.html is a flaky failure
+ https://bugs.webkit.org/show_bug.cgi?id=197065
+ <rdar://problem/50021964>
+
+ Reviewed by Wenson Hsieh.
+
+ Like r244461, this test was errornosuly assuming that rAF would be enough to close the undo group
+ in the UI process. Fixed the test by explicitly waiting for the runloop in the ui process to run
+ by executing a UI script.
+
+ * editing/execCommand/change-list-type.html:
+
+2019-04-19 Ryosuke Niwa <rn...@webkit.org>
+
REGRESSION: (r244182) Layout Test editing/execCommand/insert-nested-lists.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=196985
Modified: trunk/LayoutTests/editing/execCommand/change-list-type.html (244461 => 244462)
--- trunk/LayoutTests/editing/execCommand/change-list-type.html 2019-04-19 19:33:23 UTC (rev 244461)
+++ trunk/LayoutTests/editing/execCommand/change-list-type.html 2019-04-19 19:55:58 UTC (rev 244462)
@@ -69,6 +69,13 @@
internals.changeSelectionListType();
Markup.dump("top", "After changing the first sublist back to ordered");
+ await new Promise((resolve) => {
+ if (window.testRunner)
+ testRunner.runUIScript(`(function() { uiController.uiScriptComplete(); })()`, resolve);
+ else
+ setTimeout(resolve, 500);
+ });
+
await new Promise(requestAnimationFrame);
getSelection().setBaseAndExtent(five, 0, six, 1);
internals.changeSelectionListType();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
