Title: [244464] trunk/Source/WebKit
Revision
244464
Author
[email protected]
Date
2019-04-19 13:09:03 -0700 (Fri, 19 Apr 2019)

Log Message

Minor PSON release logging improvements
https://bugs.webkit.org/show_bug.cgi?id=197104

Reviewed by Darin Adler.

* UIProcess/SuspendedPageProxy.cpp:
(WebKit::SuspendedPageProxy::didProcessRequestToSuspend):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::continueNavigationInNewProcess):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (244463 => 244464)


--- trunk/Source/WebKit/ChangeLog	2019-04-19 20:03:48 UTC (rev 244463)
+++ trunk/Source/WebKit/ChangeLog	2019-04-19 20:09:03 UTC (rev 244464)
@@ -1,3 +1,15 @@
+2019-04-19  Chris Dumez  <[email protected]>
+
+        Minor PSON release logging improvements
+        https://bugs.webkit.org/show_bug.cgi?id=197104
+
+        Reviewed by Darin Adler.
+
+        * UIProcess/SuspendedPageProxy.cpp:
+        (WebKit::SuspendedPageProxy::didProcessRequestToSuspend):
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::continueNavigationInNewProcess):
+
 2019-04-19  Tim Horton  <[email protected]>
 
         YouTube and Twitter embeds don't load in News

Modified: trunk/Source/WebKit/UIProcess/SuspendedPageProxy.cpp (244463 => 244464)


--- trunk/Source/WebKit/UIProcess/SuspendedPageProxy.cpp	2019-04-19 20:03:48 UTC (rev 244463)
+++ trunk/Source/WebKit/UIProcess/SuspendedPageProxy.cpp	2019-04-19 20:09:03 UTC (rev 244464)
@@ -176,6 +176,7 @@
 void SuspendedPageProxy::didProcessRequestToSuspend(SuspensionState newSuspensionState)
 {
     LOG(ProcessSwapping, "SuspendedPageProxy %s from process %i finished transition to suspended", loggingString(), m_process->processIdentifier());
+    RELEASE_LOG(ProcessSwapping, "%p - SuspendedPageProxy::didProcessRequestToSuspend() success? %d", this, newSuspensionState == SuspensionState::Suspended);
 
     ASSERT(m_suspensionState == SuspensionState::Suspending);
     ASSERT(newSuspensionState == SuspensionState::Suspended || newSuspensionState == SuspensionState::FailedToSuspend);

Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (244463 => 244464)


--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp	2019-04-19 20:03:48 UTC (rev 244463)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp	2019-04-19 20:09:03 UTC (rev 244464)
@@ -2871,7 +2871,7 @@
 
 void WebPageProxy::continueNavigationInNewProcess(API::Navigation& navigation, std::unique_ptr<SuspendedPageProxy>&& suspendedPageProxy, Ref<WebProcessProxy>&& newProcess, ProcessSwapRequestedByClient processSwapRequestedByClient, Optional<WebsitePoliciesData>&& websitePolicies)
 {
-    RELEASE_LOG_IF_ALLOWED(Loading, "continueNavigationInNewProcess: webPID = %i, pageID = %" PRIu64, m_process->processIdentifier(), m_pageID);
+    RELEASE_LOG_IF_ALLOWED(Loading, "continueNavigationInNewProcess: webPID = %i, pageID = %" PRIu64 ", newProcessPID = %i, hasSuspendedPage = %i", m_process->processIdentifier(), m_pageID, newProcess->processIdentifier(), !!suspendedPageProxy);
     LOG(Loading, "Continuing navigation %" PRIu64 " '%s' in a new web process", navigation.navigationID(), navigation.loggingString());
 
     if (m_provisionalPage) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to