Title: [244547] trunk/Tools
- Revision
- 244547
- Author
- [email protected]
- Date
- 2019-04-23 10:51:55 -0700 (Tue, 23 Apr 2019)
Log Message
[ews-app] Exception while loading status-bubble when no build step has started
https://bugs.webkit.org/show_bug.cgi?id=196676
Reviewed by Lucas Forschler.
* BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
(StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py (244546 => 244547)
--- trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py 2019-04-23 17:10:10 UTC (rev 244546)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py 2019-04-23 17:51:55 UTC (rev 244547)
@@ -130,10 +130,15 @@
return ''
def get_build_timestamp(self, build):
- if not build.complete_at: # In-progress build
- return self._iso_time(build.step_set.last().started_at)
- return self._iso_time(build.complete_at)
+ if build.complete_at:
+ return self._iso_time(build.complete_at)
+ recent_build_step = build.step_set.last()
+ if recent_build_step:
+ return self._iso_time(recent_build_step.started_at)
+
+ return self._iso_time(build.started_at)
+
def _iso_time(self, time):
return '[[' + datetime.datetime.fromtimestamp(time).isoformat() + 'Z]]'
Modified: trunk/Tools/ChangeLog (244546 => 244547)
--- trunk/Tools/ChangeLog 2019-04-23 17:10:10 UTC (rev 244546)
+++ trunk/Tools/ChangeLog 2019-04-23 17:51:55 UTC (rev 244547)
@@ -1,3 +1,13 @@
+2019-04-23 Aakash Jain <[email protected]>
+
+ [ews-app] Exception while loading status-bubble when no build step has started
+ https://bugs.webkit.org/show_bug.cgi?id=196676
+
+ Reviewed by Lucas Forschler.
+
+ * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
+ (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
+
2019-04-23 Stephan Szabo <[email protected]>
[PlayStation] Support running of JSC tests on remote playstation devices
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
