Title: [244552] trunk/LayoutTests
Revision
244552
Author
[email protected]
Date
2019-04-23 11:06:29 -0700 (Tue, 23 Apr 2019)

Log Message

Unreviewed, speculative fix for failing inspector/canvas/ tests.
<rdar://problem/48248697>

Reviewed by NOBODY (OOPS!).

* inspector/canvas/resources/recording-utilities.js:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (244551 => 244552)


--- trunk/LayoutTests/ChangeLog	2019-04-23 18:02:55 UTC (rev 244551)
+++ trunk/LayoutTests/ChangeLog	2019-04-23 18:06:29 UTC (rev 244552)
@@ -1,3 +1,10 @@
+2019-04-23  Devin Rousso  <[email protected]>
+
+        Unreviewed, speculative fix for failing inspector/canvas/ tests.
+        <rdar://problem/48248697>
+
+        * inspector/canvas/resources/recording-utilities.js:
+
 2019-04-23  Ryosuke Niwa  <[email protected]>
 
         [iOS] element.focus() sometimes fails to reveal the focused element when it becomes editable dynamically

Modified: trunk/LayoutTests/inspector/canvas/resources/recording-utilities.js (244551 => 244552)


--- trunk/LayoutTests/inspector/canvas/resources/recording-utilities.js	2019-04-23 18:02:55 UTC (rev 244551)
+++ trunk/LayoutTests/inspector/canvas/resources/recording-utilities.js	2019-04-23 18:06:29 UTC (rev 244552)
@@ -100,7 +100,6 @@
             return;
         }
 
-        let stopped = false;
         let swizzled = false;
         let lastFrame = false;
 
@@ -108,7 +107,7 @@
         .then((event) => {
             lastFrame = true;
 
-            if (!stopped)
+            if (canvas.recordingActive)
                 CanvasAgent.stopRecording(canvas.identifier).catch(reject);
             else {
                 InspectorTest.evaluateInPage(`cancelActions()`)
@@ -131,8 +130,6 @@
         canvas.addEventListener(WI.Canvas.Event.RecordingProgress, handleRecordingProgress);
 
         canvas.awaitEvent(WI.Canvas.Event.RecordingStopped).then((event) => {
-            stopped = true;
-
             canvas.removeEventListener(WI.Canvas.Event.RecordingProgress, handleRecordingProgress);
 
             let recording = event.data.recording;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to