Diff
Modified: trunk/LayoutTests/ChangeLog (244580 => 244581)
--- trunk/LayoutTests/ChangeLog 2019-04-24 04:06:08 UTC (rev 244580)
+++ trunk/LayoutTests/ChangeLog 2019-04-24 04:16:30 UTC (rev 244581)
@@ -1,5 +1,28 @@
2019-04-23 John Wilander <[email protected]>
+ Move Ad Click Attribution from internal feature to experimental feature
+ https://bugs.webkit.org/show_bug.cgi?id=197218
+ <rdar://problem/47651691>
+
+ Reviewed by Brent Fulgham.
+
+ This patch removes the TestRunner instruction for turning on the internal
+ feature.
+
+ * http/tests/adClickAttribution/anchor-tag-attributes-validation.html:
+ * http/tests/adClickAttribution/attribution-conversion-through-image-redirect-without-priority.html:
+ * http/tests/adClickAttribution/conversion-disabled-in-ephemeral-session.html:
+ * http/tests/adClickAttribution/second-attribution-converted-with-higher-priority.html:
+ * http/tests/adClickAttribution/second-attribution-converted-with-lower-priority.html:
+ * http/tests/adClickAttribution/second-conversion-with-higher-priority.html:
+ * http/tests/adClickAttribution/second-conversion-with-lower-priority.html:
+ * http/tests/adClickAttribution/send-attribution-conversion-request.html:
+ * http/tests/adClickAttribution/store-ad-click-attribution.html:
+ * http/tests/adClickAttribution/store-disabled-in-ephemeral-session.html:
+ * http/tests/contentextensions/block-ad-click-attribution.html:
+
+2019-04-23 John Wilander <[email protected]>
+
Remove Ad Click Attribution data when removing website data
https://bugs.webkit.org/show_bug.cgi?id=197215
<rdar://problem/47668988>
Modified: trunk/LayoutTests/http/tests/adClickAttribution/anchor-tag-attributes-validation.html (244580 => 244581)
--- trunk/LayoutTests/http/tests/adClickAttribution/anchor-tag-attributes-validation.html 2019-04-24 04:06:08 UTC (rev 244580)
+++ trunk/LayoutTests/http/tests/adClickAttribution/anchor-tag-attributes-validation.html 2019-04-24 04:16:30 UTC (rev 244581)
@@ -1,4 +1,4 @@
-<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true, internal:AdClickAttributionEnabled=true ] -->
+<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
<html lang="en">
<head>
<meta charset="UTF-8">
Modified: trunk/LayoutTests/http/tests/adClickAttribution/attribution-conversion-through-image-redirect-without-priority.html (244580 => 244581)
--- trunk/LayoutTests/http/tests/adClickAttribution/attribution-conversion-through-image-redirect-without-priority.html 2019-04-24 04:06:08 UTC (rev 244580)
+++ trunk/LayoutTests/http/tests/adClickAttribution/attribution-conversion-through-image-redirect-without-priority.html 2019-04-24 04:16:30 UTC (rev 244581)
@@ -1,4 +1,4 @@
-<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true internal:AdClickAttributionEnabled=true ] -->
+<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
<html lang="en">
<head>
<meta charset="UTF-8">
Modified: trunk/LayoutTests/http/tests/adClickAttribution/conversion-disabled-in-ephemeral-session.html (244580 => 244581)
--- trunk/LayoutTests/http/tests/adClickAttribution/conversion-disabled-in-ephemeral-session.html 2019-04-24 04:06:08 UTC (rev 244580)
+++ trunk/LayoutTests/http/tests/adClickAttribution/conversion-disabled-in-ephemeral-session.html 2019-04-24 04:16:30 UTC (rev 244581)
@@ -1,4 +1,4 @@
-<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true internal:AdClickAttributionEnabled=true ] -->
+<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
<html lang="en">
<head>
<meta charset="UTF-8">
Modified: trunk/LayoutTests/http/tests/adClickAttribution/second-attribution-converted-with-higher-priority.html (244580 => 244581)
--- trunk/LayoutTests/http/tests/adClickAttribution/second-attribution-converted-with-higher-priority.html 2019-04-24 04:06:08 UTC (rev 244580)
+++ trunk/LayoutTests/http/tests/adClickAttribution/second-attribution-converted-with-higher-priority.html 2019-04-24 04:16:30 UTC (rev 244581)
@@ -1,4 +1,4 @@
-<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true internal:AdClickAttributionEnabled=true ] -->
+<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
<html lang="en">
<head>
<meta charset="UTF-8">
Modified: trunk/LayoutTests/http/tests/adClickAttribution/second-attribution-converted-with-lower-priority.html (244580 => 244581)
--- trunk/LayoutTests/http/tests/adClickAttribution/second-attribution-converted-with-lower-priority.html 2019-04-24 04:06:08 UTC (rev 244580)
+++ trunk/LayoutTests/http/tests/adClickAttribution/second-attribution-converted-with-lower-priority.html 2019-04-24 04:16:30 UTC (rev 244581)
@@ -1,4 +1,4 @@
-<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true internal:AdClickAttributionEnabled=true ] -->
+<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
<html lang="en">
<head>
<meta charset="UTF-8">
Modified: trunk/LayoutTests/http/tests/adClickAttribution/second-conversion-with-higher-priority.html (244580 => 244581)
--- trunk/LayoutTests/http/tests/adClickAttribution/second-conversion-with-higher-priority.html 2019-04-24 04:06:08 UTC (rev 244580)
+++ trunk/LayoutTests/http/tests/adClickAttribution/second-conversion-with-higher-priority.html 2019-04-24 04:16:30 UTC (rev 244581)
@@ -1,4 +1,4 @@
-<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true internal:AdClickAttributionEnabled=true ] -->
+<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
<html lang="en">
<head>
<meta charset="UTF-8">
Modified: trunk/LayoutTests/http/tests/adClickAttribution/second-conversion-with-lower-priority.html (244580 => 244581)
--- trunk/LayoutTests/http/tests/adClickAttribution/second-conversion-with-lower-priority.html 2019-04-24 04:06:08 UTC (rev 244580)
+++ trunk/LayoutTests/http/tests/adClickAttribution/second-conversion-with-lower-priority.html 2019-04-24 04:16:30 UTC (rev 244581)
@@ -1,4 +1,4 @@
-<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true internal:AdClickAttributionEnabled=true ] -->
+<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
<html lang="en">
<head>
<meta charset="UTF-8">
Modified: trunk/LayoutTests/http/tests/adClickAttribution/send-attribution-conversion-request.html (244580 => 244581)
--- trunk/LayoutTests/http/tests/adClickAttribution/send-attribution-conversion-request.html 2019-04-24 04:06:08 UTC (rev 244580)
+++ trunk/LayoutTests/http/tests/adClickAttribution/send-attribution-conversion-request.html 2019-04-24 04:16:30 UTC (rev 244581)
@@ -1,4 +1,4 @@
-<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true internal:AdClickAttributionEnabled=true ] -->
+<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
<html lang="en">
<head>
<meta charset="UTF-8">
Modified: trunk/LayoutTests/http/tests/adClickAttribution/store-ad-click-attribution.html (244580 => 244581)
--- trunk/LayoutTests/http/tests/adClickAttribution/store-ad-click-attribution.html 2019-04-24 04:06:08 UTC (rev 244580)
+++ trunk/LayoutTests/http/tests/adClickAttribution/store-ad-click-attribution.html 2019-04-24 04:16:30 UTC (rev 244581)
@@ -1,4 +1,4 @@
-<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true internal:AdClickAttributionEnabled=true ] -->
+<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
<html lang="en">
<head>
<meta charset="UTF-8">
Modified: trunk/LayoutTests/http/tests/adClickAttribution/store-disabled-in-ephemeral-session.html (244580 => 244581)
--- trunk/LayoutTests/http/tests/adClickAttribution/store-disabled-in-ephemeral-session.html 2019-04-24 04:06:08 UTC (rev 244580)
+++ trunk/LayoutTests/http/tests/adClickAttribution/store-disabled-in-ephemeral-session.html 2019-04-24 04:16:30 UTC (rev 244581)
@@ -1,4 +1,4 @@
-<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true internal:AdClickAttributionEnabled=true ] -->
+<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
<html lang="en">
<head>
<meta charset="UTF-8">
Modified: trunk/LayoutTests/http/tests/contentextensions/block-ad-click-attribution.html (244580 => 244581)
--- trunk/LayoutTests/http/tests/contentextensions/block-ad-click-attribution.html 2019-04-24 04:06:08 UTC (rev 244580)
+++ trunk/LayoutTests/http/tests/contentextensions/block-ad-click-attribution.html 2019-04-24 04:16:30 UTC (rev 244581)
@@ -1,4 +1,4 @@
-<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true internal:AdClickAttributionEnabled=true ] -->
+<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
<html lang="en">
<head>
<meta charset="UTF-8">
Modified: trunk/Source/WebKit/ChangeLog (244580 => 244581)
--- trunk/Source/WebKit/ChangeLog 2019-04-24 04:06:08 UTC (rev 244580)
+++ trunk/Source/WebKit/ChangeLog 2019-04-24 04:16:30 UTC (rev 244581)
@@ -1,3 +1,13 @@
+2019-04-23 John Wilander <[email protected]>
+
+ Move Ad Click Attribution from internal feature to experimental feature
+ https://bugs.webkit.org/show_bug.cgi?id=197218
+ <rdar://problem/47651691>
+
+ Reviewed by Brent Fulgham.
+
+ * Shared/WebPreferences.yaml:
+
2019-04-23 Keith Rollin <[email protected]>
Add Xcode version check for Header post-processing scripts
Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml (244580 => 244581)
--- trunk/Source/WebKit/Shared/WebPreferences.yaml 2019-04-24 04:06:08 UTC (rev 244580)
+++ trunk/Source/WebKit/Shared/WebPreferences.yaml 2019-04-24 04:16:30 UTC (rev 244581)
@@ -1404,6 +1404,14 @@
category: experimental
condition: ENABLE(RESIZE_OBSERVER)
+AdClickAttributionEnabled:
+ type: bool
+ defaultValue: false
+ humanReadableName: "Ad Click Attribution"
+ humanReadableDescription: "Enable Ad Click Attribution for Cross-Site Link Navigations"
+ webcoreBinding: RuntimeEnabledFeatures
+ category: experimental
+
# For internal features:
# The type should be boolean.
# You must provide a humanReadableName and humanReadableDescription for all debug features. They
@@ -1602,14 +1610,6 @@
webcoreBinding: RuntimeEnabledFeatures
category: internal
-AdClickAttributionEnabled:
- type: bool
- defaultValue: false
- humanReadableName: "Ad Click Attribution"
- humanReadableDescription: "Enable Ad Click Attribution for Cross-Site Link Navigations"
- webcoreBinding: RuntimeEnabledFeatures
- category: internal
-
DOMPasteAccessRequestsEnabled:
type: bool
defaultValue: DEFAULT_DOM_PASTE_ACCESS_REQUESTS_ENABLED
Modified: trunk/Tools/ChangeLog (244580 => 244581)
--- trunk/Tools/ChangeLog 2019-04-24 04:06:08 UTC (rev 244580)
+++ trunk/Tools/ChangeLog 2019-04-24 04:16:30 UTC (rev 244581)
@@ -1,3 +1,14 @@
+2019-04-23 John Wilander <[email protected]>
+
+ Move Ad Click Attribution from internal feature to experimental feature
+ https://bugs.webkit.org/show_bug.cgi?id=197218
+ <rdar://problem/47651691>
+
+ Reviewed by Brent Fulgham.
+
+ * DumpRenderTree/TestOptions.cpp:
+ (TestOptions::TestOptions):
+
2019-04-23 Andy Estes <[email protected]>
[iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
Modified: trunk/Tools/DumpRenderTree/TestOptions.cpp (244580 => 244581)
--- trunk/Tools/DumpRenderTree/TestOptions.cpp 2019-04-24 04:06:08 UTC (rev 244580)
+++ trunk/Tools/DumpRenderTree/TestOptions.cpp 2019-04-24 04:16:30 UTC (rev 244581)
@@ -109,7 +109,7 @@
enableWebGPU = parseBooleanTestHeaderValue(value);
else if (key == "internal:CSSLogicalEnabled")
enableCSSLogical = parseBooleanTestHeaderValue(value);
- else if (key == "internal:AdClickAttributionEnabled")
+ else if (key == "experimental:AdClickAttributionEnabled")
adClickAttributionEnabled = parseBooleanTestHeaderValue(value);
else if (key == "experimental:ResizeObserverEnabled")
enableResizeObserver = parseBooleanTestHeaderValue(value);
