Diff
Modified: branches/safari-607.2.6.0-branch/LayoutTests/ChangeLog (244636 => 244637)
--- branches/safari-607.2.6.0-branch/LayoutTests/ChangeLog 2019-04-25 06:42:23 UTC (rev 244636)
+++ branches/safari-607.2.6.0-branch/LayoutTests/ChangeLog 2019-04-25 06:42:33 UTC (rev 244637)
@@ -1,5 +1,157 @@
2019-04-24 Babak Shafiei <[email protected]>
+ Cherry-pick r244174. rdar://problem/28160396
+
+ Cherry-pick r243841. rdar://problem/49725678
+
+ -apple-trailing-word is needed for browser detection
+ https://bugs.webkit.org/show_bug.cgi?id=196575
+
+ Unreviewed.
+
+ PerformanceTests:
+
+ * MotionMark/resources/debug-runner/motionmark.css:
+ (#intro .start-benchmark p):
+
+ Source/_javascript_Core:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebCore:
+
+ This is an unreviewed partial revert of r243819. Turns out there are some websites
+ which use this property to do browser detection. So, we need to continue to parse
+ the property, but we don't need the property to do anything.
+
+ Test: fast/text/trailing-word-detection.html
+
+ * Configurations/FeatureDefines.xcconfig:
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
+ * css/CSSPrimitiveValueMappings.h:
+ (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+ (WebCore::CSSPrimitiveValue::operator TrailingWord const):
+ * css/CSSProperties.json:
+ * css/CSSValueKeywords.in:
+ * css/parser/CSSParserFastPaths.cpp:
+ (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
+ (WebCore::CSSParserFastPaths::isKeywordPropertyID):
+ * rendering/style/RenderStyle.h:
+ (WebCore::RenderStyle::trailingWord const):
+ (WebCore::RenderStyle::setTrailingWord):
+ (WebCore::RenderStyle::initialTrailingWord):
+ * rendering/style/RenderStyleConstants.h:
+
+ Source/WebCore/PAL:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebKit:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebKitLegacy/mac:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Tools:
+
+ * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
+
+ LayoutTests:
+
+ * fast/text/trailing-word-detection-expected.txt: Added.
+ * fast/text/trailing-word-detection.html: Added.
+ * platform/gtk/TestExpectations:
+ * platform/win/TestExpectations:
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-607-branch@244174 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2019-04-10 Alan Coon <[email protected]>
+
+ Cherry-pick r243841. rdar://problem/49725678
+
+ -apple-trailing-word is needed for browser detection
+ https://bugs.webkit.org/show_bug.cgi?id=196575
+
+ Unreviewed.
+
+ PerformanceTests:
+
+ * MotionMark/resources/debug-runner/motionmark.css:
+ (#intro .start-benchmark p):
+
+ Source/_javascript_Core:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebCore:
+
+ This is an unreviewed partial revert of r243819. Turns out there are some websites
+ which use this property to do browser detection. So, we need to continue to parse
+ the property, but we don't need the property to do anything.
+
+ Test: fast/text/trailing-word-detection.html
+
+ * Configurations/FeatureDefines.xcconfig:
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
+ * css/CSSPrimitiveValueMappings.h:
+ (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+ (WebCore::CSSPrimitiveValue::operator TrailingWord const):
+ * css/CSSProperties.json:
+ * css/CSSValueKeywords.in:
+ * css/parser/CSSParserFastPaths.cpp:
+ (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
+ (WebCore::CSSParserFastPaths::isKeywordPropertyID):
+ * rendering/style/RenderStyle.h:
+ (WebCore::RenderStyle::trailingWord const):
+ (WebCore::RenderStyle::setTrailingWord):
+ (WebCore::RenderStyle::initialTrailingWord):
+ * rendering/style/RenderStyleConstants.h:
+
+ Source/WebCore/PAL:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebKit:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebKitLegacy/mac:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Tools:
+
+ * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
+
+ LayoutTests:
+
+ * fast/text/trailing-word-detection-expected.txt: Added.
+ * fast/text/trailing-word-detection.html: Added.
+ * platform/gtk/TestExpectations:
+ * platform/win/TestExpectations:
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2019-04-03 Myles C. Maxfield <[email protected]>
+
+ -apple-trailing-word is needed for browser detection
+ https://bugs.webkit.org/show_bug.cgi?id=196575
+
+ Unreviewed.
+
+ * fast/text/trailing-word-detection-expected.txt: Added.
+ * fast/text/trailing-word-detection.html: Added.
+ * platform/gtk/TestExpectations:
+ * platform/win/TestExpectations:
+
+2019-04-24 Babak Shafiei <[email protected]>
+
Cherry-pick r244173. rdar://problem/28160396
Cherry-pick r243819. rdar://problem/49725678
Added: branches/safari-607.2.6.0-branch/LayoutTests/fast/text/trailing-word-detection-expected.txt (0 => 244637)
--- branches/safari-607.2.6.0-branch/LayoutTests/fast/text/trailing-word-detection-expected.txt (rev 0)
+++ branches/safari-607.2.6.0-branch/LayoutTests/fast/text/trailing-word-detection-expected.txt 2019-04-25 06:42:33 UTC (rev 244637)
@@ -0,0 +1,6 @@
+PASS '-apple-trailing-word' in element.style is true
+PASS window.getComputedStyle(element).getPropertyValue('color') is "rgb(0, 128, 0)"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: branches/safari-607.2.6.0-branch/LayoutTests/fast/text/trailing-word-detection.html (0 => 244637)
--- branches/safari-607.2.6.0-branch/LayoutTests/fast/text/trailing-word-detection.html (rev 0)
+++ branches/safari-607.2.6.0-branch/LayoutTests/fast/text/trailing-word-detection.html 2019-04-25 06:42:33 UTC (rev 244637)
@@ -0,0 +1,22 @@
+<!DOCTYPE html>
+<html>
+<head>
+<script src=""
+<style>
+@supports (-apple-trailing-word: auto) {
+ #test {
+ color: rgb(0, 128, 0);
+ }
+}
+</style>
+</head>
+<body>
+<div id="test"></div>
+<script>
+let element = document.getElementById("test");
+shouldBeTrue("'-apple-trailing-word' in element.style");
+shouldBeEqualToString("window.getComputedStyle(element).getPropertyValue('color')", "rgb(0, 128, 0)");
+</script>
+<script src=""
+</body>
+</html>
Modified: branches/safari-607.2.6.0-branch/LayoutTests/platform/gtk/TestExpectations (244636 => 244637)
--- branches/safari-607.2.6.0-branch/LayoutTests/platform/gtk/TestExpectations 2019-04-25 06:42:23 UTC (rev 244636)
+++ branches/safari-607.2.6.0-branch/LayoutTests/platform/gtk/TestExpectations 2019-04-25 06:42:33 UTC (rev 244637)
@@ -3158,6 +3158,7 @@
webkit.org/b/160248 fast/text/combining-mark-paint.html [ ImageOnlyFailure ]
webkit.org/b/160248 fast/text/synthetic-bold-transformed.html [ ImageOnlyFailure ]
+webkit.org/b/160248 fast/text/trailing-word-detection.html [ Failure ]
webkit.org/b/160249 fast/shrink-wrap/rect-shrink-wrap.html [ ImageOnlyFailure ]
Modified: branches/safari-607.2.6.0-branch/LayoutTests/platform/win/TestExpectations (244636 => 244637)
--- branches/safari-607.2.6.0-branch/LayoutTests/platform/win/TestExpectations 2019-04-25 06:42:23 UTC (rev 244636)
+++ branches/safari-607.2.6.0-branch/LayoutTests/platform/win/TestExpectations 2019-04-25 06:42:33 UTC (rev 244637)
@@ -3000,6 +3000,7 @@
fast/ruby/ruby-expansion-cjk-5.html [ ImageOnlyFailure ]
fast/text/combining-mark-paint.html [ ImageOnlyFailure ]
fast/text/synthetic-bold-transformed.html [ ImageOnlyFailure ]
+fast/text/trailing-word-detection.html [ Failure ]
# TestRunner::addChromeInputField() and focusWebView() not implemented
fast/forms/focus-option-control-on-page.html [ Skip ]
Modified: branches/safari-607.2.6.0-branch/PerformanceTests/ChangeLog (244636 => 244637)
--- branches/safari-607.2.6.0-branch/PerformanceTests/ChangeLog 2019-04-25 06:42:23 UTC (rev 244636)
+++ branches/safari-607.2.6.0-branch/PerformanceTests/ChangeLog 2019-04-25 06:42:33 UTC (rev 244637)
@@ -1,3 +1,153 @@
+2019-04-24 Babak Shafiei <[email protected]>
+
+ Cherry-pick r244174. rdar://problem/28160396
+
+ Cherry-pick r243841. rdar://problem/49725678
+
+ -apple-trailing-word is needed for browser detection
+ https://bugs.webkit.org/show_bug.cgi?id=196575
+
+ Unreviewed.
+
+ PerformanceTests:
+
+ * MotionMark/resources/debug-runner/motionmark.css:
+ (#intro .start-benchmark p):
+
+ Source/_javascript_Core:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebCore:
+
+ This is an unreviewed partial revert of r243819. Turns out there are some websites
+ which use this property to do browser detection. So, we need to continue to parse
+ the property, but we don't need the property to do anything.
+
+ Test: fast/text/trailing-word-detection.html
+
+ * Configurations/FeatureDefines.xcconfig:
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
+ * css/CSSPrimitiveValueMappings.h:
+ (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+ (WebCore::CSSPrimitiveValue::operator TrailingWord const):
+ * css/CSSProperties.json:
+ * css/CSSValueKeywords.in:
+ * css/parser/CSSParserFastPaths.cpp:
+ (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
+ (WebCore::CSSParserFastPaths::isKeywordPropertyID):
+ * rendering/style/RenderStyle.h:
+ (WebCore::RenderStyle::trailingWord const):
+ (WebCore::RenderStyle::setTrailingWord):
+ (WebCore::RenderStyle::initialTrailingWord):
+ * rendering/style/RenderStyleConstants.h:
+
+ Source/WebCore/PAL:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebKit:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebKitLegacy/mac:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Tools:
+
+ * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
+
+ LayoutTests:
+
+ * fast/text/trailing-word-detection-expected.txt: Added.
+ * fast/text/trailing-word-detection.html: Added.
+ * platform/gtk/TestExpectations:
+ * platform/win/TestExpectations:
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-607-branch@244174 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2019-04-10 Alan Coon <[email protected]>
+
+ Cherry-pick r243841. rdar://problem/49725678
+
+ -apple-trailing-word is needed for browser detection
+ https://bugs.webkit.org/show_bug.cgi?id=196575
+
+ Unreviewed.
+
+ PerformanceTests:
+
+ * MotionMark/resources/debug-runner/motionmark.css:
+ (#intro .start-benchmark p):
+
+ Source/_javascript_Core:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebCore:
+
+ This is an unreviewed partial revert of r243819. Turns out there are some websites
+ which use this property to do browser detection. So, we need to continue to parse
+ the property, but we don't need the property to do anything.
+
+ Test: fast/text/trailing-word-detection.html
+
+ * Configurations/FeatureDefines.xcconfig:
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
+ * css/CSSPrimitiveValueMappings.h:
+ (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+ (WebCore::CSSPrimitiveValue::operator TrailingWord const):
+ * css/CSSProperties.json:
+ * css/CSSValueKeywords.in:
+ * css/parser/CSSParserFastPaths.cpp:
+ (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
+ (WebCore::CSSParserFastPaths::isKeywordPropertyID):
+ * rendering/style/RenderStyle.h:
+ (WebCore::RenderStyle::trailingWord const):
+ (WebCore::RenderStyle::setTrailingWord):
+ (WebCore::RenderStyle::initialTrailingWord):
+ * rendering/style/RenderStyleConstants.h:
+
+ Source/WebCore/PAL:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebKit:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebKitLegacy/mac:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Tools:
+
+ * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
+
+ LayoutTests:
+
+ * fast/text/trailing-word-detection-expected.txt: Added.
+ * fast/text/trailing-word-detection.html: Added.
+ * platform/gtk/TestExpectations:
+ * platform/win/TestExpectations:
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2019-04-03 Myles C. Maxfield <[email protected]>
+
+ -apple-trailing-word is needed for browser detection
+ https://bugs.webkit.org/show_bug.cgi?id=196575
+
+ Unreviewed.
+
+ * MotionMark/resources/debug-runner/motionmark.css:
+ (#intro .start-benchmark p):
+
2019-04-24 Alan Coon <[email protected]>
Revert r244174. rdar://problem/28160396
Modified: branches/safari-607.2.6.0-branch/PerformanceTests/MotionMark/resources/debug-runner/motionmark.css (244636 => 244637)
--- branches/safari-607.2.6.0-branch/PerformanceTests/MotionMark/resources/debug-runner/motionmark.css 2019-04-25 06:42:23 UTC (rev 244636)
+++ branches/safari-607.2.6.0-branch/PerformanceTests/MotionMark/resources/debug-runner/motionmark.css 2019-04-25 06:42:33 UTC (rev 244637)
@@ -209,7 +209,6 @@
#intro .start-benchmark p {
color: hsl(11, 72%, 50%);
margin-bottom: 1em;
- -apple-trailing-word: -apple-partially-balanced;
}
#intro .start-benchmark button {
Modified: branches/safari-607.2.6.0-branch/Source/_javascript_Core/ChangeLog (244636 => 244637)
--- branches/safari-607.2.6.0-branch/Source/_javascript_Core/ChangeLog 2019-04-25 06:42:23 UTC (rev 244636)
+++ branches/safari-607.2.6.0-branch/Source/_javascript_Core/ChangeLog 2019-04-25 06:42:33 UTC (rev 244637)
@@ -1,5 +1,154 @@
2019-04-24 Babak Shafiei <[email protected]>
+ Cherry-pick r244174. rdar://problem/28160396
+
+ Cherry-pick r243841. rdar://problem/49725678
+
+ -apple-trailing-word is needed for browser detection
+ https://bugs.webkit.org/show_bug.cgi?id=196575
+
+ Unreviewed.
+
+ PerformanceTests:
+
+ * MotionMark/resources/debug-runner/motionmark.css:
+ (#intro .start-benchmark p):
+
+ Source/_javascript_Core:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebCore:
+
+ This is an unreviewed partial revert of r243819. Turns out there are some websites
+ which use this property to do browser detection. So, we need to continue to parse
+ the property, but we don't need the property to do anything.
+
+ Test: fast/text/trailing-word-detection.html
+
+ * Configurations/FeatureDefines.xcconfig:
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
+ * css/CSSPrimitiveValueMappings.h:
+ (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+ (WebCore::CSSPrimitiveValue::operator TrailingWord const):
+ * css/CSSProperties.json:
+ * css/CSSValueKeywords.in:
+ * css/parser/CSSParserFastPaths.cpp:
+ (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
+ (WebCore::CSSParserFastPaths::isKeywordPropertyID):
+ * rendering/style/RenderStyle.h:
+ (WebCore::RenderStyle::trailingWord const):
+ (WebCore::RenderStyle::setTrailingWord):
+ (WebCore::RenderStyle::initialTrailingWord):
+ * rendering/style/RenderStyleConstants.h:
+
+ Source/WebCore/PAL:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebKit:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebKitLegacy/mac:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Tools:
+
+ * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
+
+ LayoutTests:
+
+ * fast/text/trailing-word-detection-expected.txt: Added.
+ * fast/text/trailing-word-detection.html: Added.
+ * platform/gtk/TestExpectations:
+ * platform/win/TestExpectations:
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-607-branch@244174 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2019-04-10 Alan Coon <[email protected]>
+
+ Cherry-pick r243841. rdar://problem/49725678
+
+ -apple-trailing-word is needed for browser detection
+ https://bugs.webkit.org/show_bug.cgi?id=196575
+
+ Unreviewed.
+
+ PerformanceTests:
+
+ * MotionMark/resources/debug-runner/motionmark.css:
+ (#intro .start-benchmark p):
+
+ Source/_javascript_Core:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebCore:
+
+ This is an unreviewed partial revert of r243819. Turns out there are some websites
+ which use this property to do browser detection. So, we need to continue to parse
+ the property, but we don't need the property to do anything.
+
+ Test: fast/text/trailing-word-detection.html
+
+ * Configurations/FeatureDefines.xcconfig:
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
+ * css/CSSPrimitiveValueMappings.h:
+ (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+ (WebCore::CSSPrimitiveValue::operator TrailingWord const):
+ * css/CSSProperties.json:
+ * css/CSSValueKeywords.in:
+ * css/parser/CSSParserFastPaths.cpp:
+ (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
+ (WebCore::CSSParserFastPaths::isKeywordPropertyID):
+ * rendering/style/RenderStyle.h:
+ (WebCore::RenderStyle::trailingWord const):
+ (WebCore::RenderStyle::setTrailingWord):
+ (WebCore::RenderStyle::initialTrailingWord):
+ * rendering/style/RenderStyleConstants.h:
+
+ Source/WebCore/PAL:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebKit:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebKitLegacy/mac:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Tools:
+
+ * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
+
+ LayoutTests:
+
+ * fast/text/trailing-word-detection-expected.txt: Added.
+ * fast/text/trailing-word-detection.html: Added.
+ * platform/gtk/TestExpectations:
+ * platform/win/TestExpectations:
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2019-04-03 Myles C. Maxfield <[email protected]>
+
+ -apple-trailing-word is needed for browser detection
+ https://bugs.webkit.org/show_bug.cgi?id=196575
+
+ Unreviewed.
+
+ * Configurations/FeatureDefines.xcconfig:
+
+2019-04-24 Babak Shafiei <[email protected]>
+
Cherry-pick r244173. rdar://problem/28160396
Cherry-pick r243819. rdar://problem/49725678
Modified: branches/safari-607.2.6.0-branch/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (244636 => 244637)
--- branches/safari-607.2.6.0-branch/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2019-04-25 06:42:23 UTC (rev 244636)
+++ branches/safari-607.2.6.0-branch/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2019-04-25 06:42:33 UTC (rev 244637)
@@ -92,6 +92,8 @@
ENABLE_CSS_SELECTORS_LEVEL4 = ENABLE_CSS_SELECTORS_LEVEL4;
+ENABLE_CSS_TRAILING_WORD = ENABLE_CSS_TRAILING_WORD;
+
ENABLE_CSS_TYPED_OM = ENABLE_CSS_TYPED_OM;
ENABLE_CSS_CONIC_GRADIENTS = ENABLE_CSS_CONIC_GRADIENTS;
@@ -400,4 +402,4 @@
ENABLE_XSLT = ENABLE_XSLT;
-FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCELERATED_OVERFLOW_SCROLLING) $(ENABLE_APPLE_PAY) $(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_APPLE_PAY_SESSION_V4) $(ENABLE_APPLICATION_MANIFEST) $(ENABLE_ATTACHMENT_ELEMENT) $(ENABLE_AVF_CAPTIONS) $(ENABLE_C_LOOP) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CONTENT_FILTERING) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_IMAGE_ORIENTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_PAINTING_API) $(ENABLE_CSS_SCROLL_SNAP) $(ENABLE_CSS_SELECTORS_LEVEL4) $(ENABLE_CSS_TYPED_OM) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_CSS_CONIC_GRADIENTS) $(ENABLE_DARK_MODE_CSS) $(ENABLE_DASHBOARD_SUPPORT) $(ENABLE_DATA_INTERACTION) $(ENABLE_DATACUE_VALUE) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DRAG_SUPPORT) $(ENABLE_ENCRYPTED_MEDIA) $(ENABLE_EXPERIMENTAL_
FEATURES) $(ENABLE_FAST_JIT_PERMISSIONS) $(ENABLE_FILTERS_LEVEL_2) $(ENABLE_FTL_JIT) $(ENABLE_FULLSCREEN_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDEXED_DATABASE_IN_WORKERS) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_INTERSECTION_OBSERVER) $(ENABLE_INTL) $(ENABLE_IOS_GESTURE_EVENTS) $(ENABLE_IOS_TOUCH_EVENTS) $(ENABLE_JIT) $(ENABLE_KEYBOARD_CODE_ATTRIBUTE) $(ENABLE_KEYBOARD_KEY_ATTRIBUTE) $(ENABLE_LAYOUT_FORMATTING_CONTEXT) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER) $(ENABLE_LEGACY_ENCRYPTED_MEDIA) $(ENABLE_LETTERPRESS) $(ENABLE_MAC_GESTURE_EVENTS) $(ENABLE_MAC_VIDEO_TOOLBOX) $(ENABLE_MATHML) $(ENABLE_MEDIA_CAPTURE) $(ENABLE_MEDIA_CONTROLS_SCRIPT) $(ENABLE_MEDIA_SESSION) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATIS
TICS) $(ENABLE_MEDIA_STREAM) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_CONTENT_UTILS) $(ENABLE_NAVIGATOR_STANDALONE) $(ENABLE_NOTIFICATIONS) $(ENABLE_PAYMENT_REQUEST) $(ENABLE_PDFKIT_PLUGIN) $(ENABLE_POINTER_LOCK) $(ENABLE_PUBLIC_SUFFIX_LIST) $(ENABLE_QUOTA) $(ENABLE_REMOTE_INSPECTOR) $(ENABLE_RESOLUTION_MEDIA_QUERY) $(ENABLE_RESOURCE_LOAD_STATISTICS) $(ENABLE_RESOURCE_USAGE) $(ENABLE_RUBBER_BANDING) $(ENABLE_SERVICE_CONTROLS) $(ENABLE_SERVICE_WORKER) $(ENABLE_SPEECH_SYNTHESIS) $(ENABLE_STREAMS_API) $(ENABLE_WEB_CRYPTO) $(ENABLE_SVG_FONTS) $(ENABLE_TELEPHONE_NUMBER_DETECTION) $(ENABLE_TEXT_AUTOSIZING) $(ENABLE_TOUCH_EVENTS) $(ENABLE_USER_MESSAGE_HANDLERS) $(ENABLE_USERSELECT_ALL) $(ENABLE_VARIATION_FONTS) $(ENABLE_VIDEO) $(ENABLE_VIDEO_PRESENTATION_MODE) $(ENABLE_VIDEO_TRACK) $(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) $(ENABLE_WEB_API_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_AUTHN) $(ENABLE_WEB_RTC) $(ENABLE_WEBASSEMBLY) $(ENABLE_WEBASS
EMBLY_STREAMING_API) $(ENABLE_WEBGL) $(ENABLE_WEBGL2) $(ENABLE_WEBGPU) $(ENABLE_WEBMETAL) $(ENABLE_WIRELESS_PLAYBACK_TARGET) $(ENABLE_XSLT);
+FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCELERATED_OVERFLOW_SCROLLING) $(ENABLE_APPLE_PAY) $(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_APPLE_PAY_SESSION_V4) $(ENABLE_APPLICATION_MANIFEST) $(ENABLE_ATTACHMENT_ELEMENT) $(ENABLE_AVF_CAPTIONS) $(ENABLE_C_LOOP) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CONTENT_FILTERING) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_IMAGE_ORIENTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_PAINTING_API) $(ENABLE_CSS_SCROLL_SNAP) $(ENABLE_CSS_SELECTORS_LEVEL4) $(ENABLE_CSS_TRAILING_WORD) $(ENABLE_CSS_TYPED_OM) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_CSS_CONIC_GRADIENTS) $(ENABLE_DARK_MODE_CSS) $(ENABLE_DASHBOARD_SUPPORT) $(ENABLE_DATA_INTERACTION) $(ENABLE_DATACUE_VALUE) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DRAG_SUPPORT) $(ENABLE_ENCRYPTED_ME
DIA) $(ENABLE_EXPERIMENTAL_FEATURES) $(ENABLE_FAST_JIT_PERMISSIONS) $(ENABLE_FILTERS_LEVEL_2) $(ENABLE_FTL_JIT) $(ENABLE_FULLSCREEN_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDEXED_DATABASE_IN_WORKERS) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_INTERSECTION_OBSERVER) $(ENABLE_INTL) $(ENABLE_IOS_GESTURE_EVENTS) $(ENABLE_IOS_TOUCH_EVENTS) $(ENABLE_JIT) $(ENABLE_KEYBOARD_CODE_ATTRIBUTE) $(ENABLE_KEYBOARD_KEY_ATTRIBUTE) $(ENABLE_LAYOUT_FORMATTING_CONTEXT) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER) $(ENABLE_LEGACY_ENCRYPTED_MEDIA) $(ENABLE_LETTERPRESS) $(ENABLE_MAC_GESTURE_EVENTS) $(ENABLE_MAC_VIDEO_TOOLBOX) $(ENABLE_MATHML) $(ENABLE_MEDIA_CAPTURE) $(ENABLE_MEDIA_CONTROLS_SCRIPT) $(ENABLE_MEDIA_SESSION) $(ENABLE_MEDIA_SO
URCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_MEDIA_STREAM) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_CONTENT_UTILS) $(ENABLE_NAVIGATOR_STANDALONE) $(ENABLE_NOTIFICATIONS) $(ENABLE_PAYMENT_REQUEST) $(ENABLE_PDFKIT_PLUGIN) $(ENABLE_POINTER_LOCK) $(ENABLE_PUBLIC_SUFFIX_LIST) $(ENABLE_QUOTA) $(ENABLE_REMOTE_INSPECTOR) $(ENABLE_RESOLUTION_MEDIA_QUERY) $(ENABLE_RESOURCE_LOAD_STATISTICS) $(ENABLE_RESOURCE_USAGE) $(ENABLE_RUBBER_BANDING) $(ENABLE_SERVICE_CONTROLS) $(ENABLE_SERVICE_WORKER) $(ENABLE_SPEECH_SYNTHESIS) $(ENABLE_STREAMS_API) $(ENABLE_WEB_CRYPTO) $(ENABLE_SVG_FONTS) $(ENABLE_TELEPHONE_NUMBER_DETECTION) $(ENABLE_TEXT_AUTOSIZING) $(ENABLE_TOUCH_EVENTS) $(ENABLE_USER_MESSAGE_HANDLERS) $(ENABLE_USERSELECT_ALL) $(ENABLE_VARIATION_FONTS) $(ENABLE_VIDEO) $(ENABLE_VIDEO_PRESENTATION_MODE) $(ENABLE_VIDEO_TRACK) $(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) $(ENABLE_WEB_API_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_AUTHN) $(ENABLE_WEB_RTC) $(ENABLE_W
EBASSEMBLY) $(ENABLE_WEBASSEMBLY_STREAMING_API) $(ENABLE_WEBGL) $(ENABLE_WEBGL2) $(ENABLE_WEBGPU) $(ENABLE_WEBMETAL) $(ENABLE_WIRELESS_PLAYBACK_TARGET) $(ENABLE_XSLT);
Modified: branches/safari-607.2.6.0-branch/Source/WebCore/ChangeLog (244636 => 244637)
--- branches/safari-607.2.6.0-branch/Source/WebCore/ChangeLog 2019-04-25 06:42:23 UTC (rev 244636)
+++ branches/safari-607.2.6.0-branch/Source/WebCore/ChangeLog 2019-04-25 06:42:33 UTC (rev 244637)
@@ -1,5 +1,175 @@
2019-04-24 Babak Shafiei <[email protected]>
+ Cherry-pick r244174. rdar://problem/28160396
+
+ Cherry-pick r243841. rdar://problem/49725678
+
+ -apple-trailing-word is needed for browser detection
+ https://bugs.webkit.org/show_bug.cgi?id=196575
+
+ Unreviewed.
+
+ PerformanceTests:
+
+ * MotionMark/resources/debug-runner/motionmark.css:
+ (#intro .start-benchmark p):
+
+ Source/_javascript_Core:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebCore:
+
+ This is an unreviewed partial revert of r243819. Turns out there are some websites
+ which use this property to do browser detection. So, we need to continue to parse
+ the property, but we don't need the property to do anything.
+
+ Test: fast/text/trailing-word-detection.html
+
+ * Configurations/FeatureDefines.xcconfig:
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
+ * css/CSSPrimitiveValueMappings.h:
+ (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+ (WebCore::CSSPrimitiveValue::operator TrailingWord const):
+ * css/CSSProperties.json:
+ * css/CSSValueKeywords.in:
+ * css/parser/CSSParserFastPaths.cpp:
+ (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
+ (WebCore::CSSParserFastPaths::isKeywordPropertyID):
+ * rendering/style/RenderStyle.h:
+ (WebCore::RenderStyle::trailingWord const):
+ (WebCore::RenderStyle::setTrailingWord):
+ (WebCore::RenderStyle::initialTrailingWord):
+ * rendering/style/RenderStyleConstants.h:
+
+ Source/WebCore/PAL:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebKit:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebKitLegacy/mac:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Tools:
+
+ * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
+
+ LayoutTests:
+
+ * fast/text/trailing-word-detection-expected.txt: Added.
+ * fast/text/trailing-word-detection.html: Added.
+ * platform/gtk/TestExpectations:
+ * platform/win/TestExpectations:
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-607-branch@244174 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2019-04-10 Alan Coon <[email protected]>
+
+ Cherry-pick r243841. rdar://problem/49725678
+
+ -apple-trailing-word is needed for browser detection
+ https://bugs.webkit.org/show_bug.cgi?id=196575
+
+ Unreviewed.
+
+ PerformanceTests:
+
+ * MotionMark/resources/debug-runner/motionmark.css:
+ (#intro .start-benchmark p):
+
+ Source/_javascript_Core:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebCore:
+
+ This is an unreviewed partial revert of r243819. Turns out there are some websites
+ which use this property to do browser detection. So, we need to continue to parse
+ the property, but we don't need the property to do anything.
+
+ Test: fast/text/trailing-word-detection.html
+
+ * Configurations/FeatureDefines.xcconfig:
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
+ * css/CSSPrimitiveValueMappings.h:
+ (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+ (WebCore::CSSPrimitiveValue::operator TrailingWord const):
+ * css/CSSProperties.json:
+ * css/CSSValueKeywords.in:
+ * css/parser/CSSParserFastPaths.cpp:
+ (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
+ (WebCore::CSSParserFastPaths::isKeywordPropertyID):
+ * rendering/style/RenderStyle.h:
+ (WebCore::RenderStyle::trailingWord const):
+ (WebCore::RenderStyle::setTrailingWord):
+ (WebCore::RenderStyle::initialTrailingWord):
+ * rendering/style/RenderStyleConstants.h:
+
+ Source/WebCore/PAL:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebKit:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebKitLegacy/mac:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Tools:
+
+ * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
+
+ LayoutTests:
+
+ * fast/text/trailing-word-detection-expected.txt: Added.
+ * fast/text/trailing-word-detection.html: Added.
+ * platform/gtk/TestExpectations:
+ * platform/win/TestExpectations:
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2019-04-03 Myles C. Maxfield <[email protected]>
+
+ -apple-trailing-word is needed for browser detection
+ https://bugs.webkit.org/show_bug.cgi?id=196575
+
+ Unreviewed.
+
+ This is an unreviewed partial revert of r243819. Turns out there are some websites
+ which use this property to do browser detection. So, we need to continue to parse
+ the property, but we don't need the property to do anything.
+
+ Test: fast/text/trailing-word-detection.html
+
+ * Configurations/FeatureDefines.xcconfig:
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
+ * css/CSSPrimitiveValueMappings.h:
+ (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+ (WebCore::CSSPrimitiveValue::operator TrailingWord const):
+ * css/CSSProperties.json:
+ * css/CSSValueKeywords.in:
+ * css/parser/CSSParserFastPaths.cpp:
+ (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
+ (WebCore::CSSParserFastPaths::isKeywordPropertyID):
+ * rendering/style/RenderStyle.h:
+ (WebCore::RenderStyle::trailingWord const):
+ (WebCore::RenderStyle::setTrailingWord):
+ (WebCore::RenderStyle::initialTrailingWord):
+ * rendering/style/RenderStyleConstants.h:
+
+2019-04-24 Babak Shafiei <[email protected]>
+
Cherry-pick r244173. rdar://problem/28160396
Cherry-pick r243819. rdar://problem/49725678
Modified: branches/safari-607.2.6.0-branch/Source/WebCore/Configurations/FeatureDefines.xcconfig (244636 => 244637)
--- branches/safari-607.2.6.0-branch/Source/WebCore/Configurations/FeatureDefines.xcconfig 2019-04-25 06:42:23 UTC (rev 244636)
+++ branches/safari-607.2.6.0-branch/Source/WebCore/Configurations/FeatureDefines.xcconfig 2019-04-25 06:42:33 UTC (rev 244637)
@@ -92,6 +92,8 @@
ENABLE_CSS_SELECTORS_LEVEL4 = ENABLE_CSS_SELECTORS_LEVEL4;
+ENABLE_CSS_TRAILING_WORD = ENABLE_CSS_TRAILING_WORD;
+
ENABLE_CSS_TYPED_OM = ENABLE_CSS_TYPED_OM;
ENABLE_CSS_CONIC_GRADIENTS = ENABLE_CSS_CONIC_GRADIENTS;
@@ -400,4 +402,4 @@
ENABLE_XSLT = ENABLE_XSLT;
-FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCELERATED_OVERFLOW_SCROLLING) $(ENABLE_APPLE_PAY) $(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_APPLE_PAY_SESSION_V4) $(ENABLE_APPLICATION_MANIFEST) $(ENABLE_ATTACHMENT_ELEMENT) $(ENABLE_AVF_CAPTIONS) $(ENABLE_C_LOOP) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CONTENT_FILTERING) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_IMAGE_ORIENTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_PAINTING_API) $(ENABLE_CSS_SCROLL_SNAP) $(ENABLE_CSS_SELECTORS_LEVEL4) $(ENABLE_CSS_TYPED_OM) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_CSS_CONIC_GRADIENTS) $(ENABLE_DARK_MODE_CSS) $(ENABLE_DASHBOARD_SUPPORT) $(ENABLE_DATA_INTERACTION) $(ENABLE_DATACUE_VALUE) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DRAG_SUPPORT) $(ENABLE_ENCRYPTED_MEDIA) $(ENABLE_EXPERIMENTAL_
FEATURES) $(ENABLE_FAST_JIT_PERMISSIONS) $(ENABLE_FILTERS_LEVEL_2) $(ENABLE_FTL_JIT) $(ENABLE_FULLSCREEN_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDEXED_DATABASE_IN_WORKERS) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_INTERSECTION_OBSERVER) $(ENABLE_INTL) $(ENABLE_IOS_GESTURE_EVENTS) $(ENABLE_IOS_TOUCH_EVENTS) $(ENABLE_JIT) $(ENABLE_KEYBOARD_CODE_ATTRIBUTE) $(ENABLE_KEYBOARD_KEY_ATTRIBUTE) $(ENABLE_LAYOUT_FORMATTING_CONTEXT) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER) $(ENABLE_LEGACY_ENCRYPTED_MEDIA) $(ENABLE_LETTERPRESS) $(ENABLE_MAC_GESTURE_EVENTS) $(ENABLE_MAC_VIDEO_TOOLBOX) $(ENABLE_MATHML) $(ENABLE_MEDIA_CAPTURE) $(ENABLE_MEDIA_CONTROLS_SCRIPT) $(ENABLE_MEDIA_SESSION) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATIS
TICS) $(ENABLE_MEDIA_STREAM) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_CONTENT_UTILS) $(ENABLE_NAVIGATOR_STANDALONE) $(ENABLE_NOTIFICATIONS) $(ENABLE_PAYMENT_REQUEST) $(ENABLE_PDFKIT_PLUGIN) $(ENABLE_POINTER_LOCK) $(ENABLE_PUBLIC_SUFFIX_LIST) $(ENABLE_QUOTA) $(ENABLE_REMOTE_INSPECTOR) $(ENABLE_RESOLUTION_MEDIA_QUERY) $(ENABLE_RESOURCE_LOAD_STATISTICS) $(ENABLE_RESOURCE_USAGE) $(ENABLE_RUBBER_BANDING) $(ENABLE_SERVICE_CONTROLS) $(ENABLE_SERVICE_WORKER) $(ENABLE_SPEECH_SYNTHESIS) $(ENABLE_STREAMS_API) $(ENABLE_WEB_CRYPTO) $(ENABLE_SVG_FONTS) $(ENABLE_TELEPHONE_NUMBER_DETECTION) $(ENABLE_TEXT_AUTOSIZING) $(ENABLE_TOUCH_EVENTS) $(ENABLE_USER_MESSAGE_HANDLERS) $(ENABLE_USERSELECT_ALL) $(ENABLE_VARIATION_FONTS) $(ENABLE_VIDEO) $(ENABLE_VIDEO_PRESENTATION_MODE) $(ENABLE_VIDEO_TRACK) $(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) $(ENABLE_WEB_API_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_AUTHN) $(ENABLE_WEB_RTC) $(ENABLE_WEBASSEMBLY) $(ENABLE_WEBASS
EMBLY_STREAMING_API) $(ENABLE_WEBGL) $(ENABLE_WEBGL2) $(ENABLE_WEBGPU) $(ENABLE_WEBMETAL) $(ENABLE_WIRELESS_PLAYBACK_TARGET) $(ENABLE_XSLT);
+FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCELERATED_OVERFLOW_SCROLLING) $(ENABLE_APPLE_PAY) $(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_APPLE_PAY_SESSION_V4) $(ENABLE_APPLICATION_MANIFEST) $(ENABLE_ATTACHMENT_ELEMENT) $(ENABLE_AVF_CAPTIONS) $(ENABLE_C_LOOP) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CONTENT_FILTERING) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_IMAGE_ORIENTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_PAINTING_API) $(ENABLE_CSS_SCROLL_SNAP) $(ENABLE_CSS_SELECTORS_LEVEL4) $(ENABLE_CSS_TRAILING_WORD) $(ENABLE_CSS_TYPED_OM) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_CSS_CONIC_GRADIENTS) $(ENABLE_DARK_MODE_CSS) $(ENABLE_DASHBOARD_SUPPORT) $(ENABLE_DATA_INTERACTION) $(ENABLE_DATACUE_VALUE) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DRAG_SUPPORT) $(ENABLE_ENCRYPTED_ME
DIA) $(ENABLE_EXPERIMENTAL_FEATURES) $(ENABLE_FAST_JIT_PERMISSIONS) $(ENABLE_FILTERS_LEVEL_2) $(ENABLE_FTL_JIT) $(ENABLE_FULLSCREEN_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDEXED_DATABASE_IN_WORKERS) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_INTERSECTION_OBSERVER) $(ENABLE_INTL) $(ENABLE_IOS_GESTURE_EVENTS) $(ENABLE_IOS_TOUCH_EVENTS) $(ENABLE_JIT) $(ENABLE_KEYBOARD_CODE_ATTRIBUTE) $(ENABLE_KEYBOARD_KEY_ATTRIBUTE) $(ENABLE_LAYOUT_FORMATTING_CONTEXT) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER) $(ENABLE_LEGACY_ENCRYPTED_MEDIA) $(ENABLE_LETTERPRESS) $(ENABLE_MAC_GESTURE_EVENTS) $(ENABLE_MAC_VIDEO_TOOLBOX) $(ENABLE_MATHML) $(ENABLE_MEDIA_CAPTURE) $(ENABLE_MEDIA_CONTROLS_SCRIPT) $(ENABLE_MEDIA_SESSION) $(ENABLE_MEDIA_SO
URCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_MEDIA_STREAM) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_CONTENT_UTILS) $(ENABLE_NAVIGATOR_STANDALONE) $(ENABLE_NOTIFICATIONS) $(ENABLE_PAYMENT_REQUEST) $(ENABLE_PDFKIT_PLUGIN) $(ENABLE_POINTER_LOCK) $(ENABLE_PUBLIC_SUFFIX_LIST) $(ENABLE_QUOTA) $(ENABLE_REMOTE_INSPECTOR) $(ENABLE_RESOLUTION_MEDIA_QUERY) $(ENABLE_RESOURCE_LOAD_STATISTICS) $(ENABLE_RESOURCE_USAGE) $(ENABLE_RUBBER_BANDING) $(ENABLE_SERVICE_CONTROLS) $(ENABLE_SERVICE_WORKER) $(ENABLE_SPEECH_SYNTHESIS) $(ENABLE_STREAMS_API) $(ENABLE_WEB_CRYPTO) $(ENABLE_SVG_FONTS) $(ENABLE_TELEPHONE_NUMBER_DETECTION) $(ENABLE_TEXT_AUTOSIZING) $(ENABLE_TOUCH_EVENTS) $(ENABLE_USER_MESSAGE_HANDLERS) $(ENABLE_USERSELECT_ALL) $(ENABLE_VARIATION_FONTS) $(ENABLE_VIDEO) $(ENABLE_VIDEO_PRESENTATION_MODE) $(ENABLE_VIDEO_TRACK) $(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) $(ENABLE_WEB_API_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_AUTHN) $(ENABLE_WEB_RTC) $(ENABLE_W
EBASSEMBLY) $(ENABLE_WEBASSEMBLY_STREAMING_API) $(ENABLE_WEBGL) $(ENABLE_WEBGL2) $(ENABLE_WEBGPU) $(ENABLE_WEBMETAL) $(ENABLE_WIRELESS_PLAYBACK_TARGET) $(ENABLE_XSLT);
Modified: branches/safari-607.2.6.0-branch/Source/WebCore/PAL/ChangeLog (244636 => 244637)
--- branches/safari-607.2.6.0-branch/Source/WebCore/PAL/ChangeLog 2019-04-25 06:42:23 UTC (rev 244636)
+++ branches/safari-607.2.6.0-branch/Source/WebCore/PAL/ChangeLog 2019-04-25 06:42:33 UTC (rev 244637)
@@ -1,5 +1,154 @@
2019-04-24 Babak Shafiei <[email protected]>
+ Cherry-pick r244174. rdar://problem/28160396
+
+ Cherry-pick r243841. rdar://problem/49725678
+
+ -apple-trailing-word is needed for browser detection
+ https://bugs.webkit.org/show_bug.cgi?id=196575
+
+ Unreviewed.
+
+ PerformanceTests:
+
+ * MotionMark/resources/debug-runner/motionmark.css:
+ (#intro .start-benchmark p):
+
+ Source/_javascript_Core:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebCore:
+
+ This is an unreviewed partial revert of r243819. Turns out there are some websites
+ which use this property to do browser detection. So, we need to continue to parse
+ the property, but we don't need the property to do anything.
+
+ Test: fast/text/trailing-word-detection.html
+
+ * Configurations/FeatureDefines.xcconfig:
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
+ * css/CSSPrimitiveValueMappings.h:
+ (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+ (WebCore::CSSPrimitiveValue::operator TrailingWord const):
+ * css/CSSProperties.json:
+ * css/CSSValueKeywords.in:
+ * css/parser/CSSParserFastPaths.cpp:
+ (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
+ (WebCore::CSSParserFastPaths::isKeywordPropertyID):
+ * rendering/style/RenderStyle.h:
+ (WebCore::RenderStyle::trailingWord const):
+ (WebCore::RenderStyle::setTrailingWord):
+ (WebCore::RenderStyle::initialTrailingWord):
+ * rendering/style/RenderStyleConstants.h:
+
+ Source/WebCore/PAL:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebKit:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebKitLegacy/mac:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Tools:
+
+ * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
+
+ LayoutTests:
+
+ * fast/text/trailing-word-detection-expected.txt: Added.
+ * fast/text/trailing-word-detection.html: Added.
+ * platform/gtk/TestExpectations:
+ * platform/win/TestExpectations:
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-607-branch@244174 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2019-04-10 Alan Coon <[email protected]>
+
+ Cherry-pick r243841. rdar://problem/49725678
+
+ -apple-trailing-word is needed for browser detection
+ https://bugs.webkit.org/show_bug.cgi?id=196575
+
+ Unreviewed.
+
+ PerformanceTests:
+
+ * MotionMark/resources/debug-runner/motionmark.css:
+ (#intro .start-benchmark p):
+
+ Source/_javascript_Core:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebCore:
+
+ This is an unreviewed partial revert of r243819. Turns out there are some websites
+ which use this property to do browser detection. So, we need to continue to parse
+ the property, but we don't need the property to do anything.
+
+ Test: fast/text/trailing-word-detection.html
+
+ * Configurations/FeatureDefines.xcconfig:
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
+ * css/CSSPrimitiveValueMappings.h:
+ (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+ (WebCore::CSSPrimitiveValue::operator TrailingWord const):
+ * css/CSSProperties.json:
+ * css/CSSValueKeywords.in:
+ * css/parser/CSSParserFastPaths.cpp:
+ (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
+ (WebCore::CSSParserFastPaths::isKeywordPropertyID):
+ * rendering/style/RenderStyle.h:
+ (WebCore::RenderStyle::trailingWord const):
+ (WebCore::RenderStyle::setTrailingWord):
+ (WebCore::RenderStyle::initialTrailingWord):
+ * rendering/style/RenderStyleConstants.h:
+
+ Source/WebCore/PAL:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebKit:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebKitLegacy/mac:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Tools:
+
+ * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
+
+ LayoutTests:
+
+ * fast/text/trailing-word-detection-expected.txt: Added.
+ * fast/text/trailing-word-detection.html: Added.
+ * platform/gtk/TestExpectations:
+ * platform/win/TestExpectations:
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2019-04-03 Myles C. Maxfield <[email protected]>
+
+ -apple-trailing-word is needed for browser detection
+ https://bugs.webkit.org/show_bug.cgi?id=196575
+
+ Unreviewed.
+
+ * Configurations/FeatureDefines.xcconfig:
+
+2019-04-24 Babak Shafiei <[email protected]>
+
Cherry-pick r244173. rdar://problem/28160396
Cherry-pick r243819. rdar://problem/49725678
Modified: branches/safari-607.2.6.0-branch/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig (244636 => 244637)
--- branches/safari-607.2.6.0-branch/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig 2019-04-25 06:42:23 UTC (rev 244636)
+++ branches/safari-607.2.6.0-branch/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig 2019-04-25 06:42:33 UTC (rev 244637)
@@ -92,6 +92,8 @@
ENABLE_CSS_SELECTORS_LEVEL4 = ENABLE_CSS_SELECTORS_LEVEL4;
+ENABLE_CSS_TRAILING_WORD = ENABLE_CSS_TRAILING_WORD;
+
ENABLE_CSS_TYPED_OM = ENABLE_CSS_TYPED_OM;
ENABLE_CSS_CONIC_GRADIENTS = ENABLE_CSS_CONIC_GRADIENTS;
@@ -400,4 +402,4 @@
ENABLE_XSLT = ENABLE_XSLT;
-FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCELERATED_OVERFLOW_SCROLLING) $(ENABLE_APPLE_PAY) $(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_APPLE_PAY_SESSION_V4) $(ENABLE_APPLICATION_MANIFEST) $(ENABLE_ATTACHMENT_ELEMENT) $(ENABLE_AVF_CAPTIONS) $(ENABLE_C_LOOP) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CONTENT_FILTERING) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_IMAGE_ORIENTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_PAINTING_API) $(ENABLE_CSS_SCROLL_SNAP) $(ENABLE_CSS_SELECTORS_LEVEL4) $(ENABLE_CSS_TYPED_OM) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_CSS_CONIC_GRADIENTS) $(ENABLE_DARK_MODE_CSS) $(ENABLE_DASHBOARD_SUPPORT) $(ENABLE_DATA_INTERACTION) $(ENABLE_DATACUE_VALUE) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DRAG_SUPPORT) $(ENABLE_ENCRYPTED_MEDIA) $(ENABLE_EXPERIMENTAL_
FEATURES) $(ENABLE_FAST_JIT_PERMISSIONS) $(ENABLE_FILTERS_LEVEL_2) $(ENABLE_FTL_JIT) $(ENABLE_FULLSCREEN_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDEXED_DATABASE_IN_WORKERS) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_INTERSECTION_OBSERVER) $(ENABLE_INTL) $(ENABLE_IOS_GESTURE_EVENTS) $(ENABLE_IOS_TOUCH_EVENTS) $(ENABLE_JIT) $(ENABLE_KEYBOARD_CODE_ATTRIBUTE) $(ENABLE_KEYBOARD_KEY_ATTRIBUTE) $(ENABLE_LAYOUT_FORMATTING_CONTEXT) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER) $(ENABLE_LEGACY_ENCRYPTED_MEDIA) $(ENABLE_LETTERPRESS) $(ENABLE_MAC_GESTURE_EVENTS) $(ENABLE_MAC_VIDEO_TOOLBOX) $(ENABLE_MATHML) $(ENABLE_MEDIA_CAPTURE) $(ENABLE_MEDIA_CONTROLS_SCRIPT) $(ENABLE_MEDIA_SESSION) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATIS
TICS) $(ENABLE_MEDIA_STREAM) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_CONTENT_UTILS) $(ENABLE_NAVIGATOR_STANDALONE) $(ENABLE_NOTIFICATIONS) $(ENABLE_PAYMENT_REQUEST) $(ENABLE_PDFKIT_PLUGIN) $(ENABLE_POINTER_LOCK) $(ENABLE_PUBLIC_SUFFIX_LIST) $(ENABLE_QUOTA) $(ENABLE_REMOTE_INSPECTOR) $(ENABLE_RESOLUTION_MEDIA_QUERY) $(ENABLE_RESOURCE_LOAD_STATISTICS) $(ENABLE_RESOURCE_USAGE) $(ENABLE_RUBBER_BANDING) $(ENABLE_SERVICE_CONTROLS) $(ENABLE_SERVICE_WORKER) $(ENABLE_SPEECH_SYNTHESIS) $(ENABLE_STREAMS_API) $(ENABLE_WEB_CRYPTO) $(ENABLE_SVG_FONTS) $(ENABLE_TELEPHONE_NUMBER_DETECTION) $(ENABLE_TEXT_AUTOSIZING) $(ENABLE_TOUCH_EVENTS) $(ENABLE_USER_MESSAGE_HANDLERS) $(ENABLE_USERSELECT_ALL) $(ENABLE_VARIATION_FONTS) $(ENABLE_VIDEO) $(ENABLE_VIDEO_PRESENTATION_MODE) $(ENABLE_VIDEO_TRACK) $(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) $(ENABLE_WEB_API_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_AUTHN) $(ENABLE_WEB_RTC) $(ENABLE_WEBASSEMBLY) $(ENABLE_WEBASS
EMBLY_STREAMING_API) $(ENABLE_WEBGL) $(ENABLE_WEBGL2) $(ENABLE_WEBGPU) $(ENABLE_WEBMETAL) $(ENABLE_WIRELESS_PLAYBACK_TARGET) $(ENABLE_XSLT);
+FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCELERATED_OVERFLOW_SCROLLING) $(ENABLE_APPLE_PAY) $(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_APPLE_PAY_SESSION_V4) $(ENABLE_APPLICATION_MANIFEST) $(ENABLE_ATTACHMENT_ELEMENT) $(ENABLE_AVF_CAPTIONS) $(ENABLE_C_LOOP) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CONTENT_FILTERING) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_IMAGE_ORIENTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_PAINTING_API) $(ENABLE_CSS_SCROLL_SNAP) $(ENABLE_CSS_SELECTORS_LEVEL4) $(ENABLE_CSS_TRAILING_WORD) $(ENABLE_CSS_TYPED_OM) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_CSS_CONIC_GRADIENTS) $(ENABLE_DARK_MODE_CSS) $(ENABLE_DASHBOARD_SUPPORT) $(ENABLE_DATA_INTERACTION) $(ENABLE_DATACUE_VALUE) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DRAG_SUPPORT) $(ENABLE_ENCRYPTED_ME
DIA) $(ENABLE_EXPERIMENTAL_FEATURES) $(ENABLE_FAST_JIT_PERMISSIONS) $(ENABLE_FILTERS_LEVEL_2) $(ENABLE_FTL_JIT) $(ENABLE_FULLSCREEN_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDEXED_DATABASE_IN_WORKERS) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_INTERSECTION_OBSERVER) $(ENABLE_INTL) $(ENABLE_IOS_GESTURE_EVENTS) $(ENABLE_IOS_TOUCH_EVENTS) $(ENABLE_JIT) $(ENABLE_KEYBOARD_CODE_ATTRIBUTE) $(ENABLE_KEYBOARD_KEY_ATTRIBUTE) $(ENABLE_LAYOUT_FORMATTING_CONTEXT) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER) $(ENABLE_LEGACY_ENCRYPTED_MEDIA) $(ENABLE_LETTERPRESS) $(ENABLE_MAC_GESTURE_EVENTS) $(ENABLE_MAC_VIDEO_TOOLBOX) $(ENABLE_MATHML) $(ENABLE_MEDIA_CAPTURE) $(ENABLE_MEDIA_CONTROLS_SCRIPT) $(ENABLE_MEDIA_SESSION) $(ENABLE_MEDIA_SO
URCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_MEDIA_STREAM) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_CONTENT_UTILS) $(ENABLE_NAVIGATOR_STANDALONE) $(ENABLE_NOTIFICATIONS) $(ENABLE_PAYMENT_REQUEST) $(ENABLE_PDFKIT_PLUGIN) $(ENABLE_POINTER_LOCK) $(ENABLE_PUBLIC_SUFFIX_LIST) $(ENABLE_QUOTA) $(ENABLE_REMOTE_INSPECTOR) $(ENABLE_RESOLUTION_MEDIA_QUERY) $(ENABLE_RESOURCE_LOAD_STATISTICS) $(ENABLE_RESOURCE_USAGE) $(ENABLE_RUBBER_BANDING) $(ENABLE_SERVICE_CONTROLS) $(ENABLE_SERVICE_WORKER) $(ENABLE_SPEECH_SYNTHESIS) $(ENABLE_STREAMS_API) $(ENABLE_WEB_CRYPTO) $(ENABLE_SVG_FONTS) $(ENABLE_TELEPHONE_NUMBER_DETECTION) $(ENABLE_TEXT_AUTOSIZING) $(ENABLE_TOUCH_EVENTS) $(ENABLE_USER_MESSAGE_HANDLERS) $(ENABLE_USERSELECT_ALL) $(ENABLE_VARIATION_FONTS) $(ENABLE_VIDEO) $(ENABLE_VIDEO_PRESENTATION_MODE) $(ENABLE_VIDEO_TRACK) $(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) $(ENABLE_WEB_API_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_AUTHN) $(ENABLE_WEB_RTC) $(ENABLE_W
EBASSEMBLY) $(ENABLE_WEBASSEMBLY_STREAMING_API) $(ENABLE_WEBGL) $(ENABLE_WEBGL2) $(ENABLE_WEBGPU) $(ENABLE_WEBMETAL) $(ENABLE_WIRELESS_PLAYBACK_TARGET) $(ENABLE_XSLT);
Modified: branches/safari-607.2.6.0-branch/Source/WebCore/css/CSSComputedStyleDeclaration.cpp (244636 => 244637)
--- branches/safari-607.2.6.0-branch/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2019-04-25 06:42:23 UTC (rev 244636)
+++ branches/safari-607.2.6.0-branch/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2019-04-25 06:42:33 UTC (rev 244637)
@@ -3959,6 +3959,11 @@
return valueForScrollSnapAlignment(style.scrollSnapAlign());
#endif
+#if ENABLE(CSS_TRAILING_WORD)
+ case CSSPropertyAppleTrailingWord:
+ return cssValuePool.createValue(style.trailingWord());
+#endif
+
#if ENABLE(APPLE_PAY)
case CSSPropertyApplePayButtonStyle:
return cssValuePool.createValue(style.applePayButtonStyle());
Modified: branches/safari-607.2.6.0-branch/Source/WebCore/css/CSSPrimitiveValueMappings.h (244636 => 244637)
--- branches/safari-607.2.6.0-branch/Source/WebCore/css/CSSPrimitiveValueMappings.h 2019-04-25 06:42:23 UTC (rev 244636)
+++ branches/safari-607.2.6.0-branch/Source/WebCore/css/CSSPrimitiveValueMappings.h 2019-04-25 06:42:33 UTC (rev 244637)
@@ -5384,6 +5384,40 @@
#endif
+#if ENABLE(CSS_TRAILING_WORD)
+template<> inline CSSPrimitiveValue::CSSPrimitiveValue(TrailingWord e)
+ : CSSValue(PrimitiveClass)
+{
+ m_primitiveUnitType = CSS_VALUE_ID;
+ switch (e) {
+ case TrailingWord::Auto:
+ m_value.valueID = CSSValueAuto;
+ break;
+ case TrailingWord::PartiallyBalanced:
+ m_value.valueID = CSSValueWebkitPartiallyBalanced;
+ break;
+ default:
+ ASSERT_NOT_REACHED();
+ break;
+ }
+}
+
+template<> inline CSSPrimitiveValue::operator TrailingWord() const
+{
+ ASSERT(isValueID());
+ switch (m_value.valueID) {
+ case CSSValueAuto:
+ return TrailingWord::Auto;
+ case CSSValueWebkitPartiallyBalanced:
+ return TrailingWord::PartiallyBalanced;
+ default:
+ break;
+ }
+ ASSERT_NOT_REACHED();
+ return TrailingWord::Auto;
+}
+#endif
+
#if ENABLE(APPLE_PAY)
template<> inline CSSPrimitiveValue::CSSPrimitiveValue(ApplePayButtonStyle e)
: CSSValue(PrimitiveClass)
Modified: branches/safari-607.2.6.0-branch/Source/WebCore/css/CSSProperties.json (244636 => 244637)
--- branches/safari-607.2.6.0-branch/Source/WebCore/css/CSSProperties.json 2019-04-25 06:42:23 UTC (rev 244636)
+++ branches/safari-607.2.6.0-branch/Source/WebCore/css/CSSProperties.json 2019-04-25 06:42:33 UTC (rev 244637)
@@ -6699,6 +6699,21 @@
},
"status": "non-standard"
},
+ "-apple-trailing-word": {
+ "inherited": true,
+ "values": [
+ "auto",
+ "-webkit-partially-balanced"
+ ],
+ "codegen-properties": {
+ "name-for-methods": "TrailingWord",
+ "enable-if": "ENABLE_CSS_TRAILING_WORD"
+ },
+ "status": {
+ "status": "non-standard",
+ "comment": "Needed for feature-detecting the Safari browser. Implementation has no effect."
+ }
+ },
"-apple-pay-button-style": {
"codegen-properties": {
"enable-if": "ENABLE_APPLE_PAY"
Modified: branches/safari-607.2.6.0-branch/Source/WebCore/css/CSSValueKeywords.in (244636 => 244637)
--- branches/safari-607.2.6.0-branch/Source/WebCore/css/CSSValueKeywords.in 2019-04-25 06:42:23 UTC (rev 244636)
+++ branches/safari-607.2.6.0-branch/Source/WebCore/css/CSSValueKeywords.in 2019-04-25 06:42:33 UTC (rev 244637)
@@ -1323,6 +1323,11 @@
from-dimensions
from-intrinsic
+#if defined(ENABLE_CSS_TRAILING_WORD) && ENABLE_CSS_TRAILING_WORD
+// -apple-trailing-word
+-webkit-partially-balanced
+#endif
+
#if defined(ENABLE_APPLE_PAY) && ENABLE_APPLE_PAY
// -apple-pay-button-style
white-outline
Modified: branches/safari-607.2.6.0-branch/Source/WebCore/css/parser/CSSParserFastPaths.cpp (244636 => 244637)
--- branches/safari-607.2.6.0-branch/Source/WebCore/css/parser/CSSParserFastPaths.cpp 2019-04-25 06:42:23 UTC (rev 244636)
+++ branches/safari-607.2.6.0-branch/Source/WebCore/css/parser/CSSParserFastPaths.cpp 2019-04-25 06:42:33 UTC (rev 244637)
@@ -762,6 +762,10 @@
case CSSPropertyTouchAction: // auto | manipulation
return valueID == CSSValueAuto || valueID == CSSValueManipulation;
#endif
+#if ENABLE(CSS_TRAILING_WORD)
+ case CSSPropertyAppleTrailingWord: // auto | -apple-partially-balanced
+ return valueID == CSSValueAuto || valueID == CSSValueWebkitPartiallyBalanced;
+#endif
#if ENABLE(APPLE_PAY)
case CSSPropertyApplePayButtonStyle: // white | white-outline | black
return valueID == CSSValueWhite || valueID == CSSValueWhiteOutline || valueID == CSSValueBlack;
@@ -930,6 +934,9 @@
// case CSSPropertyTextJustify:
// case CSSPropertyTextOrientation:
// case CSSPropertyUserSelect:
+#if ENABLE(CSS_TRAILING_WORD)
+ case CSSPropertyAppleTrailingWord:
+#endif
#if ENABLE(CSS_COMPOSITING)
case CSSPropertyIsolation:
case CSSPropertyMixBlendMode:
Modified: branches/safari-607.2.6.0-branch/Source/WebCore/rendering/style/RenderStyle.h (244636 => 244637)
--- branches/safari-607.2.6.0-branch/Source/WebCore/rendering/style/RenderStyle.h 2019-04-25 06:42:23 UTC (rev 244636)
+++ branches/safari-607.2.6.0-branch/Source/WebCore/rendering/style/RenderStyle.h 2019-04-25 06:42:33 UTC (rev 244637)
@@ -798,6 +798,10 @@
bool shouldPlaceBlockDirectionScrollbarOnLeft() const;
+#if ENABLE(CSS_TRAILING_WORD)
+ TrailingWord trailingWord() const { return TrailingWord::Auto; }
+#endif
+
#if ENABLE(APPLE_PAY)
ApplePayButtonStyle applePayButtonStyle() const { return static_cast<ApplePayButtonStyle>(m_rareNonInheritedData->applePayButtonStyle); }
ApplePayButtonType applePayButtonType() const { return static_cast<ApplePayButtonType>(m_rareNonInheritedData->applePayButtonType); }
@@ -1254,6 +1258,10 @@
void setTextSecurity(TextSecurity security) { SET_VAR(m_rareInheritedData, textSecurity, static_cast<unsigned>(security)); }
+#if ENABLE(CSS_TRAILING_WORD)
+ void setTrailingWord(TrailingWord) { }
+#endif
+
#if ENABLE(APPLE_PAY)
void setApplePayButtonStyle(ApplePayButtonStyle style) { SET_VAR(m_rareNonInheritedData, applePayButtonStyle, static_cast<unsigned>(style)); }
void setApplePayButtonType(ApplePayButtonType type) { SET_VAR(m_rareNonInheritedData, applePayButtonType, static_cast<unsigned>(type)); }
@@ -1621,6 +1629,10 @@
static Length initialScrollPadding() { return Length(Fixed); }
#endif
+#if ENABLE(CSS_TRAILING_WORD)
+ static TrailingWord initialTrailingWord() { return TrailingWord::Auto; }
+#endif
+
#if ENABLE(APPLE_PAY)
static ApplePayButtonStyle initialApplePayButtonStyle() { return ApplePayButtonStyle::Black; }
static ApplePayButtonType initialApplePayButtonType() { return ApplePayButtonType::Plain; }
Modified: branches/safari-607.2.6.0-branch/Source/WebCore/rendering/style/RenderStyleConstants.h (244636 => 244637)
--- branches/safari-607.2.6.0-branch/Source/WebCore/rendering/style/RenderStyleConstants.h 2019-04-25 06:42:23 UTC (rev 244636)
+++ branches/safari-607.2.6.0-branch/Source/WebCore/rendering/style/RenderStyleConstants.h 2019-04-25 06:42:33 UTC (rev 244637)
@@ -1115,6 +1115,13 @@
};
#endif
+#if ENABLE(CSS_TRAILING_WORD)
+enum class TrailingWord : uint8_t {
+ Auto,
+ PartiallyBalanced
+};
+#endif
+
#if ENABLE(APPLE_PAY)
enum class ApplePayButtonStyle : uint8_t {
White,
Modified: branches/safari-607.2.6.0-branch/Source/WebKit/ChangeLog (244636 => 244637)
--- branches/safari-607.2.6.0-branch/Source/WebKit/ChangeLog 2019-04-25 06:42:23 UTC (rev 244636)
+++ branches/safari-607.2.6.0-branch/Source/WebKit/ChangeLog 2019-04-25 06:42:33 UTC (rev 244637)
@@ -1,5 +1,154 @@
2019-04-24 Babak Shafiei <[email protected]>
+ Cherry-pick r244174. rdar://problem/28160396
+
+ Cherry-pick r243841. rdar://problem/49725678
+
+ -apple-trailing-word is needed for browser detection
+ https://bugs.webkit.org/show_bug.cgi?id=196575
+
+ Unreviewed.
+
+ PerformanceTests:
+
+ * MotionMark/resources/debug-runner/motionmark.css:
+ (#intro .start-benchmark p):
+
+ Source/_javascript_Core:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebCore:
+
+ This is an unreviewed partial revert of r243819. Turns out there are some websites
+ which use this property to do browser detection. So, we need to continue to parse
+ the property, but we don't need the property to do anything.
+
+ Test: fast/text/trailing-word-detection.html
+
+ * Configurations/FeatureDefines.xcconfig:
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
+ * css/CSSPrimitiveValueMappings.h:
+ (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+ (WebCore::CSSPrimitiveValue::operator TrailingWord const):
+ * css/CSSProperties.json:
+ * css/CSSValueKeywords.in:
+ * css/parser/CSSParserFastPaths.cpp:
+ (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
+ (WebCore::CSSParserFastPaths::isKeywordPropertyID):
+ * rendering/style/RenderStyle.h:
+ (WebCore::RenderStyle::trailingWord const):
+ (WebCore::RenderStyle::setTrailingWord):
+ (WebCore::RenderStyle::initialTrailingWord):
+ * rendering/style/RenderStyleConstants.h:
+
+ Source/WebCore/PAL:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebKit:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebKitLegacy/mac:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Tools:
+
+ * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
+
+ LayoutTests:
+
+ * fast/text/trailing-word-detection-expected.txt: Added.
+ * fast/text/trailing-word-detection.html: Added.
+ * platform/gtk/TestExpectations:
+ * platform/win/TestExpectations:
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-607-branch@244174 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2019-04-10 Alan Coon <[email protected]>
+
+ Cherry-pick r243841. rdar://problem/49725678
+
+ -apple-trailing-word is needed for browser detection
+ https://bugs.webkit.org/show_bug.cgi?id=196575
+
+ Unreviewed.
+
+ PerformanceTests:
+
+ * MotionMark/resources/debug-runner/motionmark.css:
+ (#intro .start-benchmark p):
+
+ Source/_javascript_Core:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebCore:
+
+ This is an unreviewed partial revert of r243819. Turns out there are some websites
+ which use this property to do browser detection. So, we need to continue to parse
+ the property, but we don't need the property to do anything.
+
+ Test: fast/text/trailing-word-detection.html
+
+ * Configurations/FeatureDefines.xcconfig:
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
+ * css/CSSPrimitiveValueMappings.h:
+ (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+ (WebCore::CSSPrimitiveValue::operator TrailingWord const):
+ * css/CSSProperties.json:
+ * css/CSSValueKeywords.in:
+ * css/parser/CSSParserFastPaths.cpp:
+ (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
+ (WebCore::CSSParserFastPaths::isKeywordPropertyID):
+ * rendering/style/RenderStyle.h:
+ (WebCore::RenderStyle::trailingWord const):
+ (WebCore::RenderStyle::setTrailingWord):
+ (WebCore::RenderStyle::initialTrailingWord):
+ * rendering/style/RenderStyleConstants.h:
+
+ Source/WebCore/PAL:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebKit:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebKitLegacy/mac:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Tools:
+
+ * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
+
+ LayoutTests:
+
+ * fast/text/trailing-word-detection-expected.txt: Added.
+ * fast/text/trailing-word-detection.html: Added.
+ * platform/gtk/TestExpectations:
+ * platform/win/TestExpectations:
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2019-04-03 Myles C. Maxfield <[email protected]>
+
+ -apple-trailing-word is needed for browser detection
+ https://bugs.webkit.org/show_bug.cgi?id=196575
+
+ Unreviewed.
+
+ * Configurations/FeatureDefines.xcconfig:
+
+2019-04-24 Babak Shafiei <[email protected]>
+
Cherry-pick r244173. rdar://problem/28160396
Cherry-pick r243819. rdar://problem/49725678
Modified: branches/safari-607.2.6.0-branch/Source/WebKit/Configurations/FeatureDefines.xcconfig (244636 => 244637)
--- branches/safari-607.2.6.0-branch/Source/WebKit/Configurations/FeatureDefines.xcconfig 2019-04-25 06:42:23 UTC (rev 244636)
+++ branches/safari-607.2.6.0-branch/Source/WebKit/Configurations/FeatureDefines.xcconfig 2019-04-25 06:42:33 UTC (rev 244637)
@@ -92,6 +92,8 @@
ENABLE_CSS_SELECTORS_LEVEL4 = ENABLE_CSS_SELECTORS_LEVEL4;
+ENABLE_CSS_TRAILING_WORD = ENABLE_CSS_TRAILING_WORD;
+
ENABLE_CSS_TYPED_OM = ENABLE_CSS_TYPED_OM;
ENABLE_CSS_CONIC_GRADIENTS = ENABLE_CSS_CONIC_GRADIENTS;
@@ -400,4 +402,4 @@
ENABLE_XSLT = ENABLE_XSLT;
-FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCELERATED_OVERFLOW_SCROLLING) $(ENABLE_APPLE_PAY) $(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_APPLE_PAY_SESSION_V4) $(ENABLE_APPLICATION_MANIFEST) $(ENABLE_ATTACHMENT_ELEMENT) $(ENABLE_AVF_CAPTIONS) $(ENABLE_C_LOOP) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CONTENT_FILTERING) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_IMAGE_ORIENTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_PAINTING_API) $(ENABLE_CSS_SCROLL_SNAP) $(ENABLE_CSS_SELECTORS_LEVEL4) $(ENABLE_CSS_TYPED_OM) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_CSS_CONIC_GRADIENTS) $(ENABLE_DARK_MODE_CSS) $(ENABLE_DASHBOARD_SUPPORT) $(ENABLE_DATA_INTERACTION) $(ENABLE_DATACUE_VALUE) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DRAG_SUPPORT) $(ENABLE_ENCRYPTED_MEDIA) $(ENABLE_EXPERIMENTAL_
FEATURES) $(ENABLE_FAST_JIT_PERMISSIONS) $(ENABLE_FILTERS_LEVEL_2) $(ENABLE_FTL_JIT) $(ENABLE_FULLSCREEN_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDEXED_DATABASE_IN_WORKERS) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_INTERSECTION_OBSERVER) $(ENABLE_INTL) $(ENABLE_IOS_GESTURE_EVENTS) $(ENABLE_IOS_TOUCH_EVENTS) $(ENABLE_JIT) $(ENABLE_KEYBOARD_CODE_ATTRIBUTE) $(ENABLE_KEYBOARD_KEY_ATTRIBUTE) $(ENABLE_LAYOUT_FORMATTING_CONTEXT) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER) $(ENABLE_LEGACY_ENCRYPTED_MEDIA) $(ENABLE_LETTERPRESS) $(ENABLE_MAC_GESTURE_EVENTS) $(ENABLE_MAC_VIDEO_TOOLBOX) $(ENABLE_MATHML) $(ENABLE_MEDIA_CAPTURE) $(ENABLE_MEDIA_CONTROLS_SCRIPT) $(ENABLE_MEDIA_SESSION) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATIS
TICS) $(ENABLE_MEDIA_STREAM) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_CONTENT_UTILS) $(ENABLE_NAVIGATOR_STANDALONE) $(ENABLE_NOTIFICATIONS) $(ENABLE_PAYMENT_REQUEST) $(ENABLE_PDFKIT_PLUGIN) $(ENABLE_POINTER_LOCK) $(ENABLE_PUBLIC_SUFFIX_LIST) $(ENABLE_QUOTA) $(ENABLE_REMOTE_INSPECTOR) $(ENABLE_RESOLUTION_MEDIA_QUERY) $(ENABLE_RESOURCE_LOAD_STATISTICS) $(ENABLE_RESOURCE_USAGE) $(ENABLE_RUBBER_BANDING) $(ENABLE_SERVICE_CONTROLS) $(ENABLE_SERVICE_WORKER) $(ENABLE_SPEECH_SYNTHESIS) $(ENABLE_STREAMS_API) $(ENABLE_WEB_CRYPTO) $(ENABLE_SVG_FONTS) $(ENABLE_TELEPHONE_NUMBER_DETECTION) $(ENABLE_TEXT_AUTOSIZING) $(ENABLE_TOUCH_EVENTS) $(ENABLE_USER_MESSAGE_HANDLERS) $(ENABLE_USERSELECT_ALL) $(ENABLE_VARIATION_FONTS) $(ENABLE_VIDEO) $(ENABLE_VIDEO_PRESENTATION_MODE) $(ENABLE_VIDEO_TRACK) $(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) $(ENABLE_WEB_API_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_AUTHN) $(ENABLE_WEB_RTC) $(ENABLE_WEBASSEMBLY) $(ENABLE_WEBASS
EMBLY_STREAMING_API) $(ENABLE_WEBGL) $(ENABLE_WEBGL2) $(ENABLE_WEBGPU) $(ENABLE_WEBMETAL) $(ENABLE_WIRELESS_PLAYBACK_TARGET) $(ENABLE_XSLT);
+FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCELERATED_OVERFLOW_SCROLLING) $(ENABLE_APPLE_PAY) $(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_APPLE_PAY_SESSION_V4) $(ENABLE_APPLICATION_MANIFEST) $(ENABLE_ATTACHMENT_ELEMENT) $(ENABLE_AVF_CAPTIONS) $(ENABLE_C_LOOP) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CONTENT_FILTERING) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_IMAGE_ORIENTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_PAINTING_API) $(ENABLE_CSS_SCROLL_SNAP) $(ENABLE_CSS_SELECTORS_LEVEL4) $(ENABLE_CSS_TRAILING_WORD) $(ENABLE_CSS_TYPED_OM) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_CSS_CONIC_GRADIENTS) $(ENABLE_DARK_MODE_CSS) $(ENABLE_DASHBOARD_SUPPORT) $(ENABLE_DATA_INTERACTION) $(ENABLE_DATACUE_VALUE) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DRAG_SUPPORT) $(ENABLE_ENCRYPTED_ME
DIA) $(ENABLE_EXPERIMENTAL_FEATURES) $(ENABLE_FAST_JIT_PERMISSIONS) $(ENABLE_FILTERS_LEVEL_2) $(ENABLE_FTL_JIT) $(ENABLE_FULLSCREEN_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDEXED_DATABASE_IN_WORKERS) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_INTERSECTION_OBSERVER) $(ENABLE_INTL) $(ENABLE_IOS_GESTURE_EVENTS) $(ENABLE_IOS_TOUCH_EVENTS) $(ENABLE_JIT) $(ENABLE_KEYBOARD_CODE_ATTRIBUTE) $(ENABLE_KEYBOARD_KEY_ATTRIBUTE) $(ENABLE_LAYOUT_FORMATTING_CONTEXT) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER) $(ENABLE_LEGACY_ENCRYPTED_MEDIA) $(ENABLE_LETTERPRESS) $(ENABLE_MAC_GESTURE_EVENTS) $(ENABLE_MAC_VIDEO_TOOLBOX) $(ENABLE_MATHML) $(ENABLE_MEDIA_CAPTURE) $(ENABLE_MEDIA_CONTROLS_SCRIPT) $(ENABLE_MEDIA_SESSION) $(ENABLE_MEDIA_SO
URCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_MEDIA_STREAM) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_CONTENT_UTILS) $(ENABLE_NAVIGATOR_STANDALONE) $(ENABLE_NOTIFICATIONS) $(ENABLE_PAYMENT_REQUEST) $(ENABLE_PDFKIT_PLUGIN) $(ENABLE_POINTER_LOCK) $(ENABLE_PUBLIC_SUFFIX_LIST) $(ENABLE_QUOTA) $(ENABLE_REMOTE_INSPECTOR) $(ENABLE_RESOLUTION_MEDIA_QUERY) $(ENABLE_RESOURCE_LOAD_STATISTICS) $(ENABLE_RESOURCE_USAGE) $(ENABLE_RUBBER_BANDING) $(ENABLE_SERVICE_CONTROLS) $(ENABLE_SERVICE_WORKER) $(ENABLE_SPEECH_SYNTHESIS) $(ENABLE_STREAMS_API) $(ENABLE_WEB_CRYPTO) $(ENABLE_SVG_FONTS) $(ENABLE_TELEPHONE_NUMBER_DETECTION) $(ENABLE_TEXT_AUTOSIZING) $(ENABLE_TOUCH_EVENTS) $(ENABLE_USER_MESSAGE_HANDLERS) $(ENABLE_USERSELECT_ALL) $(ENABLE_VARIATION_FONTS) $(ENABLE_VIDEO) $(ENABLE_VIDEO_PRESENTATION_MODE) $(ENABLE_VIDEO_TRACK) $(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) $(ENABLE_WEB_API_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_AUTHN) $(ENABLE_WEB_RTC) $(ENABLE_W
EBASSEMBLY) $(ENABLE_WEBASSEMBLY_STREAMING_API) $(ENABLE_WEBGL) $(ENABLE_WEBGL2) $(ENABLE_WEBGPU) $(ENABLE_WEBMETAL) $(ENABLE_WIRELESS_PLAYBACK_TARGET) $(ENABLE_XSLT);
Modified: branches/safari-607.2.6.0-branch/Source/WebKitLegacy/mac/ChangeLog (244636 => 244637)
--- branches/safari-607.2.6.0-branch/Source/WebKitLegacy/mac/ChangeLog 2019-04-25 06:42:23 UTC (rev 244636)
+++ branches/safari-607.2.6.0-branch/Source/WebKitLegacy/mac/ChangeLog 2019-04-25 06:42:33 UTC (rev 244637)
@@ -1,5 +1,154 @@
2019-04-24 Babak Shafiei <[email protected]>
+ Cherry-pick r244174. rdar://problem/28160396
+
+ Cherry-pick r243841. rdar://problem/49725678
+
+ -apple-trailing-word is needed for browser detection
+ https://bugs.webkit.org/show_bug.cgi?id=196575
+
+ Unreviewed.
+
+ PerformanceTests:
+
+ * MotionMark/resources/debug-runner/motionmark.css:
+ (#intro .start-benchmark p):
+
+ Source/_javascript_Core:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebCore:
+
+ This is an unreviewed partial revert of r243819. Turns out there are some websites
+ which use this property to do browser detection. So, we need to continue to parse
+ the property, but we don't need the property to do anything.
+
+ Test: fast/text/trailing-word-detection.html
+
+ * Configurations/FeatureDefines.xcconfig:
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
+ * css/CSSPrimitiveValueMappings.h:
+ (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+ (WebCore::CSSPrimitiveValue::operator TrailingWord const):
+ * css/CSSProperties.json:
+ * css/CSSValueKeywords.in:
+ * css/parser/CSSParserFastPaths.cpp:
+ (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
+ (WebCore::CSSParserFastPaths::isKeywordPropertyID):
+ * rendering/style/RenderStyle.h:
+ (WebCore::RenderStyle::trailingWord const):
+ (WebCore::RenderStyle::setTrailingWord):
+ (WebCore::RenderStyle::initialTrailingWord):
+ * rendering/style/RenderStyleConstants.h:
+
+ Source/WebCore/PAL:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebKit:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebKitLegacy/mac:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Tools:
+
+ * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
+
+ LayoutTests:
+
+ * fast/text/trailing-word-detection-expected.txt: Added.
+ * fast/text/trailing-word-detection.html: Added.
+ * platform/gtk/TestExpectations:
+ * platform/win/TestExpectations:
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-607-branch@244174 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2019-04-10 Alan Coon <[email protected]>
+
+ Cherry-pick r243841. rdar://problem/49725678
+
+ -apple-trailing-word is needed for browser detection
+ https://bugs.webkit.org/show_bug.cgi?id=196575
+
+ Unreviewed.
+
+ PerformanceTests:
+
+ * MotionMark/resources/debug-runner/motionmark.css:
+ (#intro .start-benchmark p):
+
+ Source/_javascript_Core:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebCore:
+
+ This is an unreviewed partial revert of r243819. Turns out there are some websites
+ which use this property to do browser detection. So, we need to continue to parse
+ the property, but we don't need the property to do anything.
+
+ Test: fast/text/trailing-word-detection.html
+
+ * Configurations/FeatureDefines.xcconfig:
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
+ * css/CSSPrimitiveValueMappings.h:
+ (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+ (WebCore::CSSPrimitiveValue::operator TrailingWord const):
+ * css/CSSProperties.json:
+ * css/CSSValueKeywords.in:
+ * css/parser/CSSParserFastPaths.cpp:
+ (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
+ (WebCore::CSSParserFastPaths::isKeywordPropertyID):
+ * rendering/style/RenderStyle.h:
+ (WebCore::RenderStyle::trailingWord const):
+ (WebCore::RenderStyle::setTrailingWord):
+ (WebCore::RenderStyle::initialTrailingWord):
+ * rendering/style/RenderStyleConstants.h:
+
+ Source/WebCore/PAL:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebKit:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebKitLegacy/mac:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Tools:
+
+ * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
+
+ LayoutTests:
+
+ * fast/text/trailing-word-detection-expected.txt: Added.
+ * fast/text/trailing-word-detection.html: Added.
+ * platform/gtk/TestExpectations:
+ * platform/win/TestExpectations:
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2019-04-03 Myles C. Maxfield <[email protected]>
+
+ -apple-trailing-word is needed for browser detection
+ https://bugs.webkit.org/show_bug.cgi?id=196575
+
+ Unreviewed.
+
+ * Configurations/FeatureDefines.xcconfig:
+
+2019-04-24 Babak Shafiei <[email protected]>
+
Cherry-pick r244173. rdar://problem/28160396
Cherry-pick r243819. rdar://problem/49725678
Modified: branches/safari-607.2.6.0-branch/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig (244636 => 244637)
--- branches/safari-607.2.6.0-branch/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig 2019-04-25 06:42:23 UTC (rev 244636)
+++ branches/safari-607.2.6.0-branch/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig 2019-04-25 06:42:33 UTC (rev 244637)
@@ -92,6 +92,8 @@
ENABLE_CSS_SELECTORS_LEVEL4 = ENABLE_CSS_SELECTORS_LEVEL4;
+ENABLE_CSS_TRAILING_WORD = ENABLE_CSS_TRAILING_WORD;
+
ENABLE_CSS_TYPED_OM = ENABLE_CSS_TYPED_OM;
ENABLE_CSS_CONIC_GRADIENTS = ENABLE_CSS_CONIC_GRADIENTS;
@@ -400,4 +402,4 @@
ENABLE_XSLT = ENABLE_XSLT;
-FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCELERATED_OVERFLOW_SCROLLING) $(ENABLE_APPLE_PAY) $(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_APPLE_PAY_SESSION_V4) $(ENABLE_APPLICATION_MANIFEST) $(ENABLE_ATTACHMENT_ELEMENT) $(ENABLE_AVF_CAPTIONS) $(ENABLE_C_LOOP) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CONTENT_FILTERING) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_IMAGE_ORIENTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_PAINTING_API) $(ENABLE_CSS_SCROLL_SNAP) $(ENABLE_CSS_SELECTORS_LEVEL4) $(ENABLE_CSS_TYPED_OM) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_CSS_CONIC_GRADIENTS) $(ENABLE_DARK_MODE_CSS) $(ENABLE_DASHBOARD_SUPPORT) $(ENABLE_DATA_INTERACTION) $(ENABLE_DATACUE_VALUE) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DRAG_SUPPORT) $(ENABLE_ENCRYPTED_MEDIA) $(ENABLE_EXPERIMENTAL_
FEATURES) $(ENABLE_FAST_JIT_PERMISSIONS) $(ENABLE_FILTERS_LEVEL_2) $(ENABLE_FTL_JIT) $(ENABLE_FULLSCREEN_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDEXED_DATABASE_IN_WORKERS) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_INTERSECTION_OBSERVER) $(ENABLE_INTL) $(ENABLE_IOS_GESTURE_EVENTS) $(ENABLE_IOS_TOUCH_EVENTS) $(ENABLE_JIT) $(ENABLE_KEYBOARD_CODE_ATTRIBUTE) $(ENABLE_KEYBOARD_KEY_ATTRIBUTE) $(ENABLE_LAYOUT_FORMATTING_CONTEXT) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER) $(ENABLE_LEGACY_ENCRYPTED_MEDIA) $(ENABLE_LETTERPRESS) $(ENABLE_MAC_GESTURE_EVENTS) $(ENABLE_MAC_VIDEO_TOOLBOX) $(ENABLE_MATHML) $(ENABLE_MEDIA_CAPTURE) $(ENABLE_MEDIA_CONTROLS_SCRIPT) $(ENABLE_MEDIA_SESSION) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATIS
TICS) $(ENABLE_MEDIA_STREAM) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_CONTENT_UTILS) $(ENABLE_NAVIGATOR_STANDALONE) $(ENABLE_NOTIFICATIONS) $(ENABLE_PAYMENT_REQUEST) $(ENABLE_PDFKIT_PLUGIN) $(ENABLE_POINTER_LOCK) $(ENABLE_PUBLIC_SUFFIX_LIST) $(ENABLE_QUOTA) $(ENABLE_REMOTE_INSPECTOR) $(ENABLE_RESOLUTION_MEDIA_QUERY) $(ENABLE_RESOURCE_LOAD_STATISTICS) $(ENABLE_RESOURCE_USAGE) $(ENABLE_RUBBER_BANDING) $(ENABLE_SERVICE_CONTROLS) $(ENABLE_SERVICE_WORKER) $(ENABLE_SPEECH_SYNTHESIS) $(ENABLE_STREAMS_API) $(ENABLE_WEB_CRYPTO) $(ENABLE_SVG_FONTS) $(ENABLE_TELEPHONE_NUMBER_DETECTION) $(ENABLE_TEXT_AUTOSIZING) $(ENABLE_TOUCH_EVENTS) $(ENABLE_USER_MESSAGE_HANDLERS) $(ENABLE_USERSELECT_ALL) $(ENABLE_VARIATION_FONTS) $(ENABLE_VIDEO) $(ENABLE_VIDEO_PRESENTATION_MODE) $(ENABLE_VIDEO_TRACK) $(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) $(ENABLE_WEB_API_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_AUTHN) $(ENABLE_WEB_RTC) $(ENABLE_WEBASSEMBLY) $(ENABLE_WEBASS
EMBLY_STREAMING_API) $(ENABLE_WEBGL) $(ENABLE_WEBGL2) $(ENABLE_WEBGPU) $(ENABLE_WEBMETAL) $(ENABLE_WIRELESS_PLAYBACK_TARGET) $(ENABLE_XSLT);
+FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCELERATED_OVERFLOW_SCROLLING) $(ENABLE_APPLE_PAY) $(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_APPLE_PAY_SESSION_V4) $(ENABLE_APPLICATION_MANIFEST) $(ENABLE_ATTACHMENT_ELEMENT) $(ENABLE_AVF_CAPTIONS) $(ENABLE_C_LOOP) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CONTENT_FILTERING) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_IMAGE_ORIENTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_PAINTING_API) $(ENABLE_CSS_SCROLL_SNAP) $(ENABLE_CSS_SELECTORS_LEVEL4) $(ENABLE_CSS_TRAILING_WORD) $(ENABLE_CSS_TYPED_OM) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_CSS_CONIC_GRADIENTS) $(ENABLE_DARK_MODE_CSS) $(ENABLE_DASHBOARD_SUPPORT) $(ENABLE_DATA_INTERACTION) $(ENABLE_DATACUE_VALUE) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DRAG_SUPPORT) $(ENABLE_ENCRYPTED_ME
DIA) $(ENABLE_EXPERIMENTAL_FEATURES) $(ENABLE_FAST_JIT_PERMISSIONS) $(ENABLE_FILTERS_LEVEL_2) $(ENABLE_FTL_JIT) $(ENABLE_FULLSCREEN_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDEXED_DATABASE_IN_WORKERS) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_INTERSECTION_OBSERVER) $(ENABLE_INTL) $(ENABLE_IOS_GESTURE_EVENTS) $(ENABLE_IOS_TOUCH_EVENTS) $(ENABLE_JIT) $(ENABLE_KEYBOARD_CODE_ATTRIBUTE) $(ENABLE_KEYBOARD_KEY_ATTRIBUTE) $(ENABLE_LAYOUT_FORMATTING_CONTEXT) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER) $(ENABLE_LEGACY_ENCRYPTED_MEDIA) $(ENABLE_LETTERPRESS) $(ENABLE_MAC_GESTURE_EVENTS) $(ENABLE_MAC_VIDEO_TOOLBOX) $(ENABLE_MATHML) $(ENABLE_MEDIA_CAPTURE) $(ENABLE_MEDIA_CONTROLS_SCRIPT) $(ENABLE_MEDIA_SESSION) $(ENABLE_MEDIA_SO
URCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_MEDIA_STREAM) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_CONTENT_UTILS) $(ENABLE_NAVIGATOR_STANDALONE) $(ENABLE_NOTIFICATIONS) $(ENABLE_PAYMENT_REQUEST) $(ENABLE_PDFKIT_PLUGIN) $(ENABLE_POINTER_LOCK) $(ENABLE_PUBLIC_SUFFIX_LIST) $(ENABLE_QUOTA) $(ENABLE_REMOTE_INSPECTOR) $(ENABLE_RESOLUTION_MEDIA_QUERY) $(ENABLE_RESOURCE_LOAD_STATISTICS) $(ENABLE_RESOURCE_USAGE) $(ENABLE_RUBBER_BANDING) $(ENABLE_SERVICE_CONTROLS) $(ENABLE_SERVICE_WORKER) $(ENABLE_SPEECH_SYNTHESIS) $(ENABLE_STREAMS_API) $(ENABLE_WEB_CRYPTO) $(ENABLE_SVG_FONTS) $(ENABLE_TELEPHONE_NUMBER_DETECTION) $(ENABLE_TEXT_AUTOSIZING) $(ENABLE_TOUCH_EVENTS) $(ENABLE_USER_MESSAGE_HANDLERS) $(ENABLE_USERSELECT_ALL) $(ENABLE_VARIATION_FONTS) $(ENABLE_VIDEO) $(ENABLE_VIDEO_PRESENTATION_MODE) $(ENABLE_VIDEO_TRACK) $(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) $(ENABLE_WEB_API_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_AUTHN) $(ENABLE_WEB_RTC) $(ENABLE_W
EBASSEMBLY) $(ENABLE_WEBASSEMBLY_STREAMING_API) $(ENABLE_WEBGL) $(ENABLE_WEBGL2) $(ENABLE_WEBGPU) $(ENABLE_WEBMETAL) $(ENABLE_WIRELESS_PLAYBACK_TARGET) $(ENABLE_XSLT);
Modified: branches/safari-607.2.6.0-branch/Tools/ChangeLog (244636 => 244637)
--- branches/safari-607.2.6.0-branch/Tools/ChangeLog 2019-04-25 06:42:23 UTC (rev 244636)
+++ branches/safari-607.2.6.0-branch/Tools/ChangeLog 2019-04-25 06:42:33 UTC (rev 244637)
@@ -1,5 +1,154 @@
2019-04-24 Babak Shafiei <[email protected]>
+ Cherry-pick r244174. rdar://problem/28160396
+
+ Cherry-pick r243841. rdar://problem/49725678
+
+ -apple-trailing-word is needed for browser detection
+ https://bugs.webkit.org/show_bug.cgi?id=196575
+
+ Unreviewed.
+
+ PerformanceTests:
+
+ * MotionMark/resources/debug-runner/motionmark.css:
+ (#intro .start-benchmark p):
+
+ Source/_javascript_Core:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebCore:
+
+ This is an unreviewed partial revert of r243819. Turns out there are some websites
+ which use this property to do browser detection. So, we need to continue to parse
+ the property, but we don't need the property to do anything.
+
+ Test: fast/text/trailing-word-detection.html
+
+ * Configurations/FeatureDefines.xcconfig:
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
+ * css/CSSPrimitiveValueMappings.h:
+ (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+ (WebCore::CSSPrimitiveValue::operator TrailingWord const):
+ * css/CSSProperties.json:
+ * css/CSSValueKeywords.in:
+ * css/parser/CSSParserFastPaths.cpp:
+ (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
+ (WebCore::CSSParserFastPaths::isKeywordPropertyID):
+ * rendering/style/RenderStyle.h:
+ (WebCore::RenderStyle::trailingWord const):
+ (WebCore::RenderStyle::setTrailingWord):
+ (WebCore::RenderStyle::initialTrailingWord):
+ * rendering/style/RenderStyleConstants.h:
+
+ Source/WebCore/PAL:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebKit:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebKitLegacy/mac:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Tools:
+
+ * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
+
+ LayoutTests:
+
+ * fast/text/trailing-word-detection-expected.txt: Added.
+ * fast/text/trailing-word-detection.html: Added.
+ * platform/gtk/TestExpectations:
+ * platform/win/TestExpectations:
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-607-branch@244174 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2019-04-10 Alan Coon <[email protected]>
+
+ Cherry-pick r243841. rdar://problem/49725678
+
+ -apple-trailing-word is needed for browser detection
+ https://bugs.webkit.org/show_bug.cgi?id=196575
+
+ Unreviewed.
+
+ PerformanceTests:
+
+ * MotionMark/resources/debug-runner/motionmark.css:
+ (#intro .start-benchmark p):
+
+ Source/_javascript_Core:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebCore:
+
+ This is an unreviewed partial revert of r243819. Turns out there are some websites
+ which use this property to do browser detection. So, we need to continue to parse
+ the property, but we don't need the property to do anything.
+
+ Test: fast/text/trailing-word-detection.html
+
+ * Configurations/FeatureDefines.xcconfig:
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
+ * css/CSSPrimitiveValueMappings.h:
+ (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+ (WebCore::CSSPrimitiveValue::operator TrailingWord const):
+ * css/CSSProperties.json:
+ * css/CSSValueKeywords.in:
+ * css/parser/CSSParserFastPaths.cpp:
+ (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
+ (WebCore::CSSParserFastPaths::isKeywordPropertyID):
+ * rendering/style/RenderStyle.h:
+ (WebCore::RenderStyle::trailingWord const):
+ (WebCore::RenderStyle::setTrailingWord):
+ (WebCore::RenderStyle::initialTrailingWord):
+ * rendering/style/RenderStyleConstants.h:
+
+ Source/WebCore/PAL:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebKit:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Source/WebKitLegacy/mac:
+
+ * Configurations/FeatureDefines.xcconfig:
+
+ Tools:
+
+ * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
+
+ LayoutTests:
+
+ * fast/text/trailing-word-detection-expected.txt: Added.
+ * fast/text/trailing-word-detection.html: Added.
+ * platform/gtk/TestExpectations:
+ * platform/win/TestExpectations:
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2019-04-03 Myles C. Maxfield <[email protected]>
+
+ -apple-trailing-word is needed for browser detection
+ https://bugs.webkit.org/show_bug.cgi?id=196575
+
+ Unreviewed.
+
+ * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
+
+2019-04-24 Babak Shafiei <[email protected]>
+
Cherry-pick r244173. rdar://problem/28160396
Cherry-pick r243819. rdar://problem/49725678
Modified: branches/safari-607.2.6.0-branch/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig (244636 => 244637)
--- branches/safari-607.2.6.0-branch/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig 2019-04-25 06:42:23 UTC (rev 244636)
+++ branches/safari-607.2.6.0-branch/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig 2019-04-25 06:42:33 UTC (rev 244637)
@@ -92,6 +92,8 @@
ENABLE_CSS_SELECTORS_LEVEL4 = ENABLE_CSS_SELECTORS_LEVEL4;
+ENABLE_CSS_TRAILING_WORD = ENABLE_CSS_TRAILING_WORD;
+
ENABLE_CSS_TYPED_OM = ENABLE_CSS_TYPED_OM;
ENABLE_CSS_CONIC_GRADIENTS = ENABLE_CSS_CONIC_GRADIENTS;
@@ -400,4 +402,4 @@
ENABLE_XSLT = ENABLE_XSLT;
-FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCELERATED_OVERFLOW_SCROLLING) $(ENABLE_APPLE_PAY) $(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_APPLE_PAY_SESSION_V4) $(ENABLE_APPLICATION_MANIFEST) $(ENABLE_ATTACHMENT_ELEMENT) $(ENABLE_AVF_CAPTIONS) $(ENABLE_C_LOOP) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CONTENT_FILTERING) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_IMAGE_ORIENTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_PAINTING_API) $(ENABLE_CSS_SCROLL_SNAP) $(ENABLE_CSS_SELECTORS_LEVEL4) $(ENABLE_CSS_TYPED_OM) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_CSS_CONIC_GRADIENTS) $(ENABLE_DARK_MODE_CSS) $(ENABLE_DASHBOARD_SUPPORT) $(ENABLE_DATA_INTERACTION) $(ENABLE_DATACUE_VALUE) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DRAG_SUPPORT) $(ENABLE_ENCRYPTED_MEDIA) $(ENABLE_EXPERIMENTAL_
FEATURES) $(ENABLE_FAST_JIT_PERMISSIONS) $(ENABLE_FILTERS_LEVEL_2) $(ENABLE_FTL_JIT) $(ENABLE_FULLSCREEN_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDEXED_DATABASE_IN_WORKERS) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_INTERSECTION_OBSERVER) $(ENABLE_INTL) $(ENABLE_IOS_GESTURE_EVENTS) $(ENABLE_IOS_TOUCH_EVENTS) $(ENABLE_JIT) $(ENABLE_KEYBOARD_CODE_ATTRIBUTE) $(ENABLE_KEYBOARD_KEY_ATTRIBUTE) $(ENABLE_LAYOUT_FORMATTING_CONTEXT) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER) $(ENABLE_LEGACY_ENCRYPTED_MEDIA) $(ENABLE_LETTERPRESS) $(ENABLE_MAC_GESTURE_EVENTS) $(ENABLE_MAC_VIDEO_TOOLBOX) $(ENABLE_MATHML) $(ENABLE_MEDIA_CAPTURE) $(ENABLE_MEDIA_CONTROLS_SCRIPT) $(ENABLE_MEDIA_SESSION) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATIS
TICS) $(ENABLE_MEDIA_STREAM) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_CONTENT_UTILS) $(ENABLE_NAVIGATOR_STANDALONE) $(ENABLE_NOTIFICATIONS) $(ENABLE_PAYMENT_REQUEST) $(ENABLE_PDFKIT_PLUGIN) $(ENABLE_POINTER_LOCK) $(ENABLE_PUBLIC_SUFFIX_LIST) $(ENABLE_QUOTA) $(ENABLE_REMOTE_INSPECTOR) $(ENABLE_RESOLUTION_MEDIA_QUERY) $(ENABLE_RESOURCE_LOAD_STATISTICS) $(ENABLE_RESOURCE_USAGE) $(ENABLE_RUBBER_BANDING) $(ENABLE_SERVICE_CONTROLS) $(ENABLE_SERVICE_WORKER) $(ENABLE_SPEECH_SYNTHESIS) $(ENABLE_STREAMS_API) $(ENABLE_WEB_CRYPTO) $(ENABLE_SVG_FONTS) $(ENABLE_TELEPHONE_NUMBER_DETECTION) $(ENABLE_TEXT_AUTOSIZING) $(ENABLE_TOUCH_EVENTS) $(ENABLE_USER_MESSAGE_HANDLERS) $(ENABLE_USERSELECT_ALL) $(ENABLE_VARIATION_FONTS) $(ENABLE_VIDEO) $(ENABLE_VIDEO_PRESENTATION_MODE) $(ENABLE_VIDEO_TRACK) $(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) $(ENABLE_WEB_API_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_AUTHN) $(ENABLE_WEB_RTC) $(ENABLE_WEBASSEMBLY) $(ENABLE_WEBASS
EMBLY_STREAMING_API) $(ENABLE_WEBGL) $(ENABLE_WEBGL2) $(ENABLE_WEBGPU) $(ENABLE_WEBMETAL) $(ENABLE_WIRELESS_PLAYBACK_TARGET) $(ENABLE_XSLT);
+FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCELERATED_OVERFLOW_SCROLLING) $(ENABLE_APPLE_PAY) $(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_APPLE_PAY_SESSION_V4) $(ENABLE_APPLICATION_MANIFEST) $(ENABLE_ATTACHMENT_ELEMENT) $(ENABLE_AVF_CAPTIONS) $(ENABLE_C_LOOP) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CONTENT_FILTERING) $(ENABLE_CSS3_TEXT) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_IMAGE_ORIENTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_PAINTING_API) $(ENABLE_CSS_SCROLL_SNAP) $(ENABLE_CSS_SELECTORS_LEVEL4) $(ENABLE_CSS_TRAILING_WORD) $(ENABLE_CSS_TYPED_OM) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_CSS_CONIC_GRADIENTS) $(ENABLE_DARK_MODE_CSS) $(ENABLE_DASHBOARD_SUPPORT) $(ENABLE_DATA_INTERACTION) $(ENABLE_DATACUE_VALUE) $(ENABLE_DATALIST_ELEMENT) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DRAG_SUPPORT) $(ENABLE_ENCRYPTED_ME
DIA) $(ENABLE_EXPERIMENTAL_FEATURES) $(ENABLE_FAST_JIT_PERMISSIONS) $(ENABLE_FILTERS_LEVEL_2) $(ENABLE_FTL_JIT) $(ENABLE_FULLSCREEN_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INDEXED_DATABASE_IN_WORKERS) $(ENABLE_INPUT_TYPE_COLOR) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_INTERSECTION_OBSERVER) $(ENABLE_INTL) $(ENABLE_IOS_GESTURE_EVENTS) $(ENABLE_IOS_TOUCH_EVENTS) $(ENABLE_JIT) $(ENABLE_KEYBOARD_CODE_ATTRIBUTE) $(ENABLE_KEYBOARD_KEY_ATTRIBUTE) $(ENABLE_LAYOUT_FORMATTING_CONTEXT) $(ENABLE_LEGACY_CSS_VENDOR_PREFIXES) $(ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER) $(ENABLE_LEGACY_ENCRYPTED_MEDIA) $(ENABLE_LETTERPRESS) $(ENABLE_MAC_GESTURE_EVENTS) $(ENABLE_MAC_VIDEO_TOOLBOX) $(ENABLE_MATHML) $(ENABLE_MEDIA_CAPTURE) $(ENABLE_MEDIA_CONTROLS_SCRIPT) $(ENABLE_MEDIA_SESSION) $(ENABLE_MEDIA_SO
URCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_MEDIA_STREAM) $(ENABLE_METER_ELEMENT) $(ENABLE_MHTML) $(ENABLE_MOUSE_CURSOR_SCALE) $(ENABLE_NAVIGATOR_CONTENT_UTILS) $(ENABLE_NAVIGATOR_STANDALONE) $(ENABLE_NOTIFICATIONS) $(ENABLE_PAYMENT_REQUEST) $(ENABLE_PDFKIT_PLUGIN) $(ENABLE_POINTER_LOCK) $(ENABLE_PUBLIC_SUFFIX_LIST) $(ENABLE_QUOTA) $(ENABLE_REMOTE_INSPECTOR) $(ENABLE_RESOLUTION_MEDIA_QUERY) $(ENABLE_RESOURCE_LOAD_STATISTICS) $(ENABLE_RESOURCE_USAGE) $(ENABLE_RUBBER_BANDING) $(ENABLE_SERVICE_CONTROLS) $(ENABLE_SERVICE_WORKER) $(ENABLE_SPEECH_SYNTHESIS) $(ENABLE_STREAMS_API) $(ENABLE_WEB_CRYPTO) $(ENABLE_SVG_FONTS) $(ENABLE_TELEPHONE_NUMBER_DETECTION) $(ENABLE_TEXT_AUTOSIZING) $(ENABLE_TOUCH_EVENTS) $(ENABLE_USER_MESSAGE_HANDLERS) $(ENABLE_USERSELECT_ALL) $(ENABLE_VARIATION_FONTS) $(ENABLE_VIDEO) $(ENABLE_VIDEO_PRESENTATION_MODE) $(ENABLE_VIDEO_TRACK) $(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) $(ENABLE_WEB_API_STATISTICS) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_AUTHN) $(ENABLE_WEB_RTC) $(ENABLE_W
EBASSEMBLY) $(ENABLE_WEBASSEMBLY_STREAMING_API) $(ENABLE_WEBGL) $(ENABLE_WEBGL2) $(ENABLE_WEBGPU) $(ENABLE_WEBMETAL) $(ENABLE_WIRELESS_PLAYBACK_TARGET) $(ENABLE_XSLT);
