Title: [244663] trunk/Source/WebCore
- Revision
- 244663
- Author
- [email protected]
- Date
- 2019-04-25 14:27:10 -0700 (Thu, 25 Apr 2019)
Log Message
Fix more Windows builds after r244653
https://bugs.webkit.org/show_bug.cgi?id=197131
* svg/properties/SVGAnimatedPropertyList.h:
* svg/properties/SVGProperty.h:
* svg/properties/SVGPropertyList.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (244662 => 244663)
--- trunk/Source/WebCore/ChangeLog 2019-04-25 20:08:06 UTC (rev 244662)
+++ trunk/Source/WebCore/ChangeLog 2019-04-25 21:27:10 UTC (rev 244663)
@@ -1,5 +1,14 @@
2019-04-25 Alex Christensen <[email protected]>
+ Fix more Windows builds after r244653
+ https://bugs.webkit.org/show_bug.cgi?id=197131
+
+ * svg/properties/SVGAnimatedPropertyList.h:
+ * svg/properties/SVGProperty.h:
+ * svg/properties/SVGPropertyList.h:
+
+2019-04-25 Alex Christensen <[email protected]>
+
Fix more builds after r244653
https://bugs.webkit.org/show_bug.cgi?id=197131
Modified: trunk/Source/WebCore/svg/properties/SVGAnimatedPropertyList.h (244662 => 244663)
--- trunk/Source/WebCore/svg/properties/SVGAnimatedPropertyList.h 2019-04-25 20:08:06 UTC (rev 244662)
+++ trunk/Source/WebCore/svg/properties/SVGAnimatedPropertyList.h 2019-04-25 21:27:10 UTC (rev 244663)
@@ -109,7 +109,11 @@
SVGAnimatedProperty::instanceStopAnimation();
}
+ // Visual Studio doesn't seem to see these private constructors from subclasses.
+ // FIXME: See what it takes to remove this hack.
+#if !COMPILER(MSVC)
protected:
+#endif
template<typename... Arguments>
SVGAnimatedPropertyList(SVGElement* contextElement, Arguments&&... arguments)
: SVGAnimatedProperty(contextElement)
Modified: trunk/Source/WebCore/svg/properties/SVGProperty.h (244662 => 244663)
--- trunk/Source/WebCore/svg/properties/SVGProperty.h 2019-04-25 20:08:06 UTC (rev 244662)
+++ trunk/Source/WebCore/svg/properties/SVGProperty.h 2019-04-25 21:27:10 UTC (rev 244663)
@@ -83,7 +83,11 @@
// This is used when calling setAttribute().
virtual String valueAsString() const { return emptyString(); }
+ // Visual Studio doesn't seem to see these private constructors from subclasses.
+ // FIXME: See what it takes to remove this hack.
+#if !COMPILER(MSVC)
protected:
+#endif
SVGProperty(SVGPropertyOwner* owner = nullptr, SVGPropertyAccess access = SVGPropertyAccess::ReadWrite)
: m_owner(owner)
, m_access(access)
Modified: trunk/Source/WebCore/svg/properties/SVGPropertyList.h (244662 => 244663)
--- trunk/Source/WebCore/svg/properties/SVGPropertyList.h 2019-04-25 20:08:06 UTC (rev 244662)
+++ trunk/Source/WebCore/svg/properties/SVGPropertyList.h 2019-04-25 21:27:10 UTC (rev 244663)
@@ -37,7 +37,11 @@
using BaseList::size;
using BaseList::append;
+ // Visual Studio doesn't seem to see these private constructors from subclasses.
+ // FIXME: See what it takes to remove this hack.
+#if !COMPILER(MSVC)
protected:
+#endif
using SVGPropertyOwner::SVGPropertyOwner;
using BaseList::m_items;
using BaseList::m_access;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
