Title: [244722] trunk/Source/WebCore
- Revision
- 244722
- Author
- [email protected]
- Date
- 2019-04-27 12:31:00 -0700 (Sat, 27 Apr 2019)
Log Message
Move some Compositing logging to the Layers log channel
https://bugs.webkit.org/show_bug.cgi?id=197345
Reviewed by Sam Weinig.
Make Compositing logging a bit less verbose by moving the GraphicsLayer tree dump
to the Layers log channel. Also log GraphicsLayers after flushing, when we'll have
accurate visible rects.
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateCoverage):
* rendering/RenderLayerCompositor.cpp:
(WebCore::layersLogEnabled):
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (244721 => 244722)
--- trunk/Source/WebCore/ChangeLog 2019-04-27 17:09:24 UTC (rev 244721)
+++ trunk/Source/WebCore/ChangeLog 2019-04-27 19:31:00 UTC (rev 244722)
@@ -1,3 +1,21 @@
+2019-04-27 Simon Fraser <[email protected]>
+
+ Move some Compositing logging to the Layers log channel
+ https://bugs.webkit.org/show_bug.cgi?id=197345
+
+ Reviewed by Sam Weinig.
+
+ Make Compositing logging a bit less verbose by moving the GraphicsLayer tree dump
+ to the Layers log channel. Also log GraphicsLayers after flushing, when we'll have
+ accurate visible rects.
+
+ * platform/graphics/ca/GraphicsLayerCA.cpp:
+ (WebCore::GraphicsLayerCA::updateCoverage):
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::layersLogEnabled):
+ (WebCore::RenderLayerCompositor::flushPendingLayerChanges):
+ (WebCore::RenderLayerCompositor::updateCompositingLayers):
+
2019-04-27 Megan Gardner <[email protected]>
Lookup only looking up the first word in selection
Modified: trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp (244721 => 244722)
--- trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2019-04-27 17:09:24 UTC (rev 244721)
+++ trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2019-04-27 19:31:00 UTC (rev 244722)
@@ -2423,9 +2423,9 @@
return "has transform animation with unknown extent";
};
- LOG_WITH_STREAM(Compositing, stream << "GraphicsLayerCA " << this << " id " << primaryLayerID() << " setBackingStoreAttached: " << requiresBacking << " (" << reasonForBacking() << ")");
+ LOG_WITH_STREAM(Layers, stream << "GraphicsLayerCA " << this << " id " << primaryLayerID() << " setBackingStoreAttached: " << requiresBacking << " (" << reasonForBacking() << ")");
} else
- LOG_WITH_STREAM(Compositing, stream << "GraphicsLayerCA " << this << " id " << primaryLayerID() << " setBackingStoreAttached: " << requiresBacking);
+ LOG_WITH_STREAM(Layers, stream << "GraphicsLayerCA " << this << " id " << primaryLayerID() << " setBackingStoreAttached: " << requiresBacking);
#endif
m_layer->setBackingStoreAttached(requiresBacking);
Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (244721 => 244722)
--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2019-04-27 17:09:24 UTC (rev 244721)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2019-04-27 19:31:00 UTC (rev 244722)
@@ -276,6 +276,11 @@
{
return LogCompositing.state == WTFLogChannelState::On;
}
+
+static inline bool layersLogEnabled()
+{
+ return LogLayers.state == WTFLogChannelState::On;
+}
#endif
RenderLayerCompositor::RenderLayerCompositor(RenderView& renderView)
@@ -492,7 +497,7 @@
// As long as we're not the root of the flush, we can bail.
if (!isFlushRoot && rootLayerAttachment() == RootLayerAttachedViaEnclosingFrame)
return;
-
+
if (rootLayerAttachment() == RootLayerUnattached) {
#if PLATFORM(IOS_FAMILY)
startLayerFlushTimerIfNeeded();
@@ -515,6 +520,13 @@
}
ASSERT(m_flushingLayers);
+
+#if ENABLE(TREE_DEBUGGING)
+ if (layersLogEnabled()) {
+ LOG(Layers, "RenderLayerCompositor::flushPendingLayerChanges");
+ showGraphicsLayerTree(m_rootContentsLayer.get());
+ }
+#endif
}
#if PLATFORM(IOS_FAMILY)
@@ -806,8 +818,6 @@
if (compositingLogEnabled()) {
LOG(Compositing, "RenderLayerCompositor::updateCompositingLayers - post");
showPaintOrderTree(m_renderView.layer());
- LOG(Compositing, "RenderLayerCompositor::updateCompositingLayers - GraphicsLayers post, contentLayersCount %d", m_contentLayersCount);
- showGraphicsLayerTree(m_rootContentsLayer.get());
}
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
