Title: [244750] trunk/Source/WebKit
- Revision
- 244750
- Author
- [email protected]
- Date
- 2019-04-29 13:32:47 -0700 (Mon, 29 Apr 2019)
Log Message
Storage::deleteOldVersions does not need to retain Storage
https://bugs.webkit.org/show_bug.cgi?id=197336
<rdar://problem/48679972>
Reviewed by Darin Adler.
* NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::deleteOldVersions):
Something is wrong with the lifetime of Storage, but we only need a String, not the whole Storage.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (244749 => 244750)
--- trunk/Source/WebKit/ChangeLog 2019-04-29 20:04:33 UTC (rev 244749)
+++ trunk/Source/WebKit/ChangeLog 2019-04-29 20:32:47 UTC (rev 244750)
@@ -1,3 +1,15 @@
+2019-04-29 Alex Christensen <[email protected]>
+
+ Storage::deleteOldVersions does not need to retain Storage
+ https://bugs.webkit.org/show_bug.cgi?id=197336
+ <rdar://problem/48679972>
+
+ Reviewed by Darin Adler.
+
+ * NetworkProcess/cache/NetworkCacheStorage.cpp:
+ (WebKit::NetworkCache::Storage::deleteOldVersions):
+ Something is wrong with the lifetime of Storage, but we only need a String, not the whole Storage.
+
2019-04-29 Brent Fulgham <[email protected]>
[Cocoa] Move common sandbox files from Shared/mac to Shared/Cocoa
Modified: trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp (244749 => 244750)
--- trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp 2019-04-29 20:04:33 UTC (rev 244749)
+++ trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp 2019-04-29 20:32:47 UTC (rev 244750)
@@ -1109,9 +1109,8 @@
void Storage::deleteOldVersions()
{
- backgroundIOQueue().dispatch([this, protectedThis = makeRef(*this)] () mutable {
- auto cachePath = basePath();
- traverseDirectory(cachePath, [&cachePath](const String& subdirName, DirectoryEntryType type) {
+ backgroundIOQueue().dispatch([cachePath = basePath()] () mutable {
+ traverseDirectory(cachePath, [cachePath = WTFMove(cachePath)](const String& subdirName, DirectoryEntryType type) {
if (type != DirectoryEntryType::Directory)
return;
if (!subdirName.startsWith(versionDirectoryPrefix))
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
