Title: [244762] trunk

Diff

Modified: trunk/LayoutTests/ChangeLog (244761 => 244762)


--- trunk/LayoutTests/ChangeLog	2019-04-29 22:40:48 UTC (rev 244761)
+++ trunk/LayoutTests/ChangeLog	2019-04-29 23:55:51 UTC (rev 244762)
@@ -1,3 +1,16 @@
+2019-04-29  Truitt Savell  <[email protected]>
+
+        Unreviewed, rolling out r244755.
+
+        Casued several test failures on iOS
+
+        Reverted changeset:
+
+        "Double-tapping a post to like doesn't work on Instagram.com
+        (needs 'dblclick' event)"
+        https://bugs.webkit.org/show_bug.cgi?id=197347
+        https://trac.webkit.org/changeset/244755
+
 2019-04-29  Zalan Bujtas  <[email protected]>
 
         Double-tapping a post to like doesn't work on Instagram.com (needs 'dblclick' event)

Deleted: trunk/LayoutTests/fast/events/touch/ios/double-tap-for-double-click1-expected.txt (244761 => 244762)


--- trunk/LayoutTests/fast/events/touch/ios/double-tap-for-double-click1-expected.txt	2019-04-29 22:40:48 UTC (rev 244761)
+++ trunk/LayoutTests/fast/events/touch/ios/double-tap-for-double-click1-expected.txt	2019-04-29 23:55:51 UTC (rev 244762)
@@ -1,2 +0,0 @@
-PASS if 'double click' text is shown below.
-[click][click][double click]

Deleted: trunk/LayoutTests/fast/events/touch/ios/double-tap-for-double-click1.html (244761 => 244762)


--- trunk/LayoutTests/fast/events/touch/ios/double-tap-for-double-click1.html	2019-04-29 22:40:48 UTC (rev 244761)
+++ trunk/LayoutTests/fast/events/touch/ios/double-tap-for-double-click1.html	2019-04-29 23:55:51 UTC (rev 244762)
@@ -1,42 +0,0 @@
-<!DOCTYPE html><!-- webkit-test-runner [ useFlexibleViewport=true ] -->
-<html>
-<head>
-<meta name="viewport" content="width=device-width initial-scale=1 user-scalable=no">
-<title>This tests that we fire dblclick event on double tap</title>
-<script src=""
-<style>
-#doubleTapthis {
-    width: 400px;
-    height: 400px;
-    border: 1px solid green;
-}
-</style>
-<script>
-async function test() {
-    if (!window.testRunner || !testRunner.runUIScript)
-        return;
-
-    testRunner.waitUntilDone();
-    testRunner.dumpAsText();
-
-    await doubleTapAtPoint(doubleTapthis.offsetLeft, doubleTapthis.offsetTop);
-}
-</script>
-</head>
-<body _onload_="test()">
-<div id=doubleTapthis>PASS if 'double click' text is shown below.</div>
-<pre id=result></pre>
-<script>
-
-doubleTapthis.addEventListener("click", function( event ) {   
-    result.innerHTML = result.innerHTML + "[click]";
-}, false);
-
-doubleTapthis.addEventListener("dblclick", function( event ) {   
-    result.innerHTML = result.innerHTML + "[double click]";
-    if (window.testRunner)
-        setTimeout("testRunner.notifyDone()", 0);
-}, false);
-</script>
-</body>
-</html>

Deleted: trunk/LayoutTests/fast/events/touch/ios/double-tap-for-double-click2-expected.txt (244761 => 244762)


--- trunk/LayoutTests/fast/events/touch/ios/double-tap-for-double-click2-expected.txt	2019-04-29 22:40:48 UTC (rev 244761)
+++ trunk/LayoutTests/fast/events/touch/ios/double-tap-for-double-click2-expected.txt	2019-04-29 23:55:51 UTC (rev 244762)
@@ -1 +0,0 @@
-[double click]

Deleted: trunk/LayoutTests/fast/events/touch/ios/double-tap-for-double-click2.html (244761 => 244762)


--- trunk/LayoutTests/fast/events/touch/ios/double-tap-for-double-click2.html	2019-04-29 22:40:48 UTC (rev 244761)
+++ trunk/LayoutTests/fast/events/touch/ios/double-tap-for-double-click2.html	2019-04-29 23:55:51 UTC (rev 244762)
@@ -1,57 +0,0 @@
-<!DOCTYPE html><!-- webkit-test-runner [ useFlexibleViewport=true ] -->
-<html>
-<head>
-<meta name="viewport" content="width=device-width initial-scale=1 user-scalable=no">
-<title>This tests that we fire dblclick event on double tap when the content is replaced</title>
-<script src=""
-<style>
-#doubleTapThis {
-    width: 400px;
-    height: 400px;
-    border: 1px solid green;
-}
-
-#newDoubleTapThis {
-    width: 400px;
-    height: 400px;
-    border: 1px solid green;
-}
-</style>
-<script>
-async function test() {
-    if (!window.testRunner || !testRunner.runUIScript)
-        return;
-
-    testRunner.waitUntilDone();
-    testRunner.dumpAsText();
-
-    let rect = doubleTapThis.getBoundingClientRect();
-    let x = rect.left + rect.width / 2;
-    let y = rect.top + rect.height / 2;
-
-    await doubleTapAtPoint(x, y);
-}
-</script>
-</head>
-<body _onload_="test()">
-<div id=doubleTapThis>PASS if 'double click' text is shown below.</div>
-<pre id=result></pre>
-<script>
-
-doubleTapThis.addEventListener('click', function (e) {
-    doubleTapThis.remove();
-
-    let newDoubleTapThis = document.createElement("div");
-    newDoubleTapThis.id="newDoubleTapThis";
-    document.body.insertBefore(newDoubleTapThis, result);
-
-    newDoubleTapThis.addEventListener('dblclick', function (e) {
-        result.innerHTML = result.innerHTML + "[double click]";
-        if (window.testRunner)
-            setTimeout("testRunner.notifyDone()", 0);
-    });
-});
-
-</script>
-</body>
-</html>

Deleted: trunk/LayoutTests/fast/events/touch/ios/double-tap-for-double-click3-expected.txt (244761 => 244762)


--- trunk/LayoutTests/fast/events/touch/ios/double-tap-for-double-click3-expected.txt	2019-04-29 22:40:48 UTC (rev 244761)
+++ trunk/LayoutTests/fast/events/touch/ios/double-tap-for-double-click3-expected.txt	2019-04-29 23:55:51 UTC (rev 244762)
@@ -1,2 +0,0 @@
-PASS if 'double click' text is NOT shown below.
-[click][click]

Deleted: trunk/LayoutTests/fast/events/touch/ios/double-tap-for-double-click3.html (244761 => 244762)


--- trunk/LayoutTests/fast/events/touch/ios/double-tap-for-double-click3.html	2019-04-29 22:40:48 UTC (rev 244761)
+++ trunk/LayoutTests/fast/events/touch/ios/double-tap-for-double-click3.html	2019-04-29 23:55:51 UTC (rev 244762)
@@ -1,54 +0,0 @@
-<!DOCTYPE html><!-- webkit-test-runner [ useFlexibleViewport=true ] -->
-<html>
-<head>
-<meta name="viewport" content="width=device-width initial-scale=1 user-scalable=no">
-<title>This tests that we do not fire dblclick event on double tap on node with touch-action: none</title>
-<script src=""
-<style>
-#doubleTapthis {
-    width: 400px;
-    height: 400px;
-    border: 1px solid green;
-    touch-action: none;
-}
-#finishTest {
-    width: 10px;
-    height: 10px;
-    border: 1px solid green;
-}
-</style>
-<script>
-async function test() {
-    if (!window.testRunner || !testRunner.runUIScript)
-        return;
-
-    testRunner.waitUntilDone();
-    testRunner.dumpAsText();
-
-    await doubleTapAtPoint(doubleTapthis.offsetLeft, doubleTapthis.offsetTop);
-
-    await doubleTapAtPoint(finishTest.offsetLeft, finishTest.offsetTop);
-}
-</script>
-</head>
-<body _onload_="test()">
-<div id=doubleTapthis>PASS if 'double click' text is NOT shown below.</div>
-<div id=finishTest></div>
-<pre id=result></pre>
-<script>
-
-doubleTapthis.addEventListener("click", function( event ) {   
-    result.innerHTML = result.innerHTML + "[click]";
-}, false);
-
-doubleTapthis.addEventListener("dblclick", function( event ) {   
-    result.innerHTML = result.innerHTML + "[double click]";
-}, false);
-
-finishTest.addEventListener("dblclick", function( event ) {   
-    if (window.testRunner)
-        setTimeout("testRunner.notifyDone()", 0);
-}, false);
-</script>
-</body>
-</html>

Modified: trunk/Source/WebCore/ChangeLog (244761 => 244762)


--- trunk/Source/WebCore/ChangeLog	2019-04-29 22:40:48 UTC (rev 244761)
+++ trunk/Source/WebCore/ChangeLog	2019-04-29 23:55:51 UTC (rev 244762)
@@ -1,3 +1,16 @@
+2019-04-29  Truitt Savell  <[email protected]>
+
+        Unreviewed, rolling out r244755.
+
+        Casued several test failures on iOS
+
+        Reverted changeset:
+
+        "Double-tapping a post to like doesn't work on Instagram.com
+        (needs 'dblclick' event)"
+        https://bugs.webkit.org/show_bug.cgi?id=197347
+        https://trac.webkit.org/changeset/244755
+
 2019-04-29  Alex Christensen  <[email protected]>
 
         <rdar://problem/50299396> Fix internal High Sierra build

Modified: trunk/Source/WebCore/page/Frame.h (244761 => 244762)


--- trunk/Source/WebCore/page/Frame.h	2019-04-29 22:40:48 UTC (rev 244761)
+++ trunk/Source/WebCore/page/Frame.h	2019-04-29 23:55:51 UTC (rev 244762)
@@ -219,7 +219,6 @@
 
     WEBCORE_EXPORT Node* deepestNodeAtLocation(const FloatPoint& viewportLocation);
     WEBCORE_EXPORT Node* nodeRespondingToClickEvents(const FloatPoint& viewportLocation, FloatPoint& adjustedViewportLocation, SecurityOrigin* = nullptr);
-    WEBCORE_EXPORT Node* nodeRespondingToDoubleClickEvent(const FloatPoint& viewportLocation, FloatPoint& adjustedViewportLocation);
     WEBCORE_EXPORT Node* nodeRespondingToScrollWheelEvents(const FloatPoint& viewportLocation);
 
     WEBCORE_EXPORT NSArray *wordsInCurrentParagraph() const;

Modified: trunk/Source/WebCore/page/ios/FrameIOS.mm (244761 => 244762)


--- trunk/Source/WebCore/page/ios/FrameIOS.mm	2019-04-29 22:40:48 UTC (rev 244761)
+++ trunk/Source/WebCore/page/ios/FrameIOS.mm	2019-04-29 23:55:51 UTC (rev 244762)
@@ -418,33 +418,6 @@
     return qualifyingNodeAtViewportLocation(viewportLocation, adjustedViewportLocation, WTFMove(ancestorRespondingToClickEvents), true);
 }
 
-Node* Frame::nodeRespondingToDoubleClickEvent(const FloatPoint& viewportLocation, FloatPoint& adjustedViewportLocation)
-{
-    auto&& ancestorRespondingToDoubleClickEvent = [](const HitTestResult& hitTestResult, Node* terminationNode, IntRect* nodeBounds) -> Node* {
-        if (nodeBounds)
-            *nodeBounds = IntRect();
-
-        auto* node = hitTestResult.innerNode();
-        if (!node)
-            return nullptr;
-
-        for (; node && node != terminationNode; node = node->parentInComposedTree()) {
-            if (!node->hasEventListeners(eventNames().dblclickEvent))
-                continue;
-#if ENABLE(TOUCH_EVENTS)
-            if (!node->allowsDoubleTapGesture())
-                continue;
-#endif
-            if (nodeBounds && node->renderer())
-                *nodeBounds = node->renderer()->absoluteBoundingBoxRect(true);
-            return node;
-        }
-        return nullptr;
-    };
-
-    return qualifyingNodeAtViewportLocation(viewportLocation, adjustedViewportLocation, WTFMove(ancestorRespondingToDoubleClickEvent), true);
-}
-
 Node* Frame::nodeRespondingToScrollWheelEvents(const FloatPoint& viewportLocation)
 {
     auto&& ancestorRespondingToScrollWheelEvents = [](const HitTestResult& hitTestResult, Node* terminationNode, IntRect* nodeBounds) -> Node* {

Modified: trunk/Source/WebKit/ChangeLog (244761 => 244762)


--- trunk/Source/WebKit/ChangeLog	2019-04-29 22:40:48 UTC (rev 244761)
+++ trunk/Source/WebKit/ChangeLog	2019-04-29 23:55:51 UTC (rev 244762)
@@ -1,3 +1,16 @@
+2019-04-29  Truitt Savell  <[email protected]>
+
+        Unreviewed, rolling out r244755.
+
+        Casued several test failures on iOS
+
+        Reverted changeset:
+
+        "Double-tapping a post to like doesn't work on Instagram.com
+        (needs 'dblclick' event)"
+        https://bugs.webkit.org/show_bug.cgi?id=197347
+        https://trac.webkit.org/changeset/244755
+
 2019-04-29  Chris Dumez  <[email protected]>
 
         [iOS] The UIProcess may get killed for trying to stay runnable in the background for more than 30 seconds

Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.h (244761 => 244762)


--- trunk/Source/WebKit/UIProcess/WebPageProxy.h	2019-04-29 22:40:48 UTC (rev 244761)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.h	2019-04-29 23:55:51 UTC (rev 244762)
@@ -1210,7 +1210,6 @@
     void tapHighlightAtPosition(const WebCore::FloatPoint&, uint64_t& requestID);
     void handleTap(const WebCore::FloatPoint&, OptionSet<WebKit::WebEvent::Modifier>, uint64_t layerTreeTransactionIdAtLastTouchStart);
     void didRecognizeLongPress();
-    void handleDoubleTapForDoubleClickAtPoint(const WebCore::IntPoint&, OptionSet<WebEvent::Modifier>, uint64_t layerTreeTransactionIdAtLastTouchStart);
 
     void inspectorNodeSearchMovedToPosition(const WebCore::FloatPoint&);
     void inspectorNodeSearchEndedAtPosition(const WebCore::FloatPoint&);

Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h (244761 => 244762)


--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h	2019-04-29 22:40:48 UTC (rev 244761)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h	2019-04-29 23:55:51 UTC (rev 244762)
@@ -221,7 +221,6 @@
     RetainPtr<UILongPressGestureRecognizer> _longPressGestureRecognizer;
     RetainPtr<WKSyntheticTapGestureRecognizer> _doubleTapGestureRecognizer;
     RetainPtr<UITapGestureRecognizer> _nonBlockingDoubleTapGestureRecognizer;
-    RetainPtr<UITapGestureRecognizer> _doubleTapGestureRecognizerForDoubleClick;
     RetainPtr<UITapGestureRecognizer> _twoFingerDoubleTapGestureRecognizer;
     RetainPtr<UITapGestureRecognizer> _twoFingerSingleTapGestureRecognizer;
     RetainPtr<UITapGestureRecognizer> _stylusSingleTapGestureRecognizer;

Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (244761 => 244762)


--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2019-04-29 22:40:48 UTC (rev 244761)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2019-04-29 23:55:51 UTC (rev 244762)
@@ -734,12 +734,6 @@
     [_nonBlockingDoubleTapGestureRecognizer setEnabled:NO];
     [self addGestureRecognizer:_nonBlockingDoubleTapGestureRecognizer.get()];
 
-    _doubleTapGestureRecognizerForDoubleClick = adoptNS([[UITapGestureRecognizer alloc] initWithTarget:self action:@selector(_doubleTapRecognizedForDoubleClick:)]);
-    [_doubleTapGestureRecognizerForDoubleClick setNumberOfTapsRequired:2];
-    [_doubleTapGestureRecognizerForDoubleClick setDelegate:self];
-    [_doubleTapGestureRecognizerForDoubleClick setEnabled:YES];
-    [self addGestureRecognizer:_doubleTapGestureRecognizerForDoubleClick.get()];
-
     [self _createAndConfigureDoubleTapGestureRecognizer];
 
     _twoFingerDoubleTapGestureRecognizer = adoptNS([[UITapGestureRecognizer alloc] initWithTarget:self action:@selector(_twoFingerDoubleTapRecognized:)]);
@@ -873,9 +867,6 @@
     [_nonBlockingDoubleTapGestureRecognizer setDelegate:nil];
     [self removeGestureRecognizer:_nonBlockingDoubleTapGestureRecognizer.get()];
 
-    [_doubleTapGestureRecognizerForDoubleClick setDelegate:nil];
-    [self removeGestureRecognizer:_doubleTapGestureRecognizerForDoubleClick.get()];
-
     [_twoFingerDoubleTapGestureRecognizer setDelegate:nil];
     [self removeGestureRecognizer:_twoFingerDoubleTapGestureRecognizer.get()];
 
@@ -949,7 +940,6 @@
     [self removeGestureRecognizer:_highlightLongPressGestureRecognizer.get()];
     [self removeGestureRecognizer:_doubleTapGestureRecognizer.get()];
     [self removeGestureRecognizer:_nonBlockingDoubleTapGestureRecognizer.get()];
-    [self removeGestureRecognizer:_doubleTapGestureRecognizerForDoubleClick.get()];
     [self removeGestureRecognizer:_twoFingerDoubleTapGestureRecognizer.get()];
     [self removeGestureRecognizer:_twoFingerSingleTapGestureRecognizer.get()];
     [self removeGestureRecognizer:_stylusSingleTapGestureRecognizer.get()];
@@ -966,7 +956,6 @@
     [self addGestureRecognizer:_highlightLongPressGestureRecognizer.get()];
     [self addGestureRecognizer:_doubleTapGestureRecognizer.get()];
     [self addGestureRecognizer:_nonBlockingDoubleTapGestureRecognizer.get()];
-    [self addGestureRecognizer:_doubleTapGestureRecognizerForDoubleClick.get()];
     [self addGestureRecognizer:_twoFingerDoubleTapGestureRecognizer.get()];
     [self addGestureRecognizer:_twoFingerSingleTapGestureRecognizer.get()];
     [self addGestureRecognizer:_stylusSingleTapGestureRecognizer.get()];
@@ -1790,12 +1779,6 @@
     if (isSamePair(gestureRecognizer, otherGestureRecognizer, _highlightLongPressGestureRecognizer.get(), _nonBlockingDoubleTapGestureRecognizer.get()))
         return YES;
 
-    if (isSamePair(gestureRecognizer, otherGestureRecognizer, _nonBlockingDoubleTapGestureRecognizer.get(), _doubleTapGestureRecognizerForDoubleClick.get()))
-        return YES;
-
-    if (isSamePair(gestureRecognizer, otherGestureRecognizer, _doubleTapGestureRecognizer.get(), _doubleTapGestureRecognizerForDoubleClick.get()))
-        return YES;
-
     if (isSamePair(gestureRecognizer, otherGestureRecognizer, _highlightLongPressGestureRecognizer.get(), _previewSecondaryGestureRecognizer.get()))
         return YES;
 
@@ -1992,7 +1975,6 @@
     if (gestureRecognizer == _highlightLongPressGestureRecognizer
         || gestureRecognizer == _doubleTapGestureRecognizer
         || gestureRecognizer == _nonBlockingDoubleTapGestureRecognizer
-        || gestureRecognizer == _doubleTapGestureRecognizerForDoubleClick
         || gestureRecognizer == _twoFingerDoubleTapGestureRecognizer) {
 
         if (hasFocusedElement(_focusedElementInformation)) {
@@ -2395,11 +2377,6 @@
     _isDoubleTapPending = YES;
 }
 
-- (void)_doubleTapRecognizedForDoubleClick:(UITapGestureRecognizer *)gestureRecognizer
-{
-    _page->handleDoubleTapForDoubleClickAtPoint(WebCore::IntPoint(gestureRecognizer.location), WebKit::webEventModifierFlags(gestureRecognizerModifierFlags(gestureRecognizer)), _layerTreeTransactionIdAtLastTouchStart);
-}
-
 - (void)_twoFingerDoubleTapRecognized:(UITapGestureRecognizer *)gestureRecognizer
 {
     [self _resetIsDoubleTapPending];

Modified: trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm (244761 => 244762)


--- trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm	2019-04-29 22:40:48 UTC (rev 244761)
+++ trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm	2019-04-29 23:55:51 UTC (rev 244762)
@@ -867,11 +867,6 @@
     process().send(Messages::WebPage::DidRecognizeLongPress(), m_pageID);
 }
 
-void WebPageProxy::handleDoubleTapForDoubleClickAtPoint(const WebCore::IntPoint& point, OptionSet<WebEvent::Modifier> modifiers, uint64_t layerTreeTransactionIdAtLastTouchStart)
-{
-    process().send(Messages::WebPage::HandleDoubleTapForDoubleClickAtPoint(point, modifiers, layerTreeTransactionIdAtLastTouchStart), m_pageID);
-}
-
 void WebPageProxy::inspectorNodeSearchMovedToPosition(const WebCore::FloatPoint& position)
 {
     process().send(Messages::WebPage::InspectorNodeSearchMovedToPosition(position), m_pageID);

Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.h (244761 => 244762)


--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.h	2019-04-29 22:40:48 UTC (rev 244761)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.h	2019-04-29 23:55:51 UTC (rev 244762)
@@ -622,7 +622,6 @@
     void cancelPotentialTapInFrame(WebFrame&);
     void tapHighlightAtPosition(uint64_t requestID, const WebCore::FloatPoint&);
     void didRecognizeLongPress();
-    void handleDoubleTapForDoubleClickAtPoint(const WebCore::IntPoint&, OptionSet<WebKit::WebEvent::Modifier>, uint64_t lastLayerTreeTransactionId);
 
     void inspectorNodeSearchMovedToPosition(const WebCore::FloatPoint&);
     void inspectorNodeSearchEndedAtPosition(const WebCore::FloatPoint&);

Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in (244761 => 244762)


--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in	2019-04-29 22:40:48 UTC (rev 244761)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in	2019-04-29 23:55:51 UTC (rev 244762)
@@ -57,7 +57,6 @@
     CancelPotentialTap()
     TapHighlightAtPosition(uint64_t requestID, WebCore::FloatPoint point)
     DidRecognizeLongPress()
-    HandleDoubleTapForDoubleClickAtPoint(WebCore::IntPoint point, OptionSet<WebKit::WebEvent::Modifier> modifiers, uint64_t lastLayerTreeTransactionId)
     InspectorNodeSearchMovedToPosition(WebCore::FloatPoint point)
     InspectorNodeSearchEndedAtPosition(WebCore::FloatPoint point)
     BlurFocusedElement()

Modified: trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm (244761 => 244762)


--- trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm	2019-04-29 22:40:48 UTC (rev 244761)
+++ trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm	2019-04-29 23:55:51 UTC (rev 244762)
@@ -722,28 +722,6 @@
         handleSyntheticClick(*nodeRespondingToClick, adjustedPoint, modifiers);
 }
 
-void WebPage::handleDoubleTapForDoubleClickAtPoint(const IntPoint& point, OptionSet<WebEvent::Modifier> modifiers, uint64_t lastLayerTreeTransactionId)
-{
-    FloatPoint adjustedPoint;
-    auto* nodeRespondingToDoubleClick = m_page->mainFrame().nodeRespondingToDoubleClickEvent(point, adjustedPoint);
-    if (!nodeRespondingToDoubleClick)
-        return;
-
-    auto* frameRespondingToDoubleClick = nodeRespondingToDoubleClick->document().frame();
-    if (!frameRespondingToDoubleClick || lastLayerTreeTransactionId < WebFrame::fromCoreFrame(*frameRespondingToDoubleClick)->firstLayerTreeTransactionIDAfterDidCommitLoad())
-        return;
-
-    bool shiftKey = modifiers.contains(WebEvent::Modifier::ShiftKey);
-    bool ctrlKey = modifiers.contains(WebEvent::Modifier::ControlKey);
-    bool altKey = modifiers.contains(WebEvent::Modifier::AltKey);
-    bool metaKey = modifiers.contains(WebEvent::Modifier::MetaKey);
-    auto roundedAdjustedPoint = roundedIntPoint(adjustedPoint);
-    nodeRespondingToDoubleClick->document().frame()->eventHandler().handleMousePressEvent(PlatformMouseEvent(roundedAdjustedPoint, roundedAdjustedPoint, LeftButton, PlatformEvent::MousePressed, 2, shiftKey, ctrlKey, altKey, metaKey, WallTime::now(), 0, WebCore::NoTap));
-    if (m_isClosed)
-        return;
-    nodeRespondingToDoubleClick->document().frame()->eventHandler().handleMouseReleaseEvent(PlatformMouseEvent(roundedAdjustedPoint, roundedAdjustedPoint, LeftButton, PlatformEvent::MouseReleased, 2, shiftKey, ctrlKey, altKey, metaKey, WallTime::now(), 0, WebCore::NoTap));
-}
-
 void WebPage::requestFocusedElementInformation(WebKit::CallbackID callbackID)
 {
     FocusedElementInformation info;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to