Title: [244768] trunk/Source/WebCore
- Revision
- 244768
- Author
- [email protected]
- Date
- 2019-04-30 07:32:43 -0700 (Tue, 30 Apr 2019)
Log Message
WebCore::StyleColorScheme should not have explicitly-declared copy constructor
https://bugs.webkit.org/show_bug.cgi?id=197412
Reviewed by Don Olmstead.
Either we need to explicitly declare a copy assignment operator here, or the copy
constructor needs to be removed. Having one without the other causes a huge warning spam
with GCC 9. In this case, the copy constructor is redundant because it's identical to an
implicitly-declared copy constructor, so let's just remove it.
* rendering/style/StyleColorScheme.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (244767 => 244768)
--- trunk/Source/WebCore/ChangeLog 2019-04-30 11:00:30 UTC (rev 244767)
+++ trunk/Source/WebCore/ChangeLog 2019-04-30 14:32:43 UTC (rev 244768)
@@ -1,3 +1,17 @@
+2019-04-30 Michael Catanzaro <[email protected]>
+
+ WebCore::StyleColorScheme should not have explicitly-declared copy constructor
+ https://bugs.webkit.org/show_bug.cgi?id=197412
+
+ Reviewed by Don Olmstead.
+
+ Either we need to explicitly declare a copy assignment operator here, or the copy
+ constructor needs to be removed. Having one without the other causes a huge warning spam
+ with GCC 9. In this case, the copy constructor is redundant because it's identical to an
+ implicitly-declared copy constructor, so let's just remove it.
+
+ * rendering/style/StyleColorScheme.h:
+
2019-04-30 Carlos Garcia Campos <[email protected]>
[GTK] Support prefers-color-scheme media query
Modified: trunk/Source/WebCore/rendering/style/StyleColorScheme.h (244767 => 244768)
--- trunk/Source/WebCore/rendering/style/StyleColorScheme.h 2019-04-30 11:00:30 UTC (rev 244767)
+++ trunk/Source/WebCore/rendering/style/StyleColorScheme.h 2019-04-30 14:32:43 UTC (rev 244768)
@@ -36,11 +36,6 @@
public:
StyleColorScheme() { }
- StyleColorScheme(const StyleColorScheme& other)
- : m_colorScheme(other.m_colorScheme)
- , m_allowsTransformations(other.m_allowsTransformations)
- { }
-
StyleColorScheme(OptionSet<ColorScheme> colorScheme, bool allowsTransformations)
: m_colorScheme(colorScheme)
, m_allowsTransformations(allowsTransformations)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
