Title: [244793] branches/safari-607-branch/Source/WebCore
Revision
244793
Author
[email protected]
Date
2019-04-30 12:29:46 -0700 (Tue, 30 Apr 2019)

Log Message

Cherry-pick r244632. rdar://problem/50344188

    Do not restart WebRTC stats timer if backend is stopped
    https://bugs.webkit.org/show_bug.cgi?id=197257
    <rdar://problem/50095879>

    Reviewed by Eric Carlson.

    We used to stop and reschedule the stat gathering timer in case the
    gathering delay is changing. Timer should not be rescheduled if the backend is stopped.

    * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
    (WebCore::LibWebRTCMediaEndpoint::OnStatsDelivered):

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-607-branch/Source/WebCore/ChangeLog (244792 => 244793)


--- branches/safari-607-branch/Source/WebCore/ChangeLog	2019-04-30 18:42:38 UTC (rev 244792)
+++ branches/safari-607-branch/Source/WebCore/ChangeLog	2019-04-30 19:29:46 UTC (rev 244793)
@@ -1,3 +1,36 @@
+2019-04-30  Alan Coon  <[email protected]>
+
+        Cherry-pick r244632. rdar://problem/50344188
+
+    Do not restart WebRTC stats timer if backend is stopped
+    https://bugs.webkit.org/show_bug.cgi?id=197257
+    <rdar://problem/50095879>
+    
+    Reviewed by Eric Carlson.
+    
+    We used to stop and reschedule the stat gathering timer in case the
+    gathering delay is changing. Timer should not be rescheduled if the backend is stopped.
+    
+    * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
+    (WebCore::LibWebRTCMediaEndpoint::OnStatsDelivered):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244632 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2019-04-24  Youenn Fablet  <[email protected]>
+
+            Do not restart WebRTC stats timer if backend is stopped
+            https://bugs.webkit.org/show_bug.cgi?id=197257
+            <rdar://problem/50095879>
+
+            Reviewed by Eric Carlson.
+
+            We used to stop and reschedule the stat gathering timer in case the
+            gathering delay is changing. Timer should not be rescheduled if the backend is stopped.
+
+            * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
+            (WebCore::LibWebRTCMediaEndpoint::OnStatsDelivered):
+
 2019-04-10  Alan Coon  <[email protected]>
 
         Cherry-pick r243841. rdar://problem/49725678

Modified: branches/safari-607-branch/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp (244792 => 244793)


--- branches/safari-607-branch/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp	2019-04-30 18:42:38 UTC (rev 244792)
+++ branches/safari-607-branch/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp	2019-04-30 19:29:46 UTC (rev 244793)
@@ -847,7 +847,7 @@
         m_statsFirstDeliveredTimestamp = timestamp;
 
     callOnMainThread([protectedThis = makeRef(*this), this, timestamp, report] {
-        if (m_statsLogTimer.repeatInterval() != statsLogInterval(timestamp)) {
+        if (m_backend && m_statsLogTimer.repeatInterval() != statsLogInterval(timestamp)) {
             m_statsLogTimer.stop();
             m_statsLogTimer.startRepeating(statsLogInterval(timestamp));
         }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to