Title: [244836] trunk/Source/WebKit
- Revision
- 244836
- Author
- [email protected]
- Date
- 2019-05-01 12:17:05 -0700 (Wed, 01 May 2019)
Log Message
Link Previews that use WKImagePreviewViewController are not always scaled correctly
https://bugs.webkit.org/show_bug.cgi?id=197450
<rdar://problem/50357695>
Reviewed by Wenson Hsieh.
Tell the UIImageView that we create in WKImagePreviewViewController to use
a filling scaling method.
* UIProcess/WKImagePreviewViewController.mm:
(-[WKImagePreviewViewController initWithCGImage:defaultActions:elementInfo:]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (244835 => 244836)
--- trunk/Source/WebKit/ChangeLog 2019-05-01 18:26:13 UTC (rev 244835)
+++ trunk/Source/WebKit/ChangeLog 2019-05-01 19:17:05 UTC (rev 244836)
@@ -1,3 +1,17 @@
+2019-05-01 Dean Jackson <[email protected]>
+
+ Link Previews that use WKImagePreviewViewController are not always scaled correctly
+ https://bugs.webkit.org/show_bug.cgi?id=197450
+ <rdar://problem/50357695>
+
+ Reviewed by Wenson Hsieh.
+
+ Tell the UIImageView that we create in WKImagePreviewViewController to use
+ a filling scaling method.
+
+ * UIProcess/WKImagePreviewViewController.mm:
+ (-[WKImagePreviewViewController initWithCGImage:defaultActions:elementInfo:]):
+
2019-05-01 Darin Adler <[email protected]>
WebKit has too much of its own UTF-8 code and should rely more on ICU's UTF-8 support
Modified: trunk/Source/WebKit/UIProcess/WKImagePreviewViewController.mm (244835 => 244836)
--- trunk/Source/WebKit/UIProcess/WKImagePreviewViewController.mm 2019-05-01 18:26:13 UTC (rev 244835)
+++ trunk/Source/WebKit/UIProcess/WKImagePreviewViewController.mm 2019-05-01 19:17:05 UTC (rev 244836)
@@ -53,6 +53,7 @@
_image = image;
_imageView = adoptNS([[UIImageView alloc] initWithFrame:CGRectZero]);
+ _imageView.get().contentMode = UIViewContentModeScaleAspectFill;
RetainPtr<UIImage> uiImage = adoptNS([[UIImage alloc] initWithCGImage:_image.get()]);
[_imageView setImage:uiImage.get()];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
