Title: [244854] trunk/LayoutTests
Revision
244854
Author
[email protected]
Date
2019-05-01 15:34:03 -0700 (Wed, 01 May 2019)

Log Message

REGRESSION(r244494): editing/pasteboard/5761530-1.html is flaky due to a simple line layout bug
https://bugs.webkit.org/show_bug.cgi?id=197438
<rdar://problem/50348091>

Reviewed by Zalan Bujtas.

Work around the simple line layout bug in the flaky layout test by disabling simple line layout.

* editing/pasteboard/5761530-1.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (244853 => 244854)


--- trunk/LayoutTests/ChangeLog	2019-05-01 22:08:00 UTC (rev 244853)
+++ trunk/LayoutTests/ChangeLog	2019-05-01 22:34:03 UTC (rev 244854)
@@ -1,3 +1,15 @@
+2019-05-01  Wenson Hsieh  <[email protected]>
+
+        REGRESSION(r244494): editing/pasteboard/5761530-1.html is flaky due to a simple line layout bug
+        https://bugs.webkit.org/show_bug.cgi?id=197438
+        <rdar://problem/50348091>
+
+        Reviewed by Zalan Bujtas.
+
+        Work around the simple line layout bug in the flaky layout test by disabling simple line layout.
+
+        * editing/pasteboard/5761530-1.html:
+
 2019-05-01  Ryosuke Niwa  <[email protected]>
 
         [iOS] Element::focus and Element::scrollIntoView do not clamp scroll positions

Modified: trunk/LayoutTests/editing/pasteboard/5761530-1.html (244853 => 244854)


--- trunk/LayoutTests/editing/pasteboard/5761530-1.html	2019-05-01 22:08:00 UTC (rev 244853)
+++ trunk/LayoutTests/editing/pasteboard/5761530-1.html	2019-05-01 22:34:03 UTC (rev 244854)
@@ -1,8 +1,10 @@
 <div id="description">This tests to see that tabs are put into tab spans when they are copied individually.  The pasted tab should be inside of a tab span, not a style span.  To run the test manually, paste and then inspect the editable region, and ensure that there is a tab span at the beginning of the editable div.</div>
 <div id="edit" contenteditable="true"><span class="Apple-tab-span" style="white-space:pre;">	</span>xxx</div>
 <script>
-if (window.testRunner)
-	window.testRunner.dumpAsText();
+if (window.testRunner && window.internals) {
+    window.testRunner.dumpAsText();
+    internals.settings.setSimpleLineLayoutEnabled(false);
+}
 edit = document.getElementById("edit");
 
 window.getSelection().setPosition(edit, 0);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to