Title: [245175] trunk
- Revision
- 245175
- Author
- [email protected]
- Date
- 2019-05-10 09:20:12 -0700 (Fri, 10 May 2019)
Log Message
Event region generation needs to know about backing-sharing
https://bugs.webkit.org/show_bug.cgi?id=197694
<rdar://problem/50584991>
Reviewed by Simon Fraser.
Source/WebCore:
Test: pointerevents/ios/touch-action-region-backing-sharing.html
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateEventRegion):
Gather event region from backing sharing layers too.
LayoutTests:
* platform/ios-wk2/TestExpectations:
* pointerevents/ios/touch-action-region-backing-sharing-expected.txt: Added.
* pointerevents/ios/touch-action-region-backing-sharing.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (245174 => 245175)
--- trunk/LayoutTests/ChangeLog 2019-05-10 16:05:34 UTC (rev 245174)
+++ trunk/LayoutTests/ChangeLog 2019-05-10 16:20:12 UTC (rev 245175)
@@ -1,3 +1,15 @@
+2019-05-10 Antti Koivisto <[email protected]>
+
+ Event region generation needs to know about backing-sharing
+ https://bugs.webkit.org/show_bug.cgi?id=197694
+ <rdar://problem/50584991>
+
+ Reviewed by Simon Fraser.
+
+ * platform/ios-wk2/TestExpectations:
+ * pointerevents/ios/touch-action-region-backing-sharing-expected.txt: Added.
+ * pointerevents/ios/touch-action-region-backing-sharing.html: Added.
+
2019-05-10 Ryan Haddad <[email protected]>
[iOS Debug] Layout Test webgl/2.0.0/conformance2/attribs/gl-vertexattribipointer.html is a flaky timeout
Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (245174 => 245175)
--- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2019-05-10 16:05:34 UTC (rev 245174)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2019-05-10 16:20:12 UTC (rev 245175)
@@ -1076,7 +1076,6 @@
webkit.org/b/153049 perf/array-binary-search.html [ Pass Failure Timeout ]
fast/scrolling/ios/scroll-events-back-forward-after-pageshow.html [ Pass Failure ]
-webkit.org/b/197694 fast/scrolling/ios/overflow-scroll-overlap-4.html [ Failure ]
webkit.org/b/157589 fast/text-autosizing/ios/text-autosizing-after-back.html [ Pass Timeout ]
Added: trunk/LayoutTests/pointerevents/ios/touch-action-region-backing-sharing-expected.txt (0 => 245175)
--- trunk/LayoutTests/pointerevents/ios/touch-action-region-backing-sharing-expected.txt (rev 0)
+++ trunk/LayoutTests/pointerevents/ios/touch-action-region-backing-sharing-expected.txt 2019-05-10 16:20:12 UTC (rev 245175)
@@ -0,0 +1,57 @@
+(GraphicsLayer
+ (anchor 0.00 0.00)
+ (bounds 800.00 600.00)
+ (deep color 1)
+ (children 1
+ (GraphicsLayer
+ (bounds 800.00 600.00)
+ (contentsOpaque 1)
+ (event region
+ (rect (0,0) width=800 height=600)
+ )
+ (deep color 1)
+ (children 2
+ (GraphicsLayer
+ (position 8.00 13.00)
+ (bounds 200.00 200.00)
+ (event region
+ (rect (0,0) width=500 height=500)
+ )
+ (deep color 1)
+ (children 1
+ (GraphicsLayer
+ (bounds 200.00 200.00)
+ (children 1
+ (GraphicsLayer
+ (anchor 0.00 0.00)
+ (bounds 500.00 500.00)
+ (drawsContent 1)
+ (deep color 1)
+ )
+ )
+ )
+ )
+ )
+ (GraphicsLayer
+ (position 8.00 13.00)
+ (bounds 150.00 150.00)
+ (drawsContent 1)
+ (event region
+ (rect (0,0) width=100 height=50)
+ (rect (0,50) width=150 height=50)
+ (rect (50,100) width=100 height=50)
+ (touch-action
+ (none
+ (rect (0,0) width=100 height=50)
+ (rect (0,50) width=150 height=50)
+ (rect (50,100) width=100 height=50)
+ )
+ )
+ )
+ (deep color 1)
+ )
+ )
+ )
+ )
+)
+
Added: trunk/LayoutTests/pointerevents/ios/touch-action-region-backing-sharing.html (0 => 245175)
--- trunk/LayoutTests/pointerevents/ios/touch-action-region-backing-sharing.html (rev 0)
+++ trunk/LayoutTests/pointerevents/ios/touch-action-region-backing-sharing.html 2019-05-10 16:20:12 UTC (rev 245175)
@@ -0,0 +1,21 @@
+<!DOCTYPE html> <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->
+<html>
+<style>
+.scroll { position:absolute; width:200px; height:200px; overflow:scroll }
+.scrollcontent { width:500px; height:500px; background:green; }
+.overlap { position:absolute; width:100px; height:100px; background:blue; touch-action: none; }
+</style>
+<body>
+<div class="scroll"><div class="scrollcontent"></div></div>
+<div class="overlap">
+ <div class="overlap" style="left:50px; top:50px"></div>
+</div>
+<pre id="results"></pre>
+<script>
+if (window.testRunner)
+ testRunner.dumpAsText();
+if (window.internals)
+ results.innerText = internals.layerTreeAsText(document, internals.LAYER_TREE_INCLUDES_EVENT_REGION);
+</script>
+</body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (245174 => 245175)
--- trunk/Source/WebCore/ChangeLog 2019-05-10 16:05:34 UTC (rev 245174)
+++ trunk/Source/WebCore/ChangeLog 2019-05-10 16:20:12 UTC (rev 245175)
@@ -1,3 +1,18 @@
+2019-05-10 Antti Koivisto <[email protected]>
+
+ Event region generation needs to know about backing-sharing
+ https://bugs.webkit.org/show_bug.cgi?id=197694
+ <rdar://problem/50584991>
+
+ Reviewed by Simon Fraser.
+
+ Test: pointerevents/ios/touch-action-region-backing-sharing.html
+
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::updateEventRegion):
+
+ Gather event region from backing sharing layers too.
+
2019-05-10 Michael Catanzaro <[email protected]>
[WPE][GTK] Add WebKitWebPage::did-associate-form-controls-for-frame and deprecate original did-associate-form-controls
Modified: trunk/Source/WebCore/rendering/RenderLayerBacking.cpp (245174 => 245175)
--- trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2019-05-10 16:05:34 UTC (rev 245174)
+++ trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2019-05-10 16:20:12 UTC (rev 245175)
@@ -1493,6 +1493,9 @@
auto paintFlags = RenderLayer::paintLayerPaintingCompositingAllPhasesFlags() | RenderLayer::PaintLayerCollectingEventRegion;
m_owningLayer.paintLayerContents(nullContext, paintingInfo, paintFlags);
+ for (auto& layerWeakPtr : m_backingSharingLayers)
+ layerWeakPtr->paintLayerContents(nullContext, paintingInfo, paintFlags);
+
auto contentOffset = roundedIntSize(contentOffsetInCompositingLayer());
eventRegion.translate(contentOffset);
m_graphicsLayer->setEventRegion(WTFMove(eventRegion));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
