Diff
Modified: trunk/Source/ThirdParty/ANGLE/CMakeLists.txt (245178 => 245179)
--- trunk/Source/ThirdParty/ANGLE/CMakeLists.txt 2019-05-10 17:19:24 UTC (rev 245178)
+++ trunk/Source/ThirdParty/ANGLE/CMakeLists.txt 2019-05-10 18:03:56 UTC (rev 245179)
@@ -149,7 +149,11 @@
endif ()
if (COMPILER_IS_GCC_OR_CLANG)
- WEBKIT_ADD_TARGET_CXX_FLAGS(ANGLE -Wno-cast-align -Wno-unused-parameter)
+ WEBKIT_ADD_TARGET_CXX_FLAGS(ANGLE -Wno-cast-align
+ -Wno-suggest-attribute=format
+ -Wno-type-limits
+ -Wno-undef
+ -Wno-unused-parameter)
endif ()
target_link_libraries(ANGLEFramework INTERFACE ANGLE)
Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (245178 => 245179)
--- trunk/Source/ThirdParty/ANGLE/ChangeLog 2019-05-10 17:19:24 UTC (rev 245178)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog 2019-05-10 18:03:56 UTC (rev 245179)
@@ -1,3 +1,14 @@
+2019-05-10 Michael Catanzaro <[email protected]>
+
+ Fix a bunch of compiler warnings
+ https://bugs.webkit.org/show_bug.cgi?id=197785
+
+ Reviewed by Don Olmstead.
+
+ Add compiler flags to suppress various warnings triggered by the new version of ANGLE.
+
+ * CMakeLists.txt:
+
2019-05-09 Don Olmstead <[email protected]>
[ANGLE] Update ANGLE
Modified: trunk/Source/WebCore/CMakeLists.txt (245178 => 245179)
--- trunk/Source/WebCore/CMakeLists.txt 2019-05-10 17:19:24 UTC (rev 245178)
+++ trunk/Source/WebCore/CMakeLists.txt 2019-05-10 18:03:56 UTC (rev 245179)
@@ -1972,7 +1972,7 @@
add_dependencies(WebCoreTestSupport WebCore WebCoreTestSupportBindings)
target_include_directories(WebCoreTestSupport PUBLIC ${WebCoreTestSupport_INCLUDE_DIRECTORIES} ${WebCore_INCLUDE_DIRECTORIES})
target_include_directories(WebCoreTestSupport PRIVATE ${WebCoreTestSupport_PRIVATE_INCLUDE_DIRECTORIES} ${WebCore_PRIVATE_INCLUDE_DIRECTORIES})
-target_include_directories(WebCoreTestSupport SYSTEM PUBLIC ${WebCore_SYSTEM_INCLUDE_DIRECTORIES})
+target_include_directories(WebCoreTestSupport SYSTEM PUBLIC ${WebCoreTestSupport_SYSTEM_INCLUDE_DIRECTORIES} ${WebCore_SYSTEM_INCLUDE_DIRECTORIES})
target_link_libraries(WebCoreTestSupport PRIVATE ${WebCoreTestSupport_LIBRARIES})
if (WebCoreTestSupport_OUTPUT_NAME)
Modified: trunk/Source/WebCore/ChangeLog (245178 => 245179)
--- trunk/Source/WebCore/ChangeLog 2019-05-10 17:19:24 UTC (rev 245178)
+++ trunk/Source/WebCore/ChangeLog 2019-05-10 18:03:56 UTC (rev 245179)
@@ -1,3 +1,16 @@
+2019-05-10 Michael Catanzaro <[email protected]>
+
+ Fix a bunch of compiler warnings
+ https://bugs.webkit.org/show_bug.cgi?id=197785
+
+ Reviewed by Don Olmstead.
+
+ * CMakeLists.txt: WebCoreTestSupport should accept extra SYSTEM includes.
+ * PlatformGTK.cmake: GTK includes should be added to SYSTEM headers to avoid warnings.
+ * inspector/InspectorCanvas.cpp: Add preprocessor guards to fix unused function warning.
+ * rendering/RenderLayer.cpp: Fix unused variable warning.
+ (WebCore::RenderLayer::updateClipRects):
+
2019-05-10 Antti Koivisto <[email protected]>
Event region generation needs to know about backing-sharing
Modified: trunk/Source/WebCore/PlatformGTK.cmake (245178 => 245179)
--- trunk/Source/WebCore/PlatformGTK.cmake 2019-05-10 17:19:24 UTC (rev 245178)
+++ trunk/Source/WebCore/PlatformGTK.cmake 2019-05-10 18:03:56 UTC (rev 245179)
@@ -214,7 +214,7 @@
)
list(APPEND WebCoreTestSupport_LIBRARIES PRIVATE ${GTK_LIBRARIES})
-list(APPEND WebCoreTestSupport_INCLUDE_DIRECTORIES ${GTK_INCLUDE_DIRS})
+list(APPEND WebCoreTestSupport_SYSTEM_INCLUDE_DIRECTORIES ${GTK_INCLUDE_DIRS})
add_definitions(-DBUILDING_WEBKIT)
Modified: trunk/Source/WebCore/inspector/InspectorCanvas.cpp (245178 => 245179)
--- trunk/Source/WebCore/inspector/InspectorCanvas.cpp 2019-05-10 17:19:24 UTC (rev 245178)
+++ trunk/Source/WebCore/inspector/InspectorCanvas.cpp 2019-05-10 18:03:56 UTC (rev 245179)
@@ -138,6 +138,7 @@
return name == "transferFromImageBitmap";
}
+#if ENABLE(WEBGL)
static bool shouldSnapshotWebGLAction(const String& name)
{
return name == "clear"
@@ -144,7 +145,9 @@
|| name == "drawArrays"
|| name == "drawElements";
}
+#endif
+#if ENABLE(WEBGL2)
static bool shouldSnapshotWebGL2Action(const String& name)
{
return name == "clear"
@@ -153,6 +156,7 @@
|| name == "drawElements"
|| name == "drawElementsInstanced";
}
+#endif
void InspectorCanvas::recordAction(const String& name, Vector<RecordCanvasActionVariant>&& parameters)
{
Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (245178 => 245179)
--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2019-05-10 17:19:24 UTC (rev 245178)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2019-05-10 18:03:56 UTC (rev 245179)
@@ -5500,7 +5500,7 @@
RefPtr<ClipRects> parentClipRects;
// For transformed layers, the root layer was shifted to be us, so there is no need to
// examine the parent. We want to cache clip rects with us as the root.
- if (auto* parentLayer = (clipRectsContext.rootLayer != this ? parent() : nullptr))
+ if (clipRectsContext.rootLayer != this && parent())
parentClipRects = this->parentClipRects(clipRectsContext);
auto clipRects = ClipRects::create();
Modified: trunk/Source/WebKit/ChangeLog (245178 => 245179)
--- trunk/Source/WebKit/ChangeLog 2019-05-10 17:19:24 UTC (rev 245178)
+++ trunk/Source/WebKit/ChangeLog 2019-05-10 18:03:56 UTC (rev 245179)
@@ -1,3 +1,15 @@
+2019-05-10 Michael Catanzaro <[email protected]>
+
+ Fix a bunch of compiler warnings
+ https://bugs.webkit.org/show_bug.cgi?id=197785
+
+ Reviewed by Don Olmstead.
+
+ Guard Cocoa-specific format modifier to avoid -Wformat warning.
+
+ * NetworkProcess/AdClickAttributionManager.cpp:
+ (WebKit::AdClickAttributionManager::fireConversionRequest):
+
2019-05-10 Chris Fleizach <[email protected]>
AX: Crash at WebKit: WebKit::WebSpeechSynthesisClient::speak
Modified: trunk/Source/WebKit/NetworkProcess/AdClickAttributionManager.cpp (245178 => 245179)
--- trunk/Source/WebKit/NetworkProcess/AdClickAttributionManager.cpp 2019-05-10 17:19:24 UTC (rev 245178)
+++ trunk/Source/WebKit/NetworkProcess/AdClickAttributionManager.cpp 2019-05-10 18:03:56 UTC (rev 245179)
@@ -181,7 +181,11 @@
RELEASE_LOG_INFO_IF(debugModeEnabled(), AdClickAttribution, "About to fire an attribution request for a conversion.");
m_pingLoadFunction(WTFMove(loadParameters), [](const WebCore::ResourceError& error, const WebCore::ResourceResponse& response) {
+#if PLATFORM(COCOA)
RELEASE_LOG_ERROR_IF(!error.isNull(), AdClickAttribution, "Received error: '%{public}s' for ad click attribution request.", error.localizedDescription().utf8().data());
+#else
+ RELEASE_LOG_ERROR_IF(!error.isNull(), AdClickAttribution, "Received error: '%s' for ad click attribution request.", error.localizedDescription().utf8().data());
+#endif
UNUSED_PARAM(response);
UNUSED_PARAM(error);
});
Modified: trunk/Tools/ChangeLog (245178 => 245179)
--- trunk/Tools/ChangeLog 2019-05-10 17:19:24 UTC (rev 245178)
+++ trunk/Tools/ChangeLog 2019-05-10 18:03:56 UTC (rev 245179)
@@ -1,5 +1,18 @@
2019-05-10 Michael Catanzaro <[email protected]>
+ Fix a bunch of compiler warnings
+ https://bugs.webkit.org/show_bug.cgi?id=197785
+
+ Reviewed by Don Olmstead.
+
+ Add preprocessor guards to avoid -Wunused-function warnings.
+
+ * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
+ * TestWebKitAPI/Tests/WebCore/IntRect.cpp:
+ * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
+
+2019-05-10 Michael Catanzaro <[email protected]>
+
[WPE][GTK] Add webkit_frame_get_id() API
https://bugs.webkit.org/show_bug.cgi?id=197270
Modified: trunk/Tools/TestWebKitAPI/Tests/WebCore/FloatRect.cpp (245178 => 245179)
--- trunk/Tools/TestWebKitAPI/Tests/WebCore/FloatRect.cpp 2019-05-10 17:19:24 UTC (rev 245178)
+++ trunk/Tools/TestWebKitAPI/Tests/WebCore/FloatRect.cpp 2019-05-10 18:03:56 UTC (rev 245179)
@@ -603,6 +603,7 @@
EXPECT_FLOAT_EQ(190.0f, rect.maxY());
}
+#if USE(CG) || PLATFORM(WIN)
static void checkCastRect(const WebCore::FloatRect& rect)
{
EXPECT_FLOAT_EQ(10.0f, rect.x());
@@ -612,6 +613,7 @@
EXPECT_FLOAT_EQ(30.0f, rect.width());
EXPECT_FLOAT_EQ(40.0f, rect.height());
}
+#endif
TEST(FloatRect, Casting)
{
Modified: trunk/Tools/TestWebKitAPI/Tests/WebCore/IntRect.cpp (245178 => 245179)
--- trunk/Tools/TestWebKitAPI/Tests/WebCore/IntRect.cpp 2019-05-10 17:19:24 UTC (rev 245178)
+++ trunk/Tools/TestWebKitAPI/Tests/WebCore/IntRect.cpp 2019-05-10 18:03:56 UTC (rev 245179)
@@ -481,6 +481,7 @@
EXPECT_EQ(120, transposed.maxY());
}
+#if USE(CG) || PLATFORM(WIN)
static void checkCastRect(const WebCore::IntRect& rect)
{
EXPECT_EQ(10, rect.x());
@@ -490,6 +491,7 @@
EXPECT_EQ(30, rect.width());
EXPECT_EQ(40, rect.height());
}
+#endif
TEST(IntRect, Casting)
{
@@ -584,6 +586,7 @@
ASSERT_FALSE(rect == rightSide);
}
+#if USE(CG)
static void checkEnclosingIntRect(const WebCore::IntRect& rect)
{
EXPECT_EQ(10, rect.x());
@@ -593,6 +596,7 @@
EXPECT_EQ(31, rect.width());
EXPECT_EQ(41, rect.height());
}
+#endif
TEST(IntRect, EnclosingIntRect)
{
Modified: trunk/Tools/TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp (245178 => 245179)
--- trunk/Tools/TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp 2019-05-10 17:19:24 UTC (rev 245178)
+++ trunk/Tools/TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp 2019-05-10 18:03:56 UTC (rev 245179)
@@ -1187,6 +1187,7 @@
ASSERT_TRUE(test3 != test4);
}
+#if USE(CA)
static void testTranslationMatrix(const WebCore::TransformationMatrix& matrix)
{
EXPECT_DOUBLE_EQ(1.0, matrix.m11());
@@ -1206,6 +1207,7 @@
EXPECT_DOUBLE_EQ(30.0, matrix.m43());
EXPECT_DOUBLE_EQ(1.0, matrix.m44());
}
+#endif
TEST(TransformationMatrix, Casting)
{
