Title: [245197] trunk/Source/WebCore
- Revision
- 245197
- Author
- [email protected]
- Date
- 2019-05-10 14:36:45 -0700 (Fri, 10 May 2019)
Log Message
Downgrade RELEASE_ASSERT TO RELEASE_LOG_FAULT for SQLite Class A files
https://bugs.webkit.org/show_bug.cgi?id=197760
Reviewed by Jer Noble.
We have all the data we need, and this crash is happening more than
expected.
* platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::open):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (245196 => 245197)
--- trunk/Source/WebCore/ChangeLog 2019-05-10 21:28:06 UTC (rev 245196)
+++ trunk/Source/WebCore/ChangeLog 2019-05-10 21:36:45 UTC (rev 245197)
@@ -1,3 +1,16 @@
+2019-05-09 Geoffrey Garen <[email protected]>
+
+ Downgrade RELEASE_ASSERT TO RELEASE_LOG_FAULT for SQLite Class A files
+ https://bugs.webkit.org/show_bug.cgi?id=197760
+
+ Reviewed by Jer Noble.
+
+ We have all the data we need, and this crash is happening more than
+ expected.
+
+ * platform/sql/SQLiteDatabase.cpp:
+ (WebCore::SQLiteDatabase::open):
+
2019-05-10 Zalan Bujtas <[email protected]>
[iOS] baidu.com: Synthetic bold renders too far apart, appears doubled.
Modified: trunk/Source/WebCore/platform/sql/SQLiteDatabase.cpp (245196 => 245197)
--- trunk/Source/WebCore/platform/sql/SQLiteDatabase.cpp 2019-05-10 21:28:06 UTC (rev 245196)
+++ trunk/Source/WebCore/platform/sql/SQLiteDatabase.cpp 2019-05-10 21:36:45 UTC (rev 245197)
@@ -150,8 +150,11 @@
useWALJournalMode();
String shmFileName = makeString(filename, "-shm"_s);
- if (FileSystem::fileExists(shmFileName))
- RELEASE_ASSERT(FileSystem::isSafeToUseMemoryMapForPath(shmFileName));
+ if (FileSystem::fileExists(shmFileName)) {
+ if (!FileSystem::isSafeToUseMemoryMapForPath(shmFileName))
+ RELEASE_LOG_FAULT(SQLDatabase, "Opened an SQLite database with a Class A -shm file. This may trigger a crash when the user locks the device. (%s)", shmFileName.latin1().data());
+ FileSystem::makeSafeToUseMemoryMapForPath(shmFileName);
+ }
return isOpen();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
