Title: [245202] trunk/Source/WTF
Revision
245202
Author
[email protected]
Date
2019-05-10 17:39:58 -0700 (Fri, 10 May 2019)

Log Message

Bag's move operator= leaks memory
https://bugs.webkit.org/show_bug.cgi?id=197757

Reviewed by Keith Miller.

It was unused. So I'm just removing it. We can implement it properly
if we ever need it.

* wtf/Bag.h:
(WTF::Bag::operator=): Deleted.

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (245201 => 245202)


--- trunk/Source/WTF/ChangeLog	2019-05-10 23:42:53 UTC (rev 245201)
+++ trunk/Source/WTF/ChangeLog	2019-05-11 00:39:58 UTC (rev 245202)
@@ -1,3 +1,16 @@
+2019-05-10  Saam barati  <[email protected]>
+
+        Bag's move operator= leaks memory
+        https://bugs.webkit.org/show_bug.cgi?id=197757
+
+        Reviewed by Keith Miller.
+
+        It was unused. So I'm just removing it. We can implement it properly
+        if we ever need it.
+
+        * wtf/Bag.h:
+        (WTF::Bag::operator=): Deleted.
+
 2019-05-10  Fujii Hironori  <[email protected]>
 
         [WinCairo] storage/indexeddb tests are timing out

Modified: trunk/Source/WTF/wtf/Bag.h (245201 => 245202)


--- trunk/Source/WTF/wtf/Bag.h	2019-05-10 23:42:53 UTC (rev 245201)
+++ trunk/Source/WTF/wtf/Bag.h	2019-05-11 00:39:58 UTC (rev 245202)
@@ -65,14 +65,6 @@
         other.m_head = nullptr;
     }
 
-    template<typename U>
-    Bag& operator=(Bag<T, U>&& other)
-    {
-        m_head = other.unwrappedHead();
-        other.m_head = nullptr;
-        return *this;
-    }
-    
     ~Bag()
     {
         clear();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to