Title: [245244] trunk/Source
Revision
245244
Author
[email protected]
Date
2019-05-13 12:38:32 -0700 (Mon, 13 May 2019)

Log Message

Use kDNSServiceFlagsKnownUnique for DNSServiceRegisterRecord only on platforms supporting it
https://bugs.webkit.org/show_bug.cgi?id=197802

Reviewed by Eric Carlson.

Source/WebKit:

* NetworkProcess/webrtc/NetworkMDNSRegister.cpp:
(WebKit::NetworkMDNSRegister::registerMDNSName):

Source/WTF:

* wtf/Platform.h:

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (245243 => 245244)


--- trunk/Source/WTF/ChangeLog	2019-05-13 19:09:04 UTC (rev 245243)
+++ trunk/Source/WTF/ChangeLog	2019-05-13 19:38:32 UTC (rev 245244)
@@ -1,3 +1,12 @@
+2019-05-13  Youenn Fablet  <[email protected]>
+
+        Use kDNSServiceFlagsKnownUnique for DNSServiceRegisterRecord only on platforms supporting it
+        https://bugs.webkit.org/show_bug.cgi?id=197802
+
+        Reviewed by Eric Carlson.
+
+        * wtf/Platform.h:
+
 2019-05-13  Yusuke Suzuki  <[email protected]>
 
         [JSC] Compress miscelaneous JIT related data structures with Packed<>

Modified: trunk/Source/WTF/wtf/Platform.h (245243 => 245244)


--- trunk/Source/WTF/wtf/Platform.h	2019-05-13 19:09:04 UTC (rev 245243)
+++ trunk/Source/WTF/wtf/Platform.h	2019-05-13 19:38:32 UTC (rev 245244)
@@ -1511,6 +1511,10 @@
 #define HAVE_SANDBOX_ISSUE_MACH_EXTENSION_TO_PROCESS_BY_PID 1
 #endif
 
+#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500) || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000)
+#define HAVE_MDNS_FAST_REGISTRATION 1
+#endif
+
 #if PLATFORM(MAC)
 #define ENABLE_MONOSPACE_FONT_EXCEPTION (__MAC_OS_X_VERSION_MIN_REQUIRED < 101500)
 #elif PLATFORM(IOS_FAMILY)

Modified: trunk/Source/WebKit/ChangeLog (245243 => 245244)


--- trunk/Source/WebKit/ChangeLog	2019-05-13 19:09:04 UTC (rev 245243)
+++ trunk/Source/WebKit/ChangeLog	2019-05-13 19:38:32 UTC (rev 245244)
@@ -1,3 +1,13 @@
+2019-05-13  Youenn Fablet  <[email protected]>
+
+        Use kDNSServiceFlagsKnownUnique for DNSServiceRegisterRecord only on platforms supporting it
+        https://bugs.webkit.org/show_bug.cgi?id=197802
+
+        Reviewed by Eric Carlson.
+
+        * NetworkProcess/webrtc/NetworkMDNSRegister.cpp:
+        (WebKit::NetworkMDNSRegister::registerMDNSName):
+
 2019-05-13  Don Olmstead  <[email protected]>
 
         decidePolicyForInstallMissingMediaPluginsPermissionRequest requires GStreamer

Modified: trunk/Source/WebKit/NetworkProcess/webrtc/NetworkMDNSRegister.cpp (245243 => 245244)


--- trunk/Source/WebKit/NetworkProcess/webrtc/NetworkMDNSRegister.cpp	2019-05-13 19:09:04 UTC (rev 245243)
+++ trunk/Source/WebKit/NetworkProcess/webrtc/NetworkMDNSRegister.cpp	2019-05-13 19:38:32 UTC (rev 245244)
@@ -139,7 +139,11 @@
     auto* record = &pendingRequest->record;
     auto error = DNSServiceRegisterRecord(service,
         record,
-        kDNSServiceFlagsUnique | kDNSServiceFlagsKnownUnique,
+#if HAVE(MDNS_FAST_REGISTRATION)
+        kDNSServiceFlagsKnownUnique,
+#else
+        kDNSServiceFlagsUnique,
+#endif
         0,
         pendingRequest->name.utf8().data(),
         kDNSServiceType_A,
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to