Title: [245253] trunk/Source/WebCore
- Revision
- 245253
- Author
- [email protected]
- Date
- 2019-05-13 14:52:35 -0700 (Mon, 13 May 2019)
Log Message
Downgrade RELEASE_ASSERT TO RELEASE_LOG_FAULT for SQLite Class A files
https://bugs.webkit.org/show_bug.cgi?id=197760
Reviewed by Jer Noble.
Only makeSafeToUseMemoryMapForPath() if needed. (Fixed missing brace.)
* platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::open):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (245252 => 245253)
--- trunk/Source/WebCore/ChangeLog 2019-05-13 21:48:09 UTC (rev 245252)
+++ trunk/Source/WebCore/ChangeLog 2019-05-13 21:52:35 UTC (rev 245253)
@@ -1,3 +1,15 @@
+2019-05-13 Geoffrey Garen <[email protected]>
+
+ Downgrade RELEASE_ASSERT TO RELEASE_LOG_FAULT for SQLite Class A files
+ https://bugs.webkit.org/show_bug.cgi?id=197760
+
+ Reviewed by Jer Noble.
+
+ Only makeSafeToUseMemoryMapForPath() if needed. (Fixed missing brace.)
+
+ * platform/sql/SQLiteDatabase.cpp:
+ (WebCore::SQLiteDatabase::open):
+
2019-05-13 Tadeu Zagallo <[email protected]>
JSObject::getOwnPropertyDescriptor is missing an exception check
Modified: trunk/Source/WebCore/platform/sql/SQLiteDatabase.cpp (245252 => 245253)
--- trunk/Source/WebCore/platform/sql/SQLiteDatabase.cpp 2019-05-13 21:48:09 UTC (rev 245252)
+++ trunk/Source/WebCore/platform/sql/SQLiteDatabase.cpp 2019-05-13 21:52:35 UTC (rev 245253)
@@ -151,9 +151,10 @@
String shmFileName = makeString(filename, "-shm"_s);
if (FileSystem::fileExists(shmFileName)) {
- if (!FileSystem::isSafeToUseMemoryMapForPath(shmFileName))
+ if (!FileSystem::isSafeToUseMemoryMapForPath(shmFileName)) {
RELEASE_LOG_FAULT(SQLDatabase, "Opened an SQLite database with a Class A -shm file. This may trigger a crash when the user locks the device. (%s)", shmFileName.latin1().data());
FileSystem::makeSafeToUseMemoryMapForPath(shmFileName);
+ }
}
return isOpen();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
