[webkit-changes] [245272] trunk/Source/WebKit

Mon, 13 May 2019 21:16:02 -0700

Title: [245272] trunk/Source/WebKit
Revision
245272
Author
[email protected]
Date
2019-05-13 21:14:59 -0700 (Mon, 13 May 2019)

Log Message

Followup to r245267: fix some more deprecated uses of -[UIApplication interfaceOrientation]
https://bugs.webkit.org/show_bug.cgi?id=197867
<rdar://problem/50743963>

Reviewed by Simon Fraser.

Add a helper method on WKContentView that asks the view's window's scene for an interface orientation; then,
use this helper from various places in WebKit instead of invoking -[UIApplication interfaceOrientation]
directly. No change in behavior.

* UIProcess/ios/WKContentView.h:
* UIProcess/ios/WKContentView.mm:
(-[WKContentView interfaceOrientation]):
* UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm:
(-[WKDataListSuggestionsPicker initWithInformation:inView:]):
* UIProcess/ios/forms/WKFormColorPicker.mm:
(-[WKColorPicker initWithView:]):
* UIProcess/ios/forms/WKFormInputControl.mm:
(-[WKDateTimePicker initWithView:datePickerMode:]):
* UIProcess/ios/forms/WKFormSelectPicker.mm:
(-[WKMultipleSelectPicker initWithView:]):
* UIProcess/ios/forms/WKFormSelectPopover.mm:
(-[WKSelectPopover initWithView:hasGroups:]):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (245271 => 245272)


--- trunk/Source/WebKit/ChangeLog	2019-05-14 03:38:13 UTC (rev 245271)
+++ trunk/Source/WebKit/ChangeLog	2019-05-14 04:14:59 UTC (rev 245272)
@@ -1,5 +1,31 @@
 2019-05-13  Wenson Hsieh  <[email protected]>
 
+        Followup to r245267: fix some more deprecated uses of -[UIApplication interfaceOrientation]
+        https://bugs.webkit.org/show_bug.cgi?id=197867
+        <rdar://problem/50743963>
+
+        Reviewed by Simon Fraser.
+
+        Add a helper method on WKContentView that asks the view's window's scene for an interface orientation; then,
+        use this helper from various places in WebKit instead of invoking -[UIApplication interfaceOrientation]
+        directly. No change in behavior.
+
+        * UIProcess/ios/WKContentView.h:
+        * UIProcess/ios/WKContentView.mm:
+        (-[WKContentView interfaceOrientation]):
+        * UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm:
+        (-[WKDataListSuggestionsPicker initWithInformation:inView:]):
+        * UIProcess/ios/forms/WKFormColorPicker.mm:
+        (-[WKColorPicker initWithView:]):
+        * UIProcess/ios/forms/WKFormInputControl.mm:
+        (-[WKDateTimePicker initWithView:datePickerMode:]):
+        * UIProcess/ios/forms/WKFormSelectPicker.mm:
+        (-[WKMultipleSelectPicker initWithView:]):
+        * UIProcess/ios/forms/WKFormSelectPopover.mm:
+        (-[WKSelectPopover initWithView:hasGroups:]):
+
+2019-05-13  Wenson Hsieh  <[email protected]>
+
         [iOS] When running layout tests that tap in the same location, subsequent tests fail to fire click handlers
         https://bugs.webkit.org/show_bug.cgi?id=197821
         <rdar://problem/50700512>

Modified: trunk/Source/WebKit/UIProcess/ios/WKContentView.h (245271 => 245272)


--- trunk/Source/WebKit/UIProcess/ios/WKContentView.h	2019-05-14 03:38:13 UTC (rev 245271)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentView.h	2019-05-14 04:14:59 UTC (rev 245272)
@@ -67,6 +67,7 @@
 @property (nonatomic, getter=isShowingInspectorIndication) BOOL showingInspectorIndication;
 @property (nonatomic, readonly, getter=isResigningFirstResponder) BOOL resigningFirstResponder;
 @property (nonatomic) BOOL sizeChangedSinceLastVisibleContentRectUpdate;
+@property (nonatomic, readonly) UIInterfaceOrientation interfaceOrientation;
 
 - (instancetype)initWithFrame:(CGRect)frame processPool:(WebKit::WebProcessPool&)processPool configuration:(Ref<API::PageConfiguration>&&)configuration webView:(WKWebView *)webView;

Modified: trunk/Source/WebKit/UIProcess/ios/WKContentView.mm (245271 => 245272)


--- trunk/Source/WebKit/UIProcess/ios/WKContentView.mm	2019-05-14 03:38:13 UTC (rev 245271)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentView.mm	2019-05-14 04:14:59 UTC (rev 245272)
@@ -545,6 +545,15 @@
     return _undoManager.get();
 }
 
+- (UIInterfaceOrientation)interfaceOrientation
+{
+#if HAVE(UISCENE)
+    return self.window.windowScene.interfaceOrientation;
+#else
+    return UIApp.interfaceOrientation;
+#endif
+}
+
 #pragma mark Internal
 
 - (void)_windowDidMoveToScreenNotification:(NSNotification *)notification

Modified: trunk/Source/WebKit/UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm (245271 => 245272)


--- trunk/Source/WebKit/UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm	2019-05-14 03:38:13 UTC (rev 245271)
+++ trunk/Source/WebKit/UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm	2019-05-14 04:14:59 UTC (rev 245272)
@@ -211,12 +211,7 @@
     [_pickerView setDataSource:self];
     [_pickerView setDelegate:self];
     [_pickerView setControl:self];
-#if HAVE(UISCENE)
-    auto interfaceOrientation = view.window.windowScene.interfaceOrientation;
-#else
-    auto interfaceOrientation = UIApp.interfaceOrientation;
-#endif
-    [_pickerView setSize:[UIKeyboard defaultSizeForInterfaceOrientation:interfaceOrientation]];
+    [_pickerView setSize:[UIKeyboard defaultSizeForInterfaceOrientation:view.interfaceOrientation]];
 
     return self;
 }

Modified: trunk/Source/WebKit/UIProcess/ios/forms/WKFormColorPicker.mm (245271 => 245272)


--- trunk/Source/WebKit/UIProcess/ios/forms/WKFormColorPicker.mm	2019-05-14 03:38:13 UTC (rev 245271)
+++ trunk/Source/WebKit/UIProcess/ios/forms/WKFormColorPicker.mm	2019-05-14 04:14:59 UTC (rev 245272)
@@ -179,7 +179,7 @@
     if (currentUserInterfaceIdiomIsPad())
         colorPickerSize = CGSizeMake(pickerWidthForPopover, pickerWidthForPopover);
     else {
-        CGSize keyboardSize = [UIKeyboard defaultSizeForInterfaceOrientation:[UIApp interfaceOrientation]];
+        auto keyboardSize = [UIKeyboard defaultSizeForInterfaceOrientation:view.interfaceOrientation];
         colorPickerSize = CGSizeMake(keyboardSize.width, keyboardSize.height + additionalKeyboardAffordance);
     }

Modified: trunk/Source/WebKit/UIProcess/ios/forms/WKFormInputControl.mm (245271 => 245272)


--- trunk/Source/WebKit/UIProcess/ios/forms/WKFormInputControl.mm	2019-05-14 03:38:13 UTC (rev 245271)
+++ trunk/Source/WebKit/UIProcess/ios/forms/WKFormInputControl.mm	2019-05-14 04:14:59 UTC (rev 245272)
@@ -106,7 +106,7 @@
         break;
    }
 
-    CGSize size = currentUserInterfaceIdiomIsPad() ? [UIPickerView defaultSizeForCurrentOrientation] : [UIKeyboard defaultSizeForInterfaceOrientation:[UIApp interfaceOrientation]];
+    auto size = currentUserInterfaceIdiomIsPad() ? [UIPickerView defaultSizeForCurrentOrientation] : [UIKeyboard defaultSizeForInterfaceOrientation:view.interfaceOrientation];
 
     _datePicker = adoptNS([[UIDatePicker alloc] initWithFrame:CGRectMake(0, 0, size.width, size.height)]);
     _datePicker.get().datePickerMode = mode;

Modified: trunk/Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm (245271 => 245272)


--- trunk/Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm	2019-05-14 03:38:13 UTC (rev 245271)
+++ trunk/Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm	2019-05-14 04:14:59 UTC (rev 245272)
@@ -161,7 +161,7 @@
     ALLOW_DEPRECATED_DECLARATIONS_END
 
     [self setAllowsMultipleSelection:_allowsMultipleSelection];
-    [self setSize:[UIKeyboard defaultSizeForInterfaceOrientation:[UIApp interfaceOrientation]]];
+    [self setSize:[UIKeyboard defaultSizeForInterfaceOrientation:view.interfaceOrientation]];
     [self reloadAllComponents];
 
     if (!_allowsMultipleSelection) {

Modified: trunk/Source/WebKit/UIProcess/ios/forms/WKFormSelectPopover.mm (245271 => 245272)


--- trunk/Source/WebKit/UIProcess/ios/forms/WKFormSelectPopover.mm	2019-05-14 03:38:13 UTC (rev 245271)
+++ trunk/Source/WebKit/UIProcess/ios/forms/WKFormSelectPopover.mm	2019-05-14 04:14:59 UTC (rev 245272)
@@ -395,7 +395,7 @@
     
     CGRect frame;
     frame.origin = CGPointZero;
-    frame.size = [UIKeyboard defaultSizeForInterfaceOrientation:[UIApp interfaceOrientation]];
+    frame.size = [UIKeyboard defaultSizeForInterfaceOrientation:view.interfaceOrientation];
 
     _tableViewController = adoptNS([[WKSelectTableViewController alloc] initWithView:view hasGroups:hasGroups]);
     [_tableViewController setPopover:self];

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to