Title: [245282] trunk/Tools
- Revision
- 245282
- Author
- [email protected]
- Date
- 2019-05-14 09:18:24 -0700 (Tue, 14 May 2019)
Log Message
[ews-app] Status bubble should turn orange when any build step fails
https://bugs.webkit.org/show_bug.cgi?id=197812
Reviewed by Jonathan Bedard.
* BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
(StatusBubble._build_bubble): Turn status-bubble orange if there is any failed step in the on-going build.
(StatusBubble._does_build_contains_any_failed_step): Method to check if build contains any failed step.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py (245281 => 245282)
--- trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py 2019-05-14 15:49:35 UTC (rev 245281)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py 2019-05-14 16:18:24 UTC (rev 245282)
@@ -71,7 +71,10 @@
builder_full_name = build.builder_name.replace('-', ' ')
if build.result is None: # In-progress build
- bubble['state'] = 'started'
+ if self._does_build_contains_any_failed_step(build):
+ bubble['state'] = 'provisional-fail'
+ else:
+ bubble['state'] = 'started'
bubble['details_message'] = 'Build is in-progress. Recent messages:\n\n' + self._steps_messages(build)
elif build.result == Buildbot.SUCCESS:
if is_parent_build:
@@ -150,6 +153,12 @@
def _should_display_step(self, step):
return not filter(lambda step_to_hide: re.search(step_to_hide, step.state_string), StatusBubble.STEPS_TO_HIDE)
+ def _does_build_contains_any_failed_step(self, build):
+ for step in build.step_set.all():
+ if step.result and step.result != Buildbot.SUCCESS:
+ return True
+ return False
+
def _most_recent_step_message(self, build):
recent_step = build.step_set.last()
if not recent_step:
Modified: trunk/Tools/ChangeLog (245281 => 245282)
--- trunk/Tools/ChangeLog 2019-05-14 15:49:35 UTC (rev 245281)
+++ trunk/Tools/ChangeLog 2019-05-14 16:18:24 UTC (rev 245282)
@@ -1,3 +1,14 @@
+2019-05-14 Aakash Jain <[email protected]>
+
+ [ews-app] Status bubble should turn orange when any build step fails
+ https://bugs.webkit.org/show_bug.cgi?id=197812
+
+ Reviewed by Jonathan Bedard.
+
+ * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
+ (StatusBubble._build_bubble): Turn status-bubble orange if there is any failed step in the on-going build.
+ (StatusBubble._does_build_contains_any_failed_step): Method to check if build contains any failed step.
+
2019-05-14 Alex Christensen <[email protected]>
Add a unit test for client certificate authentication
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
