Title: [245298] trunk/Source/WebKit
- Revision
- 245298
- Author
- [email protected]
- Date
- 2019-05-14 12:48:09 -0700 (Tue, 14 May 2019)
Log Message
Crash under WebKit::WebProcessProxy::didBecomeUnresponsive()
https://bugs.webkit.org/show_bug.cgi?id=197883
<rdar://problem/50665984>
Reviewed by Alex Christensen.
Protect |this| in didBecomeUnresponsive() and didExceedCPULimit() since we call client
delegates and those may cause |this| to get destroyed.
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didBecomeUnresponsive):
(WebKit::WebProcessProxy::didExceedCPULimit):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (245297 => 245298)
--- trunk/Source/WebKit/ChangeLog 2019-05-14 19:32:17 UTC (rev 245297)
+++ trunk/Source/WebKit/ChangeLog 2019-05-14 19:48:09 UTC (rev 245298)
@@ -1,5 +1,20 @@
2019-05-14 Chris Dumez <[email protected]>
+ Crash under WebKit::WebProcessProxy::didBecomeUnresponsive()
+ https://bugs.webkit.org/show_bug.cgi?id=197883
+ <rdar://problem/50665984>
+
+ Reviewed by Alex Christensen.
+
+ Protect |this| in didBecomeUnresponsive() and didExceedCPULimit() since we call client
+ delegates and those may cause |this| to get destroyed.
+
+ * UIProcess/WebProcessProxy.cpp:
+ (WebKit::WebProcessProxy::didBecomeUnresponsive):
+ (WebKit::WebProcessProxy::didExceedCPULimit):
+
+2019-05-14 Chris Dumez <[email protected]>
+
The network process tries to take a process assertion when NetworkProcess::processWillSuspendImminently() is called
https://bugs.webkit.org/show_bug.cgi?id=197888
Modified: trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp (245297 => 245298)
--- trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp 2019-05-14 19:32:17 UTC (rev 245297)
+++ trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp 2019-05-14 19:48:09 UTC (rev 245298)
@@ -713,6 +713,8 @@
void WebProcessProxy::didBecomeUnresponsive()
{
+ auto protectedThis = makeRef(*this);
+
m_isResponsive = NoOrMaybe::No;
auto isResponsiveCallbacks = WTFMove(m_isResponsiveCallbacks);
@@ -1322,6 +1324,8 @@
void WebProcessProxy::didExceedCPULimit()
{
+ auto protectedThis = makeRef(*this);
+
for (auto& page : pages()) {
if (page->isPlayingAudio()) {
RELEASE_LOG(PerformanceLogging, "%p - WebProcessProxy::didExceedCPULimit() WebProcess with pid %d has exceeded the background CPU limit but we are not terminating it because there is audio playing", this, processIdentifier());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
