Title: [245302] trunk/Source/WebCore
- Revision
- 245302
- Author
- [email protected]
- Date
- 2019-05-14 13:35:32 -0700 (Tue, 14 May 2019)
Log Message
[WHLSL] parseEffectfulAssignment should not call parseCallExpression directly
https://bugs.webkit.org/show_bug.cgi?id=197890
Reviewed by Myles Maxfield.
callExpression already appears in effSuffix which is in effPrefix which is in effAssignment, so having it directly in effAssignment as well is useless (and ambiguous).
I've already fixed the grammar (https://github.com/gpuweb/WHLSL/commit/a07005f4d692fe3370618dca5db218992b362049), the grammar was always good, this patch is fixing the parser.
* Modules/webgpu/WHLSL/WHLSLParser.cpp:
(WebCore::WHLSL::Parser::parseEffectfulAssignment):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (245301 => 245302)
--- trunk/Source/WebCore/ChangeLog 2019-05-14 20:30:38 UTC (rev 245301)
+++ trunk/Source/WebCore/ChangeLog 2019-05-14 20:35:32 UTC (rev 245302)
@@ -1,3 +1,16 @@
+2019-05-14 Robin Morisset <[email protected]>
+
+ [WHLSL] parseEffectfulAssignment should not call parseCallExpression directly
+ https://bugs.webkit.org/show_bug.cgi?id=197890
+
+ Reviewed by Myles Maxfield.
+
+ callExpression already appears in effSuffix which is in effPrefix which is in effAssignment, so having it directly in effAssignment as well is useless (and ambiguous).
+ I've already fixed the grammar (https://github.com/gpuweb/WHLSL/commit/a07005f4d692fe3370618dca5db218992b362049), the grammar was always good, this patch is fixing the parser.
+
+ * Modules/webgpu/WHLSL/WHLSLParser.cpp:
+ (WebCore::WHLSL::Parser::parseEffectfulAssignment):
+
2019-05-14 Ross Kirsling <[email protected]>
Unreviewed restoration of non-unified build.
Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.cpp (245301 => 245302)
--- trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.cpp 2019-05-14 20:30:38 UTC (rev 245301)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.cpp 2019-05-14 20:35:32 UTC (rev 245302)
@@ -1803,12 +1803,6 @@
if (assignment)
return assignment;
- assignment = backtrackingScope<Expected<UniqueRef<AST::_expression_>, Error>>([&]() {
- return parseCallExpression();
- });
- if (assignment)
- return assignment;
-
return Unexpected<Error>(assignment.error());
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
