Title: [245312] trunk/Source/WebCore
- Revision
- 245312
- Author
- [email protected]
- Date
- 2019-05-14 14:49:54 -0700 (Tue, 14 May 2019)
Log Message
[WHLSL] parseEffectfulSuffix() is never called
https://bugs.webkit.org/show_bug.cgi?id=195864
<rdar://problem/50746278>
Reviewed by Myles C. Maxfield.
The fix is trivial: when parseEffectfulPrefix does not see a ++ or --, it must call parseEffectfulSuffix.
No test yet, as it is not testable until the property resolver is finished.
It will be tested with the rest of the compiler, when we port the testsuite from the js implementation (it already covers this case).
* Modules/webgpu/WHLSL/WHLSLParser.cpp:
(WebCore::WHLSL::Parser::parseEffectfulPrefix):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (245311 => 245312)
--- trunk/Source/WebCore/ChangeLog 2019-05-14 21:38:12 UTC (rev 245311)
+++ trunk/Source/WebCore/ChangeLog 2019-05-14 21:49:54 UTC (rev 245312)
@@ -1,5 +1,21 @@
2019-05-14 Robin Morisset <[email protected]>
+ [WHLSL] parseEffectfulSuffix() is never called
+ https://bugs.webkit.org/show_bug.cgi?id=195864
+ <rdar://problem/50746278>
+
+ Reviewed by Myles C. Maxfield.
+
+ The fix is trivial: when parseEffectfulPrefix does not see a ++ or --, it must call parseEffectfulSuffix.
+
+ No test yet, as it is not testable until the property resolver is finished.
+ It will be tested with the rest of the compiler, when we port the testsuite from the js implementation (it already covers this case).
+
+ * Modules/webgpu/WHLSL/WHLSLParser.cpp:
+ (WebCore::WHLSL::Parser::parseEffectfulPrefix):
+
+2019-05-14 Robin Morisset <[email protected]>
+
[WHLSL] parseEffectfulAssignment should not call parseCallExpression directly
https://bugs.webkit.org/show_bug.cgi?id=197890
Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.cpp (245311 => 245312)
--- trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.cpp 2019-05-14 21:38:12 UTC (rev 245311)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.cpp 2019-05-14 21:49:54 UTC (rev 245312)
@@ -1810,7 +1810,7 @@
{
auto prefix = consumeTypes({ Lexer::Token::Type::PlusPlus, Lexer::Token::Type::MinusMinus });
if (!prefix)
- return Unexpected<Error>(prefix.error());
+ return parseEffectfulSuffix();
auto previous = parsePossiblePrefix();
if (!previous)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
