Title: [245316] trunk/LayoutTests
- Revision
- 245316
- Author
- [email protected]
- Date
- 2019-05-14 21:00:05 -0700 (Tue, 14 May 2019)
Log Message
Fix flakey test fast/events/autoscroll-when-input-is-offscreen.html
https://bugs.webkit.org/show_bug.cgi?id=197897
<rdar://problem/50306931>
Reviewed by Wenson Hsieh.
Programmatic scrolls are included in the transaction and we want to
ensure that they've been applied. Then we can be sure that the page
has finished scrolling and it's appropriate to test the page offset.
* fast/events/autoscroll-when-input-is-offscreen.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (245315 => 245316)
--- trunk/LayoutTests/ChangeLog 2019-05-14 22:55:20 UTC (rev 245315)
+++ trunk/LayoutTests/ChangeLog 2019-05-15 04:00:05 UTC (rev 245316)
@@ -1,3 +1,17 @@
+2019-05-14 Megan Gardner <[email protected]>
+
+ Fix flakey test fast/events/autoscroll-when-input-is-offscreen.html
+ https://bugs.webkit.org/show_bug.cgi?id=197897
+ <rdar://problem/50306931>
+
+ Reviewed by Wenson Hsieh.
+
+ Programmatic scrolls are included in the transaction and we want to
+ ensure that they've been applied. Then we can be sure that the page
+ has finished scrolling and it's appropriate to test the page offset.
+
+ * fast/events/autoscroll-when-input-is-offscreen.html:
+
2019-05-14 Shawn Roberts <[email protected]>
storage/indexeddb/modern/deletedatabase-2-private.html is a flaky failure
Modified: trunk/LayoutTests/fast/events/autoscroll-when-input-is-offscreen.html (245315 => 245316)
--- trunk/LayoutTests/fast/events/autoscroll-when-input-is-offscreen.html 2019-05-14 22:55:20 UTC (rev 245315)
+++ trunk/LayoutTests/fast/events/autoscroll-when-input-is-offscreen.html 2019-05-15 04:00:05 UTC (rev 245316)
@@ -19,11 +19,11 @@
await UIHelper.setHardwareKeyboardAttached(false);
await UIHelper.activateElementAndWaitForInputSession(document.getElementById('editable'));
- var programaticScroll = 500;
- document.scrollingElement.scrollTop = programaticScroll;
+ var programmaticScroll = 500;
+ document.scrollingElement.scrollTop = programmaticScroll;
await UIHelper.enterText("Test");
-
- if (window.pageYOffset < programaticScroll)
+ await UIHelper.ensurePresentationUpdate();
+ if (window.pageYOffset < programmaticScroll)
output += 'PASS: page has scrolled back to the top to show the element that has text being entered into it.';
else
output += 'FAIL: page has failed to scroll when entering text into a form that is offscreen.';
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
