Title: [245322] trunk
- Revision
- 245322
- Author
- [email protected]
- Date
- 2019-05-15 07:55:11 -0700 (Wed, 15 May 2019)
Log Message
Allow NSFileCoordinator to be called from WebContent process
https://bugs.webkit.org/show_bug.cgi?id=197895
<rdar://problem/50107679>
Patch by Alex Christensen <[email protected]> on 2019-05-15
Reviewed by Brent Fulgham.
Source/WebKit:
* WebProcess/com.apple.WebProcess.sb.in:
Expand sandbox to allow use of com.apple.FileCoordination mach service like we do on iOS.
Tools:
Add a unit test that verifies calling the block succeeds.
* TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm:
(-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (245321 => 245322)
--- trunk/Source/WebKit/ChangeLog 2019-05-15 10:22:47 UTC (rev 245321)
+++ trunk/Source/WebKit/ChangeLog 2019-05-15 14:55:11 UTC (rev 245322)
@@ -1,3 +1,14 @@
+2019-05-15 Alex Christensen <[email protected]>
+
+ Allow NSFileCoordinator to be called from WebContent process
+ https://bugs.webkit.org/show_bug.cgi?id=197895
+ <rdar://problem/50107679>
+
+ Reviewed by Brent Fulgham.
+
+ * WebProcess/com.apple.WebProcess.sb.in:
+ Expand sandbox to allow use of com.apple.FileCoordination mach service like we do on iOS.
+
2019-05-15 Devin Rousso <[email protected]>
Web Automation: elements larger than the viewport have incorrect in-view center point
Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (245321 => 245322)
--- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2019-05-15 10:22:47 UTC (rev 245321)
+++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in 2019-05-15 14:55:11 UTC (rev 245322)
@@ -593,6 +593,9 @@
(allow mach-lookup
(global-name "com.apple.webinspector"))
+(allow mach-lookup
+ (global-name "com.apple.FileCoordination"))
+
;; Various services required by AppKit and other frameworks
(allow mach-lookup
#if __MAC_OS_X_VERSION_MIN_REQUIRED < 101400
@@ -986,6 +989,9 @@
(syscall-number SYS_quotactl) ;; <rdar://problem/49945031>
(syscall-number SYS_stat64_extended) ;; <rdar://problem/50473330>
(syscall-number SYS_lstat64_extended)
+ (syscall-number SYS_iopolicysys)
+ (syscall-number SYS_workq_open)
+ (syscall-number SYS_getgroups)
)
)
Modified: trunk/Tools/ChangeLog (245321 => 245322)
--- trunk/Tools/ChangeLog 2019-05-15 10:22:47 UTC (rev 245321)
+++ trunk/Tools/ChangeLog 2019-05-15 14:55:11 UTC (rev 245322)
@@ -1,3 +1,16 @@
+2019-05-15 Alex Christensen <[email protected]>
+
+ Allow NSFileCoordinator to be called from WebContent process
+ https://bugs.webkit.org/show_bug.cgi?id=197895
+ <rdar://problem/50107679>
+
+ Reviewed by Brent Fulgham.
+
+ Add a unit test that verifies calling the block succeeds.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm:
+ (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
+
2019-05-14 Andy Estes <[email protected]>
[Apple Pay] Payment APIs should be completely disabled in web views into which clients have injected user scripts
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm (245321 => 245322)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm 2019-05-15 10:22:47 UTC (rev 245321)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm 2019-05-15 14:55:11 UTC (rev 245322)
@@ -52,6 +52,13 @@
_interface = [_WKRemoteObjectInterface remoteObjectInterfaceWithProtocol:@protocol(AdditionalReadAccessAllowedURLsProtocol)];
[[browserContextController _remoteObjectRegistry] registerExportedObject:self interface:_interface.get()];
+
+ __block bool blockCalled = false;
+ NSFileCoordinator *coordinator = [[NSFileCoordinator alloc] initWithFilePresenter:nil];
+ [coordinator coordinateReadingItemAtURL:[NSURL fileURLWithPath:@"/Applications/Safari.app"] options:NSFileCoordinatorReadingWithoutChanges error:nil byAccessor:^(NSURL *newURL) {
+ blockCalled = true;
+ }];
+ ASSERT(blockCalled);
}
- (void)dealloc
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
