Title: [245397] branches/safari-607-branch/Source/WebCore
Revision
245397
Author
[email protected]
Date
2019-05-16 08:36:33 -0700 (Thu, 16 May 2019)

Log Message

Cherry-pick r244632. rdar://problem/50344384

    Do not restart WebRTC stats timer if backend is stopped
    https://bugs.webkit.org/show_bug.cgi?id=197257
    <rdar://problem/50095879>

    Reviewed by Eric Carlson.

    We used to stop and reschedule the stat gathering timer in case the
    gathering delay is changing. Timer should not be rescheduled if the backend is stopped.

    * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
    (WebCore::LibWebRTCMediaEndpoint::OnStatsDelivered):

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-607-branch/Source/WebCore/ChangeLog (245396 => 245397)


--- branches/safari-607-branch/Source/WebCore/ChangeLog	2019-05-16 13:54:56 UTC (rev 245396)
+++ branches/safari-607-branch/Source/WebCore/ChangeLog	2019-05-16 15:36:33 UTC (rev 245397)
@@ -1,3 +1,36 @@
+2019-05-16  Kocsen Chung  <[email protected]>
+
+        Cherry-pick r244632. rdar://problem/50344384
+
+    Do not restart WebRTC stats timer if backend is stopped
+    https://bugs.webkit.org/show_bug.cgi?id=197257
+    <rdar://problem/50095879>
+    
+    Reviewed by Eric Carlson.
+    
+    We used to stop and reschedule the stat gathering timer in case the
+    gathering delay is changing. Timer should not be rescheduled if the backend is stopped.
+    
+    * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
+    (WebCore::LibWebRTCMediaEndpoint::OnStatsDelivered):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244632 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2019-04-24  Youenn Fablet  <[email protected]>
+
+            Do not restart WebRTC stats timer if backend is stopped
+            https://bugs.webkit.org/show_bug.cgi?id=197257
+            <rdar://problem/50095879>
+
+            Reviewed by Eric Carlson.
+
+            We used to stop and reschedule the stat gathering timer in case the
+            gathering delay is changing. Timer should not be rescheduled if the backend is stopped.
+
+            * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
+            (WebCore::LibWebRTCMediaEndpoint::OnStatsDelivered):
+
 2019-05-15  Kocsen Chung  <[email protected]>
 
         Apply patch. rdar://problem/50352476

Modified: branches/safari-607-branch/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp (245396 => 245397)


--- branches/safari-607-branch/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp	2019-05-16 13:54:56 UTC (rev 245396)
+++ branches/safari-607-branch/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp	2019-05-16 15:36:33 UTC (rev 245397)
@@ -847,7 +847,7 @@
         m_statsFirstDeliveredTimestamp = timestamp;
 
     callOnMainThread([protectedThis = makeRef(*this), this, timestamp, report] {
-        if (m_statsLogTimer.repeatInterval() != statsLogInterval(timestamp)) {
+        if (m_backend && m_statsLogTimer.repeatInterval() != statsLogInterval(timestamp)) {
             m_statsLogTimer.stop();
             m_statsLogTimer.startRepeating(statsLogInterval(timestamp));
         }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to