Modified: branches/safari-607.2.1.2-branch/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp (245403 => 245404)
--- branches/safari-607.2.1.2-branch/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp 2019-05-16 19:22:47 UTC (rev 245403)
+++ branches/safari-607.2.1.2-branch/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp 2019-05-16 19:33:40 UTC (rev 245404)
@@ -1708,8 +1708,7 @@
return srcDst;
}
-template<typename EqOp>
-RegisterID* BytecodeGenerator::emitEqualityOp(RegisterID* dst, RegisterID* src1, RegisterID* src2)
+bool BytecodeGenerator::emitEqualityOpImpl(RegisterID* dst, RegisterID* src1, RegisterID* src2)
{
if (!canDoPeepholeOptimization())
return false;
@@ -1724,48 +1723,47 @@
if (value == "undefined") {
rewind();
OpIsUndefined::emit(this, dst, op.m_value);
- return dst;
+ return true;
}
if (value == "boolean") {
rewind();
OpIsBoolean::emit(this, dst, op.m_value);
- return dst;
+ return true;
}
if (value == "number") {
rewind();
OpIsNumber::emit(this, dst, op.m_value);
- return dst;
+ return true;
}
if (value == "string") {
rewind();
OpIsCellWithType::emit(this, dst, op.m_value, StringType);
- return dst;
+ return true;
}
if (value == "symbol") {
rewind();
OpIsCellWithType::emit(this, dst, op.m_value, SymbolType);
- return dst;
+ return true;
}
if (Options::useBigInt() && value == "bigint") {
rewind();
OpIsCellWithType::emit(this, dst, op.m_value, BigIntType);
- return dst;
+ return true;
}
if (value == "object") {
rewind();
OpIsObjectOrNull::emit(this, dst, op.m_value);
- return dst;
+ return true;
}
if (value == "function") {
rewind();
OpIsFunction::emit(this, dst, op.m_value);
- return dst;
+ return true;
}
}
}
- EqOp::emit(this, dst, src1, src2);
- return dst;
+ return false;
}
void BytecodeGenerator::emitTypeProfilerExpressionInfo(const JSTextPosition& startDivot, const JSTextPosition& endDivot)
Modified: branches/safari-607.2.1.2-branch/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h (245403 => 245404)
--- branches/safari-607.2.1.2-branch/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h 2019-05-16 19:22:47 UTC (rev 245403)
+++ branches/safari-607.2.1.2-branch/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h 2019-05-16 19:33:40 UTC (rev 245404)
@@ -711,7 +711,15 @@
RegisterID* emitBinaryOp(OpcodeID, RegisterID* dst, RegisterID* src1, RegisterID* src2, OperandTypes);
template<typename EqOp>
- RegisterID* emitEqualityOp(RegisterID* dst, RegisterID* src1, RegisterID* src2);
+ RegisterID* emitEqualityOp(RegisterID* dst, RegisterID* src1, RegisterID* src2)
+ {
+ if (!emitEqualityOpImpl(dst, src1, src2))
+ EqOp::emit(this, dst, src1, src2);
+ return dst;
+ }
+
+ bool emitEqualityOpImpl(RegisterID* dst, RegisterID* src1, RegisterID* src2);
+
RegisterID* emitCreateThis(RegisterID* dst);
void emitTDZCheck(RegisterID* target);
bool needsTDZCheck(const Variable&);
