Title: [245419] trunk/Tools
- Revision
- 245419
- Author
- ddkil...@apple.com
- Date
- 2019-05-16 16:24:10 -0700 (Thu, 16 May 2019)
Log Message
REGRESSION (r84160): Leak of OpaqueJSString under WTR::JSTestRunner::pathToLocalResource (32 bytes) in com.apple.WebKit.WebContent running layout tests
<https://webkit.org/b/197965>
Reviewed by Joseph Pecoraro.
* WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
(WTR::TestRunner::pathToLocalResource): Don't call
JSStringRetain() here because the JSRetainPtr<JSStringRef>
return type will increment the retain count for us.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (245418 => 245419)
--- trunk/Tools/ChangeLog 2019-05-16 23:08:46 UTC (rev 245418)
+++ trunk/Tools/ChangeLog 2019-05-16 23:24:10 UTC (rev 245419)
@@ -1,3 +1,15 @@
+2019-05-16 David Kilzer <ddkil...@apple.com>
+
+ REGRESSION (r84160): Leak of OpaqueJSString under WTR::JSTestRunner::pathToLocalResource (32 bytes) in com.apple.WebKit.WebContent running layout tests
+ <https://webkit.org/b/197965>
+
+ Reviewed by Joseph Pecoraro.
+
+ * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
+ (WTR::TestRunner::pathToLocalResource): Don't call
+ JSStringRetain() here because the JSRetainPtr<JSStringRef>
+ return type will increment the retain count for us.
+
2019-05-16 Alex Christensen <achristen...@webkit.org>
Add a unit test for client certificate authentication
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm (245418 => 245419)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm 2019-05-16 23:08:46 UTC (rev 245418)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm 2019-05-16 23:24:10 UTC (rev 245419)
@@ -38,7 +38,7 @@
JSRetainPtr<JSStringRef> TestRunner::pathToLocalResource(JSStringRef url)
{
- return JSStringRetain(url); // Do nothing on mac.
+ return url; // Do nothing on Cocoa.
}
JSRetainPtr<JSStringRef> TestRunner::inspectorTestStubURL()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
