Title: [245420] branches/safari-608.1.24-branch
- Revision
- 245420
- Author
- kocsen_ch...@apple.com
- Date
- 2019-05-16 16:27:28 -0700 (Thu, 16 May 2019)
Log Message
Revert r245220. rdar://problem/50686229
Modified Paths
Removed Paths
Diff
Modified: branches/safari-608.1.24-branch/LayoutTests/ChangeLog (245419 => 245420)
--- branches/safari-608.1.24-branch/LayoutTests/ChangeLog 2019-05-16 23:24:10 UTC (rev 245419)
+++ branches/safari-608.1.24-branch/LayoutTests/ChangeLog 2019-05-16 23:27:28 UTC (rev 245420)
@@ -1,3 +1,7 @@
+2019-05-16 Kocsen Chung <kocsen_ch...@apple.com>
+
+ Revert r245220. rdar://problem/50686229
+
2019-05-15 Kocsen Chung <kocsen_ch...@apple.com>
Cherry-pick r245220. rdar://problem/50686229
Deleted: branches/safari-608.1.24-branch/LayoutTests/compositing/shared-backing/overflow-scroll/repaint-shared-on-scroll-expected.html (245419 => 245420)
--- branches/safari-608.1.24-branch/LayoutTests/compositing/shared-backing/overflow-scroll/repaint-shared-on-scroll-expected.html 2019-05-16 23:24:10 UTC (rev 245419)
+++ branches/safari-608.1.24-branch/LayoutTests/compositing/shared-backing/overflow-scroll/repaint-shared-on-scroll-expected.html 2019-05-16 23:27:28 UTC (rev 245420)
@@ -1,40 +0,0 @@
-<!DOCTYPE html> <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->
-<html>
-<head>
- <style>
- .scrollable {
- overflow-y: scroll;
- height: 300px;
- width: 300px;
- margin: 10px;
- border: 1px solid black;
- }
-
- .box.sharing {
- background-color: blue;
- }
-
- .box {
- position: relative;
- top: 50px;
- left: 50px;
- width: 180px;
- height: 180px;
- background-color: green;
- }
-
- .spacer {
- height: 500px;
- }
- </style>
-</head>
-<body>
- <div class="scrollable">
- <div class="sharing box">
- <div class="inner box"></div>
- </div>
- <div class="spacer"></div>
- </div>
-</body>
-</html>
-
Deleted: branches/safari-608.1.24-branch/LayoutTests/compositing/shared-backing/overflow-scroll/repaint-shared-on-scroll.html (245419 => 245420)
--- branches/safari-608.1.24-branch/LayoutTests/compositing/shared-backing/overflow-scroll/repaint-shared-on-scroll.html 2019-05-16 23:24:10 UTC (rev 245419)
+++ branches/safari-608.1.24-branch/LayoutTests/compositing/shared-backing/overflow-scroll/repaint-shared-on-scroll.html 2019-05-16 23:27:28 UTC (rev 245420)
@@ -1,57 +0,0 @@
-<!DOCTYPE html> <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->
-<html>
-<head>
- <title>Tests repaints of shared backing when the sharing layers change</title>
- <style>
- .scrollable {
- overflow-y: scroll;
- height: 300px;
- width: 300px;
- margin: 10px;
- border: 1px solid black;
- }
-
- .box.sharing {
- background-color: blue;
- }
-
- .box {
- position: relative;
- top: 50px;
- left: 50px;
- width: 180px;
- height: 180px;
- background-color: green;
- }
-
- .spacer {
- height: 500px;
- }
- </style>
- <script>
- if (window.testRunner)
- testRunner.waitUntilDone();
-
- window.addEventListener('load', () => {
- let scroller = document.querySelector('.scrollable');
- requestAnimationFrame(() => {
- scroller.scrollTop = 250;
- requestAnimationFrame(() => {
- scroller.scrollTop = 0;
- if (window.testRunner)
- testRunner.notifyDone();
- });
- });
- }, false);
- </script>
-</head>
-<body>
- <div class="scrollable">
- <div class="sharing box">
- <div class="inner box"></div>
- </div>
- <div class="spacer"></div>
- </div>
-</body>
-</html>
-
Modified: branches/safari-608.1.24-branch/Source/WebCore/ChangeLog (245419 => 245420)
--- branches/safari-608.1.24-branch/Source/WebCore/ChangeLog 2019-05-16 23:24:10 UTC (rev 245419)
+++ branches/safari-608.1.24-branch/Source/WebCore/ChangeLog 2019-05-16 23:27:28 UTC (rev 245420)
@@ -1,3 +1,7 @@
+2019-05-16 Kocsen Chung <kocsen_ch...@apple.com>
+
+ Revert r245220. rdar://problem/50686229
+
2019-05-15 Kocsen Chung <kocsen_ch...@apple.com>
Cherry-pick r245220. rdar://problem/50686229
Modified: branches/safari-608.1.24-branch/Source/WebCore/rendering/RenderLayerBacking.cpp (245419 => 245420)
--- branches/safari-608.1.24-branch/Source/WebCore/rendering/RenderLayerBacking.cpp 2019-05-16 23:24:10 UTC (rev 245419)
+++ branches/safari-608.1.24-branch/Source/WebCore/rendering/RenderLayerBacking.cpp 2019-05-16 23:27:28 UTC (rev 245420)
@@ -281,10 +281,6 @@
void RenderLayerBacking::setBackingSharingLayers(Vector<WeakPtr<RenderLayer>>&& sharingLayers)
{
clearBackingSharingLayerProviders(m_backingSharingLayers);
-
- if (sharingLayers != m_backingSharingLayers)
- setContentsNeedDisplay(); // This could be optimize to only repaint rects for changed layers.
-
m_backingSharingLayers = WTFMove(sharingLayers);
for (auto& layerWeakPtr : m_backingSharingLayers)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
