Title: [245474] trunk
Revision
245474
Author
[email protected]
Date
2019-05-17 12:29:17 -0700 (Fri, 17 May 2019)

Log Message

Re-enable generate-xcfilelists
https://bugs.webkit.org/show_bug.cgi?id=197933
<rdar://problem/50831677>

Reviewed by Jonathan Bedard.

The following two tasks have been completed, and we can re-enable
generate-xcfilelists:

Bug 197619 <rdar://problem/50507392> Temporarily disable generate-xcfilelists (197619)
Bug 197622 <rdar://problem/50508222> Rewrite generate-xcfilelists in Python (197622)

Source/_javascript_Core:

* Scripts/check-xcfilelists.sh:

Source/WebCore:

No new tests -- no change in user-visible functionality.

* Scripts/check-xcfilelists.sh:

Source/WebKit:

* Scripts/check-xcfilelists.sh:

Tools:

* DumpRenderTree/Scripts/check-xcfilelists.sh:
* WebKitTestRunner/Scripts/check-xcfilelists.sh:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (245473 => 245474)


--- trunk/Source/_javascript_Core/ChangeLog	2019-05-17 19:05:01 UTC (rev 245473)
+++ trunk/Source/_javascript_Core/ChangeLog	2019-05-17 19:29:17 UTC (rev 245474)
@@ -1,3 +1,19 @@
+2019-05-17  Keith Rollin  <[email protected]>
+
+        Re-enable generate-xcfilelists
+        https://bugs.webkit.org/show_bug.cgi?id=197933
+        <rdar://problem/50831677>
+
+        Reviewed by Jonathan Bedard.
+
+        The following two tasks have been completed, and we can re-enable
+        generate-xcfilelists:
+
+        Bug 197619 <rdar://problem/50507392> Temporarily disable generate-xcfilelists (197619)
+        Bug 197622 <rdar://problem/50508222> Rewrite generate-xcfilelists in Python (197622)
+
+        * Scripts/check-xcfilelists.sh:
+
 2019-05-16  Keith Miller  <[email protected]>
 
         Wasm should cage the memory base pointers in structs

Modified: trunk/Source/_javascript_Core/Scripts/check-xcfilelists.sh (245473 => 245474)


--- trunk/Source/_javascript_Core/Scripts/check-xcfilelists.sh	2019-05-17 19:05:01 UTC (rev 245473)
+++ trunk/Source/_javascript_Core/Scripts/check-xcfilelists.sh	2019-05-17 19:29:17 UTC (rev 245474)
@@ -1,8 +1,5 @@
 #!/bin/sh
 
-# FIXME: Remove this once https://bugs.webkit.org/show_bug.cgi?id=197622 is resolved
-exit 0
-
 [ "${WK_DISABLE_CHECK_XCFILELISTS}" == "1" ] && { echo "### Not running because WK_DISABLE_CHECK_XCFILELISTS is set"; exit 0; }
 [ "${DEPLOYMENT_LOCATION}" == "YES" ] && { echo "### Not running because DEPLOYMENT_LOCATION is YES"; exit 0; }
 [ "${USE_INTERNAL_SDK}" == "YES" ] || { echo "### Not running because USE_INTERNAL_SDK is not YES"; exit 0; }

Modified: trunk/Source/WebCore/ChangeLog (245473 => 245474)


--- trunk/Source/WebCore/ChangeLog	2019-05-17 19:05:01 UTC (rev 245473)
+++ trunk/Source/WebCore/ChangeLog	2019-05-17 19:29:17 UTC (rev 245474)
@@ -1,3 +1,21 @@
+2019-05-17  Keith Rollin  <[email protected]>
+
+        Re-enable generate-xcfilelists
+        https://bugs.webkit.org/show_bug.cgi?id=197933
+        <rdar://problem/50831677>
+
+        Reviewed by Jonathan Bedard.
+
+        The following two tasks have been completed, and we can re-enable
+        generate-xcfilelists:
+
+        Bug 197619 <rdar://problem/50507392> Temporarily disable generate-xcfilelists (197619)
+        Bug 197622 <rdar://problem/50508222> Rewrite generate-xcfilelists in Python (197622)
+
+        No new tests -- no change in user-visible functionality.
+
+        * Scripts/check-xcfilelists.sh:
+
 2019-05-17  Wenson Hsieh  <[email protected]>
 
         Fix a typo in some user agent string logic

Modified: trunk/Source/WebCore/Scripts/check-xcfilelists.sh (245473 => 245474)


--- trunk/Source/WebCore/Scripts/check-xcfilelists.sh	2019-05-17 19:05:01 UTC (rev 245473)
+++ trunk/Source/WebCore/Scripts/check-xcfilelists.sh	2019-05-17 19:29:17 UTC (rev 245474)
@@ -1,8 +1,5 @@
 #!/bin/sh
 
-# FIXME: Remove this once https://bugs.webkit.org/show_bug.cgi?id=197622 is resolved
-exit 0
-
 [ "${WK_DISABLE_CHECK_XCFILELISTS}" == "1" ] && { echo "### Not running because WK_DISABLE_CHECK_XCFILELISTS is set"; exit 0; }
 [ "${DEPLOYMENT_LOCATION}" == "YES" ] && { echo "### Not running because DEPLOYMENT_LOCATION is YES"; exit 0; }
 [ "${USE_INTERNAL_SDK}" == "YES" ] || { echo "### Not running because USE_INTERNAL_SDK is not YES"; exit 0; }

Modified: trunk/Source/WebKit/ChangeLog (245473 => 245474)


--- trunk/Source/WebKit/ChangeLog	2019-05-17 19:05:01 UTC (rev 245473)
+++ trunk/Source/WebKit/ChangeLog	2019-05-17 19:29:17 UTC (rev 245474)
@@ -1,3 +1,19 @@
+2019-05-17  Keith Rollin  <[email protected]>
+
+        Re-enable generate-xcfilelists
+        https://bugs.webkit.org/show_bug.cgi?id=197933
+        <rdar://problem/50831677>
+
+        Reviewed by Jonathan Bedard.
+
+        The following two tasks have been completed, and we can re-enable
+        generate-xcfilelists:
+
+        Bug 197619 <rdar://problem/50507392> Temporarily disable generate-xcfilelists (197619)
+        Bug 197622 <rdar://problem/50508222> Rewrite generate-xcfilelists in Python (197622)
+
+        * Scripts/check-xcfilelists.sh:
+
 2019-05-17  Commit Queue  <[email protected]>
 
         Unreviewed, rolling out r245401.

Modified: trunk/Source/WebKit/Scripts/check-xcfilelists.sh (245473 => 245474)


--- trunk/Source/WebKit/Scripts/check-xcfilelists.sh	2019-05-17 19:05:01 UTC (rev 245473)
+++ trunk/Source/WebKit/Scripts/check-xcfilelists.sh	2019-05-17 19:29:17 UTC (rev 245474)
@@ -1,8 +1,5 @@
 #!/bin/sh
 
-# FIXME: Remove this once https://bugs.webkit.org/show_bug.cgi?id=197622 is resolved
-exit 0
-
 [ "${WK_DISABLE_CHECK_XCFILELISTS}" == "1" ] && { echo "### Not running because WK_DISABLE_CHECK_XCFILELISTS is set"; exit 0; }
 [ "${DEPLOYMENT_LOCATION}" == "YES" ] && { echo "### Not running because DEPLOYMENT_LOCATION is YES"; exit 0; }
 [ "${USE_INTERNAL_SDK}" == "YES" ] || { echo "### Not running because USE_INTERNAL_SDK is not YES"; exit 0; }

Modified: trunk/Tools/ChangeLog (245473 => 245474)


--- trunk/Tools/ChangeLog	2019-05-17 19:05:01 UTC (rev 245473)
+++ trunk/Tools/ChangeLog	2019-05-17 19:29:17 UTC (rev 245474)
@@ -1,3 +1,20 @@
+2019-05-17  Keith Rollin  <[email protected]>
+
+        Re-enable generate-xcfilelists
+        https://bugs.webkit.org/show_bug.cgi?id=197933
+        <rdar://problem/50831677>
+
+        Reviewed by Jonathan Bedard.
+
+        The following two tasks have been completed, and we can re-enable
+        generate-xcfilelists:
+
+        Bug 197619 <rdar://problem/50507392> Temporarily disable generate-xcfilelists (197619)
+        Bug 197622 <rdar://problem/50508222> Rewrite generate-xcfilelists in Python (197622)
+
+        * DumpRenderTree/Scripts/check-xcfilelists.sh:
+        * WebKitTestRunner/Scripts/check-xcfilelists.sh:
+
 2019-05-17  Commit Queue  <[email protected]>
 
         Unreviewed, rolling out r245401.

Modified: trunk/Tools/DumpRenderTree/Scripts/check-xcfilelists.sh (245473 => 245474)


--- trunk/Tools/DumpRenderTree/Scripts/check-xcfilelists.sh	2019-05-17 19:05:01 UTC (rev 245473)
+++ trunk/Tools/DumpRenderTree/Scripts/check-xcfilelists.sh	2019-05-17 19:29:17 UTC (rev 245474)
@@ -1,8 +1,5 @@
 #!/bin/sh
 
-# FIXME: Remove this once https://bugs.webkit.org/show_bug.cgi?id=197622 is resolved
-exit 0
-
 [ "${WK_DISABLE_CHECK_XCFILELISTS}" == "1" ] && { echo "### Not running because WK_DISABLE_CHECK_XCFILELISTS is set"; exit 0; }
 [ "${DEPLOYMENT_LOCATION}" == "YES" ] && { echo "### Not running because DEPLOYMENT_LOCATION is YES"; exit 0; }
 [ "${USE_INTERNAL_SDK}" == "YES" ] || { echo "### Not running because USE_INTERNAL_SDK is not YES"; exit 0; }

Modified: trunk/Tools/WebKitTestRunner/Scripts/check-xcfilelists.sh (245473 => 245474)


--- trunk/Tools/WebKitTestRunner/Scripts/check-xcfilelists.sh	2019-05-17 19:05:01 UTC (rev 245473)
+++ trunk/Tools/WebKitTestRunner/Scripts/check-xcfilelists.sh	2019-05-17 19:29:17 UTC (rev 245474)
@@ -1,8 +1,5 @@
 #!/bin/sh
 
-# FIXME: Remove this once https://bugs.webkit.org/show_bug.cgi?id=197622 is resolved
-exit 0
-
 [ "${WK_DISABLE_CHECK_XCFILELISTS}" == "1" ] && { echo "### Not running because WK_DISABLE_CHECK_XCFILELISTS is set"; exit 0; }
 [ "${DEPLOYMENT_LOCATION}" == "YES" ] && { echo "### Not running because DEPLOYMENT_LOCATION is YES"; exit 0; }
 [ "${USE_INTERNAL_SDK}" == "YES" ] || { echo "### Not running because USE_INTERNAL_SDK is not YES"; exit 0; }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to