Title: [245487] trunk/Tools
- Revision
- 245487
- Author
- [email protected]
- Date
- 2019-05-17 16:41:47 -0700 (Fri, 17 May 2019)
Log Message
[ews-app] Status bubble should not turn orange when any build step has warnings
https://bugs.webkit.org/show_bug.cgi?id=198000
Reviewed by Jonathan Bedard.
* BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
(StatusBubble._does_build_contains_any_failed_step):
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py (245486 => 245487)
--- trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py 2019-05-17 23:11:02 UTC (rev 245486)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py 2019-05-17 23:41:47 UTC (rev 245487)
@@ -155,7 +155,7 @@
def _does_build_contains_any_failed_step(self, build):
for step in build.step_set.all():
- if step.result and step.result != Buildbot.SUCCESS:
+ if step.result and step.result != Buildbot.SUCCESS and step.result != Buildbot.WARNINGS:
return True
return False
Modified: trunk/Tools/ChangeLog (245486 => 245487)
--- trunk/Tools/ChangeLog 2019-05-17 23:11:02 UTC (rev 245486)
+++ trunk/Tools/ChangeLog 2019-05-17 23:41:47 UTC (rev 245487)
@@ -1,3 +1,13 @@
+2019-05-17 Aakash Jain <[email protected]>
+
+ [ews-app] Status bubble should not turn orange when any build step has warnings
+ https://bugs.webkit.org/show_bug.cgi?id=198000
+
+ Reviewed by Jonathan Bedard.
+
+ * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
+ (StatusBubble._does_build_contains_any_failed_step):
+
2019-05-17 Alex Christensen <[email protected]>
Add SPI to set a list of hosts to which to send custom header fields cross-origin
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
