Title: [245489] trunk/Tools
- Revision
- 245489
- Author
- [email protected]
- Date
- 2019-05-17 16:45:38 -0700 (Fri, 17 May 2019)
Log Message
[ews-build] Add clickable url in UI for uploaded S3 archive
https://bugs.webkit.org/show_bug.cgi?id=197996
Reviewed by Jonathan Bedard.
* BuildSlaveSupport/ews-build/steps.py:
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (245488 => 245489)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2019-05-17 23:44:23 UTC (rev 245488)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2019-05-17 23:45:38 UTC (rev 245489)
@@ -790,7 +790,18 @@
kwargs['command'] = self.command
master.MasterShellCommand.__init__(self, logEnviron=False, **kwargs)
+ def start(self):
+ self.log_observer = logobserver.BufferLogObserver(wantStderr=True)
+ self.addLogObserver('stdio', self.log_observer)
+ return super(TransferToS3, self).start()
+
def finished(self, results):
+ log_text = self.log_observer.getStdout() + self.log_observer.getStderr()
+ match = re.search(r'S3 URL: (?P<url>[^\s]+)', log_text)
+ # Sample log: S3 URL: https://s3-us-west-2.amazonaws.com/ews-archives.webkit.org/ios-simulator-12-x86_64-release/123456.zip
+ if match:
+ self.addURL('uploaded archive', match.group('url'))
+
if results == SUCCESS:
triggers = self.getProperty('triggers', None)
if triggers:
Modified: trunk/Tools/ChangeLog (245488 => 245489)
--- trunk/Tools/ChangeLog 2019-05-17 23:44:23 UTC (rev 245488)
+++ trunk/Tools/ChangeLog 2019-05-17 23:45:38 UTC (rev 245489)
@@ -1,5 +1,14 @@
2019-05-17 Aakash Jain <[email protected]>
+ [ews-build] Add clickable url in UI for uploaded S3 archive
+ https://bugs.webkit.org/show_bug.cgi?id=197996
+
+ Reviewed by Jonathan Bedard.
+
+ * BuildSlaveSupport/ews-build/steps.py:
+
+2019-05-17 Aakash Jain <[email protected]>
+
[ews-app] Status bubble should not turn orange when any build step has warnings
https://bugs.webkit.org/show_bug.cgi?id=198000
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
