Title: [245518] trunk/LayoutTests
- Revision
- 245518
- Author
- [email protected]
- Date
- 2019-05-20 10:24:20 -0700 (Mon, 20 May 2019)
Log Message
Hitpoint for link which spans two lines in web content is incorrect
https://bugs.webkit.org/show_bug.cgi?id=197511
<rdar://problem/49971483>
Patch by Andres Gonzalez <[email protected]> on 2019-05-20
Reviewed by Chris Fleizach.
* accessibility/ios-simulator/links-activation.html:
* accessibility/links-activation-expected.txt:
* accessibility/links-activation.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (245517 => 245518)
--- trunk/LayoutTests/ChangeLog 2019-05-20 17:14:33 UTC (rev 245517)
+++ trunk/LayoutTests/ChangeLog 2019-05-20 17:24:20 UTC (rev 245518)
@@ -1,3 +1,15 @@
+2019-05-20 Andres Gonzalez <[email protected]>
+
+ Hitpoint for link which spans two lines in web content is incorrect
+ https://bugs.webkit.org/show_bug.cgi?id=197511
+ <rdar://problem/49971483>
+
+ Reviewed by Chris Fleizach.
+
+ * accessibility/ios-simulator/links-activation.html:
+ * accessibility/links-activation-expected.txt:
+ * accessibility/links-activation.html:
+
2019-05-20 Sihui Liu <[email protected]>
[ Mac WK2 iOS Sim] Layout Test http/tests/resourceLoadStatistics/website-data-removal-for-site-navigated-to-with-link-decoration.html is a flaky failure
Modified: trunk/LayoutTests/accessibility/ios-simulator/links-activation.html (245517 => 245518)
--- trunk/LayoutTests/accessibility/ios-simulator/links-activation.html 2019-05-20 17:14:33 UTC (rev 245517)
+++ trunk/LayoutTests/accessibility/ios-simulator/links-activation.html 2019-05-20 17:24:20 UTC (rev 245518)
@@ -37,8 +37,6 @@
};
if (window.accessibilityController) {
- window.jsTestIsAsync = true;
-
var link = accessibilityController.accessibleElementById("multiline-link");
shouldBeTrue("clickPointInsideFrame(link)");
link.press();
@@ -46,11 +44,6 @@
link = accessibilityController.accessibleElementById("singleline-link");
shouldBeTrue("clickPointInsideFrame(link)");
link.press();
-
- setTimeout(
- function() {
- finishJSTest();
- }, 10);
}
</script>
Modified: trunk/LayoutTests/accessibility/links-activation-expected.txt (245517 => 245518)
--- trunk/LayoutTests/accessibility/links-activation-expected.txt 2019-05-20 17:14:33 UTC (rev 245517)
+++ trunk/LayoutTests/accessibility/links-activation-expected.txt 2019-05-20 17:24:20 UTC (rev 245518)
@@ -12,7 +12,9 @@
click event [object MouseEvent] for element A with id multiline-link
+PASS clicked became true
click event [object MouseEvent] for element A with id singleline-link
+PASS clicked became true
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/accessibility/links-activation.html (245517 => 245518)
--- trunk/LayoutTests/accessibility/links-activation.html 2019-05-20 17:14:33 UTC (rev 245517)
+++ trunk/LayoutTests/accessibility/links-activation.html 2019-05-20 17:24:20 UTC (rev 245518)
@@ -6,7 +6,9 @@
if (window.testRunner)
testRunner.dumpAsText();
+var clicked = false;
function handleClick(event) {
+ clicked = true;
debug("click event " + event
+ " for element " + event.target.nodeName
+ " with id " + event.target.id);
@@ -35,14 +37,15 @@
var link = accessibilityController.accessibleElementById("multiline-link");
link.press();
+ shouldBecomeEqual("clicked", "true", function() {
+ clicked = false;
- link = accessibilityController.accessibleElementById("singleline-link");
- link.press();
-
- setTimeout(
- function() {
+ link = accessibilityController.accessibleElementById("singleline-link");
+ link.press();
+ shouldBecomeEqual("clicked", "true", function() {
finishJSTest();
- }, 10);
+ });
+ });
}
</script>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
