Title: [245521] releases/WebKitGTK/webkit-2.24/Tools
Revision
245521
Author
[email protected]
Date
2019-05-20 10:42:39 -0700 (Mon, 20 May 2019)

Log Message

Merged r243062 - [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
https://bugs.webkit.org/show_bug.cgi?id=195883

Reviewed by Carlos Garcia Campos.

* gtkdoc/gtkdoc.py:
(GTKDoc._run_command): When commands fail to run, include the full command line for
the program invocation and the output it has generated on the standard error stream.

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.24/Tools/ChangeLog (245520 => 245521)


--- releases/WebKitGTK/webkit-2.24/Tools/ChangeLog	2019-05-20 17:41:16 UTC (rev 245520)
+++ releases/WebKitGTK/webkit-2.24/Tools/ChangeLog	2019-05-20 17:42:39 UTC (rev 245521)
@@ -1,3 +1,14 @@
+2019-03-18  Adrian Perez de Castro  <[email protected]>
+
+        [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
+        https://bugs.webkit.org/show_bug.cgi?id=195883
+
+        Reviewed by Carlos Garcia Campos.
+
+        * gtkdoc/gtkdoc.py:
+        (GTKDoc._run_command): When commands fail to run, include the full command line for
+        the program invocation and the output it has generated on the standard error stream.
+
 2019-05-10  Charlie Turner  <[email protected]>
 
         [WPE] Forward libepoxy cflags

Modified: releases/WebKitGTK/webkit-2.24/Tools/gtkdoc/gtkdoc.py (245520 => 245521)


--- releases/WebKitGTK/webkit-2.24/Tools/gtkdoc/gtkdoc.py	2019-05-20 17:41:16 UTC (rev 245520)
+++ releases/WebKitGTK/webkit-2.24/Tools/gtkdoc/gtkdoc.py	2019-05-20 17:42:39 UTC (rev 245521)
@@ -215,8 +215,11 @@
                     sys.stderr.write(stderr)
 
         if process.returncode != 0:
-            raise Exception('%s produced a non-zero return code %i'
-                             % (args[0], process.returncode))
+            raise Exception(('%s produced a non-zero return code %i\n'
+                             'Command:\n  %s\n'
+                             'Error output:\n  %s\n')
+                             % (args[0], process.returncode, " ".join(args),
+                                "\n  ".join(stderr.splitlines())))
 
         if not ignore_warnings and ('warning' in stderr or 'warning' in stdout):
             self.saw_warnings = True
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to