Title: [245594] trunk/Source/_javascript_Core
- Revision
- 245594
- Author
- [email protected]
- Date
- 2019-05-21 13:30:14 -0700 (Tue, 21 May 2019)
Log Message
Fix production build after r245564
https://bugs.webkit.org/show_bug.cgi?id=197898
Reviewed by Keith Miller.
The production configuration should not set CODE_SIGN_IDENTITY.
* Configurations/ToolExecutable.xcconfig:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (245593 => 245594)
--- trunk/Source/_javascript_Core/ChangeLog 2019-05-21 20:01:35 UTC (rev 245593)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-05-21 20:30:14 UTC (rev 245594)
@@ -1,3 +1,14 @@
+2019-05-21 Tadeu Zagallo <[email protected]>
+
+ Fix production build after r245564
+ https://bugs.webkit.org/show_bug.cgi?id=197898
+
+ Reviewed by Keith Miller.
+
+ The production configuration should not set CODE_SIGN_IDENTITY.
+
+ * Configurations/ToolExecutable.xcconfig:
+
2019-05-21 Keith Miller <[email protected]>
Unreviewed, add mistakenly ommited initializer.
Modified: trunk/Source/_javascript_Core/Configurations/ToolExecutable.xcconfig (245593 => 245594)
--- trunk/Source/_javascript_Core/Configurations/ToolExecutable.xcconfig 2019-05-21 20:01:35 UTC (rev 245593)
+++ trunk/Source/_javascript_Core/Configurations/ToolExecutable.xcconfig 2019-05-21 20:30:14 UTC (rev 245594)
@@ -33,8 +33,12 @@
USE_INTERNAL_SDK_Debug = $(HAVE_INTERNAL_SDK);
USE_INTERNAL_SDK_Release = $(HAVE_INTERNAL_SDK);
-CODE_SIGN_IDENTITY[sdk=macosx*] = $(CODE_SIGN_IDENTITY_$(USE_INTERNAL_SDK))
+CODE_SIGN_IDENTITY[sdk=macosx*] = $(CODE_SIGN_IDENTITY_$(CONFIGURATION));
+CODE_SIGN_IDENTITY_Production = $(CODE_SIGN_IDENTITY_NO);
+CODE_SIGN_IDENTITY_Debug = $(CODE_SIGN_IDENTITY_$(USE_INTERNAL_SDK));
+CODE_SIGN_IDENTITY_Release = $(CODE_SIGN_IDENTITY_$(USE_INTERNAL_SDK));
+
CODE_SIGN_IDENTITY_ = $(CODE_SIGN_IDENTITY_NO);
CODE_SIGN_IDENTITY_NO = -;
CODE_SIGN_IDENTITY_YES = $(WK_ENGINEERING_CODE_SIGN_IDENTITY);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
