Title: [245659] trunk/LayoutTests
- Revision
- 245659
- Author
- [email protected]
- Date
- 2019-05-22 16:46:28 -0700 (Wed, 22 May 2019)
Log Message
<rdar://problem/50058173> REGRESSION (r243347) Layout tests fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on* are failing
Unreviewed test gardening.
I confirmed that “cancelable” is no longer true because
WebPageProxy::handleTouchEventSynchronously() is dispatching the events
asynchronously, so setCanPreventNativeGestures is set to false.
The exception is because the “touchEnd” event has no touches.
* fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-block-expected.txt:
* fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-block.html:
* fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-document-expected.txt:
* fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-document.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (245658 => 245659)
--- trunk/LayoutTests/ChangeLog 2019-05-22 23:42:30 UTC (rev 245658)
+++ trunk/LayoutTests/ChangeLog 2019-05-22 23:46:28 UTC (rev 245659)
@@ -1,5 +1,22 @@
2019-05-22 Simon Fraser <[email protected]>
+ <rdar://problem/50058173> REGRESSION (r243347) Layout tests fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on* are failing
+
+ Unreviewed test gardening.
+
+ I confirmed that “cancelable” is no longer true because
+ WebPageProxy::handleTouchEventSynchronously() is dispatching the events
+ asynchronously, so setCanPreventNativeGestures is set to false.
+
+ The exception is because the “touchEnd” event has no touches.
+
+ * fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-block-expected.txt:
+ * fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-block.html:
+ * fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-document-expected.txt:
+ * fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-document.html:
+
+2019-05-22 Simon Fraser <[email protected]>
+
Fix scrolling tree state for more obscure combinations of positioning and paint order
https://bugs.webkit.org/show_bug.cgi?id=198139
Modified: trunk/LayoutTests/fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-block-expected.txt (245658 => 245659)
--- trunk/LayoutTests/fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-block-expected.txt 2019-05-22 23:42:30 UTC (rev 245658)
+++ trunk/LayoutTests/fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-block-expected.txt 2019-05-22 23:46:28 UTC (rev 245659)
@@ -10,8 +10,10 @@
PASS document.documentElement.scrollLeft is 0
PASS document.getElementById('eventTarget').scrollTop is 0
PASS document.getElementById('eventTarget').scrollLeft is 0
-Received cancelable event touchstart at 50, 150
-Received cancelable event touchmove at 50, 50
+Received event touchstart at 50, 150
+Received event touchmove at 50, 50
+Received event touchend
+Dispatched Drag
PASS window.scrollX is 0
PASS window.scrollY is 0
PASS document.documentElement.scrollTop is 0
Modified: trunk/LayoutTests/fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-block.html (245658 => 245659)
--- trunk/LayoutTests/fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-block.html 2019-05-22 23:42:30 UTC (rev 245658)
+++ trunk/LayoutTests/fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-block.html 2019-05-22 23:46:28 UTC (rev 245659)
@@ -45,7 +45,10 @@
eventTarget.addEventListener("scroll", scrollEventHandler);
function touchEventHandler(event) {
- debug("Received" + (event.cancelable ? " cancelable" : "") + " event " + event.type + " at " + event.touches[0].clientX + ", " + event.touches[0].clientY);
+ if (event.touches.length)
+ debug("Received" + (event.cancelable ? " cancelable" : "") + " event " + event.type + " at " + event.touches[0].clientX + ", " + event.touches[0].clientY);
+ else
+ debug("Received" + (event.cancelable ? " cancelable" : "") + " event " + event.type);
}
eventTarget.addEventListener('touchstart', touchEventHandler, { 'passive': true });
eventTarget.addEventListener('touchmove', touchEventHandler, { 'passive': true });
Modified: trunk/LayoutTests/fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-document-expected.txt (245658 => 245659)
--- trunk/LayoutTests/fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-document-expected.txt 2019-05-22 23:42:30 UTC (rev 245658)
+++ trunk/LayoutTests/fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-document-expected.txt 2019-05-22 23:46:28 UTC (rev 245659)
@@ -10,8 +10,10 @@
PASS document.documentElement.scrollLeft is 0
PASS document.getElementById('eventTarget').scrollTop is 0
PASS document.getElementById('eventTarget').scrollLeft is 0
-Received cancelable event touchstart at 50, 150
-Received cancelable event touchmove at 50, 50
+Received event touchstart at 50, 150
+Received event touchmove at 50, 50
+Received event touchend
+Dispatched Drag
PASS window.scrollX is 0
PASS window.scrollY is 0
PASS document.documentElement.scrollTop is 0
Modified: trunk/LayoutTests/fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-document.html (245658 => 245659)
--- trunk/LayoutTests/fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-document.html 2019-05-22 23:42:30 UTC (rev 245658)
+++ trunk/LayoutTests/fast/events/touch/ios/drag-block-without-overflow-scroll-and-passive-observer-on-document.html 2019-05-22 23:46:28 UTC (rev 245659)
@@ -45,7 +45,10 @@
eventTarget.addEventListener("scroll", scrollEventHandler);
function touchEventHandler(event) {
- debug("Received" + (event.cancelable ? " cancelable" : "") + " event " + event.type + " at " + event.touches[0].clientX + ", " + event.touches[0].clientY);
+ if (event.touches.length)
+ debug("Received" + (event.cancelable ? " cancelable" : "") + " event " + event.type + " at " + event.touches[0].clientX + ", " + event.touches[0].clientY);
+ else
+ debug("Received" + (event.cancelable ? " cancelable" : "") + " event " + event.type);
}
document.addEventListener('touchstart', touchEventHandler, { 'passive': true });
document.addEventListener('touchmove', touchEventHandler, { 'passive': true });
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
