Title: [245696] trunk/Source/WebInspectorUI
- Revision
- 245696
- Author
- [email protected]
- Date
- 2019-05-23 11:04:49 -0700 (Thu, 23 May 2019)
Log Message
Web Inspector: clicking a source link should never open the Network tab
https://bugs.webkit.org/show_bug.cgi?id=197951
Reviewed by Timothy Hatcher.
The preview panel in the Network tab is really meant to be just that; a preview.
Opening resources in the preview panel is not a great experience, as the Network tab doesn't
have as much of the information one would expect when viewing a resource (namely the
Resource details sidebar panel).
Navigating within the Network tab also completely wipes out the current "state" of what
you're looking at (e.g. which panel), which could be unexpected.
The only way this could happen previously was if the Resources/Debugger/Sources tabs had
never been active at any point in the past. Selecting one of those tabs and then clicking on
an initiator link in the Network tab would re-select that other tab.
* UserInterface/Base/Main.js:
(WI.dialogWasDismissedWithRepresentedObject):
* UserInterface/Views/ResourceHeadersContentView.js:
(WI.ResourceHeadersContentView.prototype._refreshSummarySection):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (245695 => 245696)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-05-23 18:02:13 UTC (rev 245695)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-05-23 18:04:49 UTC (rev 245696)
@@ -1,3 +1,29 @@
+2019-05-23 Devin Rousso <[email protected]>
+
+ Web Inspector: clicking a source link should never open the Network tab
+ https://bugs.webkit.org/show_bug.cgi?id=197951
+
+ Reviewed by Timothy Hatcher.
+
+ The preview panel in the Network tab is really meant to be just that; a preview.
+
+ Opening resources in the preview panel is not a great experience, as the Network tab doesn't
+ have as much of the information one would expect when viewing a resource (namely the
+ Resource details sidebar panel).
+
+ Navigating within the Network tab also completely wipes out the current "state" of what
+ you're looking at (e.g. which panel), which could be unexpected.
+
+ The only way this could happen previously was if the Resources/Debugger/Sources tabs had
+ never been active at any point in the past. Selecting one of those tabs and then clicking on
+ an initiator link in the Network tab would re-select that other tab.
+
+ * UserInterface/Base/Main.js:
+ (WI.dialogWasDismissedWithRepresentedObject):
+
+ * UserInterface/Views/ResourceHeadersContentView.js:
+ (WI.ResourceHeadersContentView.prototype._refreshSummarySection):
+
2019-05-22 Nikita Vasilyev <[email protected]>
Web Inspector: Provide UIString descriptions to improve localizations
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (245695 => 245696)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2019-05-23 18:02:13 UTC (rev 245695)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2019-05-23 18:04:49 UTC (rev 245696)
@@ -3235,7 +3235,10 @@
if (!representedObject)
return;
- WI.showRepresentedObject(representedObject, dialog.cookie);
+ WI.showRepresentedObject(representedObject, dialog.cookie, {
+ ignoreSearchTab: true,
+ ignoreNetworkTab: true,
+ });
};
// Popover delegate
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ResourceHeadersContentView.js (245695 => 245696)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ResourceHeadersContentView.js 2019-05-23 18:02:13 UTC (rev 245695)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ResourceHeadersContentView.js 2019-05-23 18:04:49 UTC (rev 245696)
@@ -270,6 +270,7 @@
const options = {
dontFloat: true,
ignoreSearchTab: true,
+ ignoreNetworkTab: true,
};
let link = WI.createSourceCodeLocationLink(initiatorLocation, options);
fragment.appendChild(link);
@@ -283,7 +284,7 @@
this._popoverCallStackIconElement.addEventListener("click", (event) => {
if (!this._popover) {
this._popover = new WI.Popover(this);
- this._popover.windowResizeHandler = () => { this._presentPopoverBelowCallStackElement() };
+ this._popover.windowResizeHandler = () => { this._presentPopoverBelowCallStackElement(); };
}
const selectable = false;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
