Title: [245724] trunk/Source/WebCore
Revision
245724
Author
[email protected]
Date
2019-05-23 16:13:45 -0700 (Thu, 23 May 2019)

Log Message

[WHLSL] Don't wrap anonymous variables in parens in the AST dumper
https://bugs.webkit.org/show_bug.cgi?id=198196

Reviewed by Myles C. Maxfield.

This makes the dump of 'foo.bar.x = 42' go from
($(0x7f86d9d94440) = &foo, $(0x7f86d9d944e0) = operator.bar(*$(0x7f86d9d94440)), $(0x7f86d9d944e0) = operator.x=($(0x7f86d9d944e0), 42), *$(0x7f86d9d94440) = operator.bar=(*$(0x7f86d9d94440), $(0x7f86d9d944e0)));

to:
($0x7f86d9d94440 = &foo, $0x7f86d9d944e0 = operator.bar(*$0x7f86d9d94440), $0x7f86d9d944e0 = operator.x=($0x7f86d9d944e0, 42), *$0x7f86d9d94440 = operator.bar=(*$0x7f86d9d94440, $0x7f86d9d944e0));

* Modules/webgpu/WHLSL/WHLSLASTDumper.cpp:
(WebCore::WHLSL::ASTDumper::visit):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (245723 => 245724)


--- trunk/Source/WebCore/ChangeLog	2019-05-23 22:58:23 UTC (rev 245723)
+++ trunk/Source/WebCore/ChangeLog	2019-05-23 23:13:45 UTC (rev 245724)
@@ -1,3 +1,19 @@
+2019-05-23  Saam barati  <[email protected]>
+
+        [WHLSL] Don't wrap anonymous variables in parens in the AST dumper
+        https://bugs.webkit.org/show_bug.cgi?id=198196
+
+        Reviewed by Myles C. Maxfield.
+
+        This makes the dump of 'foo.bar.x = 42' go from
+        ($(0x7f86d9d94440) = &foo, $(0x7f86d9d944e0) = operator.bar(*$(0x7f86d9d94440)), $(0x7f86d9d944e0) = operator.x=($(0x7f86d9d944e0), 42), *$(0x7f86d9d94440) = operator.bar=(*$(0x7f86d9d94440), $(0x7f86d9d944e0)));
+        
+        to:
+        ($0x7f86d9d94440 = &foo, $0x7f86d9d944e0 = operator.bar(*$0x7f86d9d94440), $0x7f86d9d944e0 = operator.x=($0x7f86d9d944e0, 42), *$0x7f86d9d94440 = operator.bar=(*$0x7f86d9d94440, $0x7f86d9d944e0));
+
+        * Modules/webgpu/WHLSL/WHLSLASTDumper.cpp:
+        (WebCore::WHLSL::ASTDumper::visit):
+
 2019-05-23  Myles C. Maxfield  <[email protected]>
 
         [WHLSL] Implement property resolver

Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLASTDumper.cpp (245723 => 245724)


--- trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLASTDumper.cpp	2019-05-23 22:58:23 UTC (rev 245723)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLASTDumper.cpp	2019-05-23 23:13:45 UTC (rev 245724)
@@ -636,7 +636,7 @@
 void ASTDumper::visit(AST::VariableReference& variableReference)
 {
     if (variableReference.name().isEmpty())
-        m_out.print("$(", RawPointer(variableReference.variable()), ")");
+        m_out.print("$", RawPointer(variableReference.variable()));
     else
         m_out.print(variableReference.name());
 }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to