Title: [245757] trunk/Source/WebKit
- Revision
- 245757
- Author
- [email protected]
- Date
- 2019-05-24 15:48:26 -0700 (Fri, 24 May 2019)
Log Message
Remove unused member in WebsiteDataRecord
https://bugs.webkit.org/show_bug.cgi?id=198231
Reviewed by Brent Fulgham.
The data member 'originsWithCredentials' in WebsiteDataRecord is no longer needed since origins
with credentials are now stored in the 'origins' member.
* UIProcess/WebsiteData/WebsiteDataRecord.cpp:
(WebKit::WebsiteDataRecord::addOriginWithCredential): Deleted.
* UIProcess/WebsiteData/WebsiteDataRecord.h:
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::fetchDataAndApply):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (245756 => 245757)
--- trunk/Source/WebKit/ChangeLog 2019-05-24 22:13:02 UTC (rev 245756)
+++ trunk/Source/WebKit/ChangeLog 2019-05-24 22:48:26 UTC (rev 245757)
@@ -1,3 +1,19 @@
+2019-05-24 Per Arne Vollan <[email protected]>
+
+ Remove unused member in WebsiteDataRecord
+ https://bugs.webkit.org/show_bug.cgi?id=198231
+
+ Reviewed by Brent Fulgham.
+
+ The data member 'originsWithCredentials' in WebsiteDataRecord is no longer needed since origins
+ with credentials are now stored in the 'origins' member.
+
+ * UIProcess/WebsiteData/WebsiteDataRecord.cpp:
+ (WebKit::WebsiteDataRecord::addOriginWithCredential): Deleted.
+ * UIProcess/WebsiteData/WebsiteDataRecord.h:
+ * UIProcess/WebsiteData/WebsiteDataStore.cpp:
+ (WebKit::WebsiteDataStore::fetchDataAndApply):
+
2019-05-24 David Quesada <[email protected]>
Crash under WebCore::TimerBase::~TimerBase after a download is canceled
Modified: trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataRecord.cpp (245756 => 245757)
--- trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataRecord.cpp 2019-05-24 22:13:02 UTC (rev 245756)
+++ trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataRecord.cpp 2019-05-24 22:48:26 UTC (rev 245757)
@@ -153,10 +153,4 @@
return emptyString();
}
-void WebsiteDataRecord::addOriginWithCredential(const String& origin)
-{
- types.add(WebsiteDataType::Credentials);
- originsWithCredentials.add(origin);
}
-
-}
Modified: trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataRecord.h (245756 => 245757)
--- trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataRecord.h 2019-05-24 22:13:02 UTC (rev 245756)
+++ trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataRecord.h 2019-05-24 22:48:26 UTC (rev 245757)
@@ -53,7 +53,6 @@
#if ENABLE(NETSCAPE_PLUGIN_API)
void addPluginDataHostName(const String& hostName);
#endif
- void addOriginWithCredential(const String&);
void addHSTSCacheHostname(const String& hostName);
String displayName;
@@ -70,7 +69,6 @@
#if ENABLE(NETSCAPE_PLUGIN_API)
HashSet<String> pluginDataHostNames;
#endif
- HashSet<String> originsWithCredentials;
HashSet<String> HSTSCacheHostNames;
bool matches(const WebCore::RegistrableDomain&) const;
Modified: trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp (245756 => 245757)
--- trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp 2019-05-24 22:13:02 UTC (rev 245756)
+++ trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp 2019-05-24 22:48:26 UTC (rev 245757)
@@ -319,17 +319,6 @@
}
#endif
- for (auto& origin : websiteData.originsWithCredentials) {
- auto displayName = WebsiteDataRecord::displayNameForOrigin(WebCore::SecurityOriginData::fromURL(URL(URL(), origin)));
- ASSERT(!displayName.isEmpty());
-
- auto& record = m_websiteDataRecords.add(displayName, WebsiteDataRecord { }).iterator->value;
- if (!record.displayName)
- record.displayName = WTFMove(displayName);
-
- record.addOriginWithCredential(origin);
- }
-
for (auto& hostName : websiteData.hostNamesWithHSTSCache) {
auto displayName = WebsiteDataRecord::displayNameForHostName(hostName);
if (!displayName)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
