Skip to site navigation (Press enter)

[webkit-changes] [245843] trunk/Tools

justin_michaud Tue, 28 May 2019 20:28:38 -0700

Title: [245843] trunk/Tools

Revision: 245843
Author: [email protected]
Date: 2019-05-28 20:27:47 -0700 (Tue, 28 May 2019)

Log Message

Attempt to fix JSC test timeouts after adding collectContinuously to WASM tests.
https://bugs.webkit.org/show_bug.cgi?id=198322


Reviewed by Saam Barati.

Increases the collection period from 1 to slightly higher to try to speed up the tests. Any higher and
the test runner does not detect the bug that required the memset in Wasm::Instance::Instance().

* Scripts/run-jsc-stress-tests:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-jsc-stress-tests

Diff

Modified: trunk/Tools/ChangeLog (245842 => 245843)


--- trunk/Tools/ChangeLog	2019-05-29 03:08:31 UTC (rev 245842)
+++ trunk/Tools/ChangeLog	2019-05-29 03:27:47 UTC (rev 245843)
@@ -1,3 +1,15 @@
+2019-05-28  Justin Michaud  <[email protected]>
+
+        Attempt to fix JSC test timeouts after adding collectContinuously to WASM tests.
+        https://bugs.webkit.org/show_bug.cgi?id=198322
+
+        Reviewed by Saam Barati.
+
+        Increases the collection period from 1 to slightly higher to try to speed up the tests. Any higher and
+        the test runner does not detect the bug that required the memset in Wasm::Instance::Instance().
+
+        * Scripts/run-jsc-stress-tests:
+
 2019-05-28  Wenson Hsieh  <[email protected]>
 
         [iOS] Respect NSItemProvider's registered types when dropping files that are loaded in-place

Modified: trunk/Tools/Scripts/run-jsc-stress-tests (245842 => 245843)


--- trunk/Tools/Scripts/run-jsc-stress-tests	2019-05-29 03:08:31 UTC (rev 245842)
+++ trunk/Tools/Scripts/run-jsc-stress-tests	2019-05-29 03:27:47 UTC (rev 245843)
@@ -1081,7 +1081,7 @@
         run("wasm-no-tls-context", "-m", "--useFastTLSForWasmContext=false", *FTL_OPTIONS)
         run("wasm-slow-memory", "-m", "--useWebAssemblyFastMemory=false", *FTL_OPTIONS)
         run("wasm-no-air", "-m", "--wasmBBQUsesAir=false", *FTL_OPTIONS)
-        run("wasm-collect-continuously", "-m", "--collectContinuously=true", *FTL_OPTIONS)
+        run("wasm-collect-continuously", "-m", "--collectContinuously=true", "--collectContinuouslyPeriodMS=1.3", *FTL_OPTIONS)
     end
 end
 
@@ -1099,7 +1099,7 @@
         run("wasm-no-tls-context", "-m", "--useFastTLSForWasmContext=false", *FTL_OPTIONS)
         run("wasm-slow-memory", "-m", "--useWebAssemblyFastMemory=false", *FTL_OPTIONS)
         run("wasm-no-air", "-m", "--wasmBBQUsesAir=false", *FTL_OPTIONS)
-        run("wasm-collect-continuously", "-m", "--collectContinuously=true", *FTL_OPTIONS)
+        run("wasm-collect-continuously", "-m", "--collectContinuously=true", "--collectContinuouslyPeriodMS=1.3", *FTL_OPTIONS)
     end
 end
 
@@ -1119,7 +1119,7 @@
         run("wasm-no-call-ic", "--useCallICsForWebAssemblyToJSCalls=false", *FTL_OPTIONS)
         run("wasm-no-tls-context", "--useFastTLSForWasmContext=false", *FTL_OPTIONS)
         run("wasm-no-air", "--wasmBBQUsesAir=false", *FTL_OPTIONS)
-        run("wasm-collect-continuously", "--collectContinuously=true", *FTL_OPTIONS)
+        run("wasm-collect-continuously", "--collectContinuously=true", "--collectContinuouslyPeriodMS=1.3", *FTL_OPTIONS)
     end
 end
 
@@ -1145,7 +1145,7 @@
       runWithOutputHandler("wasm-no-call-ic", noisyOutputHandler, "../spec-harness.js", "--useCallICsForWebAssemblyToJSCalls=false", *FTL_OPTIONS)
       runWithOutputHandler("wasm-no-tls-context", noisyOutputHandler, "../spec-harness.js", "--useFastTLSForWasmContext=false", *FTL_OPTIONS)
       runWithOutputHandler("wasm-no-air", noisyOutputHandler, "../spec-harness.js", "--wasmBBQUsesAir=false", *FTL_OPTIONS)
-      runWithOutputHandler("wasm-collect-continuously", noisyOutputHandler, "../spec-harness.js", "--collectContinuously=true", *FTL_OPTIONS)
+      runWithOutputHandler("wasm-collect-continuously", noisyOutputHandler, "../spec-harness.js", "--collectContinuously=true", "--collectContinuouslyPeriodMS=1.3", *FTL_OPTIONS)
     end
 end

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes