Title: [245861] trunk/Source/WebCore
- Revision
- 245861
- Author
- [email protected]
- Date
- 2019-05-29 12:16:35 -0700 (Wed, 29 May 2019)
Log Message
Fix builds that don't use makeWindowFromView
https://bugs.webkit.org/show_bug.cgi?id=198342
<rdar://problem/51228563>
Reviewed by Wenson Hsieh.
In some configurations, VideoFullscreenInterfaceAVKit.mm declares but
does not use makeWindowFromView. Fix by conditionalizing the the
declaration on the same symbol as point where it's used.
No new tests -- no new functionality.
* platform/ios/VideoFullscreenInterfaceAVKit.mm:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (245860 => 245861)
--- trunk/Source/WebCore/ChangeLog 2019-05-29 19:15:26 UTC (rev 245860)
+++ trunk/Source/WebCore/ChangeLog 2019-05-29 19:16:35 UTC (rev 245861)
@@ -1,3 +1,19 @@
+2019-05-29 Keith Rollin <[email protected]>
+
+ Fix builds that don't use makeWindowFromView
+ https://bugs.webkit.org/show_bug.cgi?id=198342
+ <rdar://problem/51228563>
+
+ Reviewed by Wenson Hsieh.
+
+ In some configurations, VideoFullscreenInterfaceAVKit.mm declares but
+ does not use makeWindowFromView. Fix by conditionalizing the the
+ declaration on the same symbol as point where it's used.
+
+ No new tests -- no new functionality.
+
+ * platform/ios/VideoFullscreenInterfaceAVKit.mm:
+
2019-05-28 Geoffrey Garen <[email protected]>
WeakPtr breaks vtables when upcasting to base classes
Modified: trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm (245860 => 245861)
--- trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm 2019-05-29 19:15:26 UTC (rev 245860)
+++ trunk/Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm 2019-05-29 19:16:35 UTC (rev 245861)
@@ -1177,6 +1177,7 @@
doExitFullscreen();
}
+#if !PLATFORM(WATCHOS)
#if USE(APPLE_INTERNAL_SDK)
#import <WebKitAdditions/VideoFullscreenInterfaceAVKitAdditions.mm>
#else
@@ -1185,6 +1186,7 @@
return adoptNS([PAL::allocUIWindowInstance() initWithFrame:[[PAL::getUIScreenClass() mainScreen] bounds]]);
}
#endif
+#endif
void VideoFullscreenInterfaceAVKit::doSetup()
{
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
