Title: [245877] trunk/LayoutTests
- Revision
- 245877
- Author
- [email protected]
- Date
- 2019-05-29 16:23:49 -0700 (Wed, 29 May 2019)
Log Message
REGRESSION (r244182) [Mac WK2] Layout Test imported/w3c/web-platform-tests/visual-viewport/viewport-resize-event-on-load-overflowing-page.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=197286
Patch by Said Abou-Hallawa <[email protected]> on 2019-05-29
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
This is a time sensitive test. It expects to receive a resize event within
two frames after the page load. Scheduling the page update through the
RenderingUpdate made updating the page for the first time happens not
immediately after the page load but after an additional frame.
So we need to wait for this additional frame before checking whether the
'resize' event was fired.
* web-platform-tests/visual-viewport/viewport-resize-event-on-load-overflowing-page.html:
LayoutTests:
* platform/mac-wk2/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (245876 => 245877)
--- trunk/LayoutTests/ChangeLog 2019-05-29 23:07:29 UTC (rev 245876)
+++ trunk/LayoutTests/ChangeLog 2019-05-29 23:23:49 UTC (rev 245877)
@@ -1,3 +1,12 @@
+2019-05-29 Said Abou-Hallawa <[email protected]>
+
+ REGRESSION (r244182) [Mac WK2] Layout Test imported/w3c/web-platform-tests/visual-viewport/viewport-resize-event-on-load-overflowing-page.html is a flaky failure
+ https://bugs.webkit.org/show_bug.cgi?id=197286
+
+ Reviewed by Simon Fraser.
+
+ * platform/mac-wk2/TestExpectations:
+
2019-05-29 Youenn Fablet <[email protected]>
Reestablish WebSWClientConnection in case of network process crash
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (245876 => 245877)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2019-05-29 23:07:29 UTC (rev 245876)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2019-05-29 23:23:49 UTC (rev 245877)
@@ -1,3 +1,20 @@
+2019-05-29 Said Abou-Hallawa <[email protected]>
+
+ REGRESSION (r244182) [Mac WK2] Layout Test imported/w3c/web-platform-tests/visual-viewport/viewport-resize-event-on-load-overflowing-page.html is a flaky failure
+ https://bugs.webkit.org/show_bug.cgi?id=197286
+
+ Reviewed by Simon Fraser.
+
+ This is a time sensitive test. It expects to receive a resize event within
+ two frames after the page load. Scheduling the page update through the
+ RenderingUpdate made updating the page for the first time happens not
+ immediately after the page load but after an additional frame.
+
+ So we need to wait for this additional frame before checking whether the
+ 'resize' event was fired.
+
+ * web-platform-tests/visual-viewport/viewport-resize-event-on-load-overflowing-page.html:
+
2019-05-29 Antoine Quint <[email protected]>
[Pointer Events] toElement and fromElement should be null
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/visual-viewport/viewport-resize-event-on-load-overflowing-page.html (245876 => 245877)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/visual-viewport/viewport-resize-event-on-load-overflowing-page.html 2019-05-29 23:07:29 UTC (rev 245876)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/visual-viewport/viewport-resize-event-on-load-overflowing-page.html 2019-05-29 23:23:49 UTC (rev 245877)
@@ -26,9 +26,15 @@
});
window.addEventListener('load', function() {
- requestAnimationFrame(function() {
- requestAnimationFrame(
- t.step_func_done(function() {
+ var count = 0;
+ requestAnimationFrame(function step() {
+ // Wait for two RenderingUpdates before checking the value of numViewResizes.
+ if (count++ < 2) {
+ requestAnimationFrame(step);
+ return;
+ }
+
+ requestAnimationFrame(t.step_func_done(function() {
var isOverlay = calculateScrollbarThickness() == 0;
assert_equals(numViewResizes, isOverlay ? 0 : 1);
}));
Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (245876 => 245877)
--- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2019-05-29 23:07:29 UTC (rev 245876)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2019-05-29 23:23:49 UTC (rev 245877)
@@ -942,8 +942,6 @@
webkit.org/b/197207 http/wpt/resource-timing/rt-resources-per-frame.html [ Pass Failure ]
-webkit.org/b/197286 imported/w3c/web-platform-tests/visual-viewport/viewport-resize-event-on-load-overflowing-page.html [ Pass Failure ]
-
webkit.org/b/197425 [ Mojave Debug ] scrollingcoordinator/scrolling-tree/scrolling-tree-includes-frame.html [ Pass Failure ]
webkit.org/b/197662 [ Debug ] imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-getStats.https.html [ Pass Failure ]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
