Title: [245907] trunk/Tools
- Revision
- 245907
- Author
- [email protected]
- Date
- 2019-05-30 16:06:34 -0700 (Thu, 30 May 2019)
Log Message
DragAndDropTests.DataTransferExposePlainTextWithFileURLAsFile API test is failing
https://bugs.webkit.org/show_bug.cgi?id=198389
<rdar://problem/51266096>
Reviewed by Tim Horton.
This test started failing, since the fallback name for a dropped text file changed from "text.txt" to
"Document.txt" on newer iOS SDK versions. We simply fix this test by checking that the name of the file ends
with ".txt", and that the MIME type of the file is "text/plain".
* TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
(TestWebKitAPI::TEST):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (245906 => 245907)
--- trunk/Tools/ChangeLog 2019-05-30 21:40:35 UTC (rev 245906)
+++ trunk/Tools/ChangeLog 2019-05-30 23:06:34 UTC (rev 245907)
@@ -1,3 +1,18 @@
+2019-05-30 Wenson Hsieh <[email protected]>
+
+ DragAndDropTests.DataTransferExposePlainTextWithFileURLAsFile API test is failing
+ https://bugs.webkit.org/show_bug.cgi?id=198389
+ <rdar://problem/51266096>
+
+ Reviewed by Tim Horton.
+
+ This test started failing, since the fallback name for a dropped text file changed from "text.txt" to
+ "Document.txt" on newer iOS SDK versions. We simply fix this test by checking that the name of the file ends
+ with ".txt", and that the MIME type of the file is "text/plain".
+
+ * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
+ (TestWebKitAPI::TEST):
+
2019-05-30 Sihui Liu <[email protected]>
Stop StorageManager when network process is ready to suspend
Modified: trunk/Tools/TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm (245906 => 245907)
--- trunk/Tools/TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm 2019-05-30 21:40:35 UTC (rev 245906)
+++ trunk/Tools/TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm 2019-05-30 23:06:34 UTC (rev 245907)
@@ -1921,7 +1921,10 @@
EXPECT_WK_STREQ("", [webView stringByEvaluatingJavaScript:@"urlData.textContent"]);
EXPECT_WK_STREQ("", [webView stringByEvaluatingJavaScript:@"htmlData.textContent"]);
EXPECT_WK_STREQ("(FILE, text/plain)", [webView stringByEvaluatingJavaScript:@"items.textContent"]);
- EXPECT_WK_STREQ("('text.txt', text/plain)", [webView stringByEvaluatingJavaScript:@"files.textContent"]);
+
+ NSString *filesOutput = [webView stringByEvaluatingJavaScript:@"files.textContent"];
+ EXPECT_TRUE([filesOutput containsString:@"text/plain)"]);
+ EXPECT_TRUE([filesOutput containsString:@".txt', "]);
}
TEST(DragAndDropTests, DataTransferGetDataCannotReadPrivateArbitraryTypes)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
