Title: [245920] branches/safari-607-branch/Source/WebKit
- Revision
- 245920
- Author
- [email protected]
- Date
- 2019-05-30 17:29:58 -0700 (Thu, 30 May 2019)
Log Message
Cherry-pick r245284. rdar://problem/51264857
Protect current WebFrame during form submission
https://bugs.webkit.org/show_bug.cgi?id=197459
<rdar://problem/50368618>
Reviewed by Alex Christensen.
The 'continueWillSubmitForm' method calls a completion handler that
might affect the state of the current frame. Ensure the frame is valid
for the scope of the function.
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::continueWillSubmitForm):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245284 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-607-branch/Source/WebKit/ChangeLog (245919 => 245920)
--- branches/safari-607-branch/Source/WebKit/ChangeLog 2019-05-31 00:29:55 UTC (rev 245919)
+++ branches/safari-607-branch/Source/WebKit/ChangeLog 2019-05-31 00:29:58 UTC (rev 245920)
@@ -1,5 +1,39 @@
2019-05-30 Kocsen Chung <[email protected]>
+ Cherry-pick r245284. rdar://problem/51264857
+
+ Protect current WebFrame during form submission
+ https://bugs.webkit.org/show_bug.cgi?id=197459
+ <rdar://problem/50368618>
+
+ Reviewed by Alex Christensen.
+
+ The 'continueWillSubmitForm' method calls a completion handler that
+ might affect the state of the current frame. Ensure the frame is valid
+ for the scope of the function.
+
+ * WebProcess/WebPage/WebFrame.cpp:
+ (WebKit::WebFrame::continueWillSubmitForm):
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245284 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2019-05-14 Brent Fulgham <[email protected]>
+
+ Protect current WebFrame during form submission
+ https://bugs.webkit.org/show_bug.cgi?id=197459
+ <rdar://problem/50368618>
+
+ Reviewed by Alex Christensen.
+
+ The 'continueWillSubmitForm' method calls a completion handler that
+ might affect the state of the current frame. Ensure the frame is valid
+ for the scope of the function.
+
+ * WebProcess/WebPage/WebFrame.cpp:
+ (WebKit::WebFrame::continueWillSubmitForm):
+
+2019-05-30 Kocsen Chung <[email protected]>
+
Cherry-pick r244781. rdar://problem/51264871
Long-standing rare crash under -[WKWebView _web_immediateActionAnimationControllerForHitTestResultInternal...]
Modified: branches/safari-607-branch/Source/WebKit/WebProcess/WebPage/WebFrame.cpp (245919 => 245920)
--- branches/safari-607-branch/Source/WebKit/WebProcess/WebPage/WebFrame.cpp 2019-05-31 00:29:55 UTC (rev 245919)
+++ branches/safari-607-branch/Source/WebKit/WebProcess/WebPage/WebFrame.cpp 2019-05-31 00:29:58 UTC (rev 245920)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2010-2016 Apple Inc. All rights reserved.
+ * Copyright (C) 2010-2019 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -233,6 +233,7 @@
void WebFrame::continueWillSubmitForm(uint64_t listenerID)
{
+ Ref<WebFrame> protectedThis(*this);
if (auto completionHandler = m_willSubmitFormCompletionHandlers.take(listenerID))
completionHandler();
invalidatePolicyListener();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
