Title: [245929] branches/safari-607-branch/Source/WebCore
- Revision
- 245929
- Author
- [email protected]
- Date
- 2019-05-30 17:30:25 -0700 (Thu, 30 May 2019)
Log Message
Apply patch. rdar://problem/50801017
Modified Paths
Diff
Modified: branches/safari-607-branch/Source/WebCore/ChangeLog (245928 => 245929)
--- branches/safari-607-branch/Source/WebCore/ChangeLog 2019-05-31 00:30:23 UTC (rev 245928)
+++ branches/safari-607-branch/Source/WebCore/ChangeLog 2019-05-31 00:30:25 UTC (rev 245929)
@@ -1,5 +1,23 @@
2019-05-30 Kocsen Chung <[email protected]>
+ Apply patch. rdar://problem/50801017
+
+ 2019-05-30 Brent Fulgham <[email protected]>
+
+ Improve safety of HitTest logic
+ https://bugs.webkit.org/show_bug.cgi?id=198030
+ <rdar://problem/50801017>
+
+ Reviewed by Alan Bujtas.
+
+ Don't use the RenderView during hit testing until after all
+ layout is complete.
+
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::hitTest):
+
+2019-05-30 Kocsen Chung <[email protected]>
+
Cherry-pick r245664. rdar://problem/51264774
Subselectors not searched when determining property whitelist for selector
Modified: branches/safari-607-branch/Source/WebCore/rendering/RenderView.cpp (245928 => 245929)
--- branches/safari-607-branch/Source/WebCore/rendering/RenderView.cpp 2019-05-31 00:30:23 UTC (rev 245928)
+++ branches/safari-607-branch/Source/WebCore/rendering/RenderView.cpp 2019-05-31 00:30:25 UTC (rev 245929)
@@ -144,7 +144,12 @@
bool RenderView::hitTest(const HitTestRequest& request, const HitTestLocation& location, HitTestResult& result)
{
+ auto weakRenderView = makeWeakPtr(this);
+
document().updateLayout();
+
+ if (!weakRenderView)
+ return false;
#if !ASSERT_DISABLED
SetForScope<bool> hitTestRestorer { m_inHitTesting, true };
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
